Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230503013608.2431726-1-nphamcs@gmail.com> <20230503013608.2431726-4-nphamcs@gmail.com>
 <877ctfa6yv.fsf@mail.lhotse>
In-Reply-To: <877ctfa6yv.fsf@mail.lhotse>
From:   Nhat Pham <nphamcs@gmail.com>
Date:   Thu, 11 May 2023 12:33:05 -0700
Message-ID: <CAKEwX=MX+2Y-Qt5xSS_DF66X6aqrkOAUVi2vSt68K4y1_s4Lqw@mail.gmail.com>
Subject: Re: [PATCH v13 3/3] selftests: Add selftests for cachestat
To:     Michael Ellerman <mpe@ellerman.id.au>
Cc:     akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, bfoster@redhat.com,
        willy@infradead.org, linux-api@vger.kernel.org,
        kernel-team@meta.com, linuxppc-dev@lists.ozlabs.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 10, 2023 at 8:21=E2=80=AFPM Michael Ellerman <mpe@ellerman.id.a=
u> wrote:
>
> Nhat Pham <nphamcs@gmail.com> writes:
> > Test cachestat on a newly created file, /dev/ files, and /proc/ files.
> > Also test on a shmem file (which can also be tested with huge pages
> > since tmpfs supports huge pages).
> >
> > Signed-off-by: Nhat Pham <nphamcs@gmail.com>
> ...
> > diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools=
/testing/selftests/cachestat/test_cachestat.c
> > new file mode 100644
> > index 000000000000..c3823b809c25
> > --- /dev/null
> > +++ b/tools/testing/selftests/cachestat/test_cachestat.c
> > @@ -0,0 +1,258 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +#define _GNU_SOURCE
> > +
> > +#include <stdio.h>
> > +#include <stdbool.h>
> > +#include <linux/kernel.h>
> > +#include <linux/mman.h>
> > +#include <sys/mman.h>
> > +#include <sys/shm.h>
> > +#include <sys/syscall.h>
> > +#include <unistd.h>
> > +#include <string.h>
> > +#include <fcntl.h>
> > +#include <errno.h>
> > +
> > +#include "../kselftest.h"
> > +
> > +static const char * const dev_files[] =3D {
> > +     "/dev/zero", "/dev/null", "/dev/urandom",
> > +     "/proc/version", "/proc"
> > +};
> > +static const int cachestat_nr =3D 451;
> > +
> > +void print_cachestat(struct cachestat *cs)
> > +{
> > +     ksft_print_msg(
> > +     "Using cachestat: Cached: %lu, Dirty: %lu, Writeback: %lu, Evicte=
d: %lu, Recently Evicted: %lu\n",
> > +     cs->nr_cache, cs->nr_dirty, cs->nr_writeback,
> > +     cs->nr_evicted, cs->nr_recently_evicted);
> > +}
> > +
> > +bool write_exactly(int fd, size_t filesize)
> > +{
> > +     char data[filesize];
>
> On kernels with 64K pages (powerpc at least), this tries to allocate
> 64MB on the stack which segfaults.
>
> Allocating data with malloc avoids the problem and allows the test to
> pass.
>
> Looks like this commit is still in mm-unstable, so maybe Andrew can
> squash the incremental diff below in, if it looks OK to you. The diff is
> a bit big because I unindented the body of the function.
>
> cheers
>
>
> diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/t=
esting/selftests/cachestat/test_cachestat.c
> index 9be2262e5c17..54d09b820ed4 100644
> --- a/tools/testing/selftests/cachestat/test_cachestat.c
> +++ b/tools/testing/selftests/cachestat/test_cachestat.c
> @@ -31,48 +31,59 @@ void print_cachestat(struct cachestat *cs)
>
>  bool write_exactly(int fd, size_t filesize)
>  {
> -       char data[filesize];
> -       bool ret =3D true;
>         int random_fd =3D open("/dev/urandom", O_RDONLY);
> +       char *cursor, *data;
> +       int remained;
> +       bool ret;
>
>         if (random_fd < 0) {
>                 ksft_print_msg("Unable to access urandom.\n");
>                 ret =3D false;
>                 goto out;
> -       } else {
> -               int remained =3D filesize;
> -               char *cursor =3D data;
> +       }
>
> -               while (remained) {
> -                       ssize_t read_len =3D read(random_fd, cursor, rema=
ined);
> +       data =3D malloc(filesize);
> +       if (!data) {
> +               ksft_print_msg("Unable to allocate data.\n");
> +               ret =3D false;
> +               goto close_random_fd;
> +       }
>
> -                       if (read_len <=3D 0) {
> -                               ksft_print_msg("Unable to read from urand=
om.\n");
> -                               ret =3D false;
> -                               goto close_random_fd;
> -                       }
> +       remained =3D filesize;
> +       cursor =3D data;
>
> -                       remained -=3D read_len;
> -                       cursor +=3D read_len;
> +       while (remained) {
> +               ssize_t read_len =3D read(random_fd, cursor, remained);
> +
> +               if (read_len <=3D 0) {
> +                       ksft_print_msg("Unable to read from urandom.\n");
> +                       ret =3D false;
> +                       goto out_free_data;
>                 }
>
> -               /* write random data to fd */
> -               remained =3D filesize;
> -               cursor =3D data;
> -               while (remained) {
> -                       ssize_t write_len =3D write(fd, cursor, remained)=
;
> +               remained -=3D read_len;
> +               cursor +=3D read_len;
> +       }
>
> -                       if (write_len <=3D 0) {
> -                               ksft_print_msg("Unable write random data =
to file.\n");
> -                               ret =3D false;
> -                               goto close_random_fd;
> -                       }
> +       /* write random data to fd */
> +       remained =3D filesize;
> +       cursor =3D data;
> +       while (remained) {
> +               ssize_t write_len =3D write(fd, cursor, remained);
>
> -                       remained -=3D write_len;
> -                       cursor +=3D write_len;
> +               if (write_len <=3D 0) {
> +                       ksft_print_msg("Unable write random data to file.=
\n");
> +                       ret =3D false;
> +                       goto out_free_data;
>                 }
> +
> +               remained -=3D write_len;
> +               cursor +=3D write_len;
>         }
>
> +       ret =3D true;
> +out_free_data:
> +       free(data);
>  close_random_fd:
>         close(random_fd);
>  out:
>

Oh this is nice! I had to make a similar fix in another test
of mine, but forgot about it in this context.

LGTM. For verification, I have applied the diff and test on
my own local setup. Things still pass.

Acked-by: Nhat Pham <nphamcs@gmail.com>