Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp9390569rwr; Thu, 11 May 2023 14:21:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6nNDFJRjpn5tFKYgT+f6I4YqHZTLDls17t42wilM96YSBXGFRWQIwrLL/XSwEQiC7WeX87 X-Received: by 2002:a17:90a:b00a:b0:250:1905:ae7b with SMTP id x10-20020a17090ab00a00b002501905ae7bmr22665252pjq.27.1683840075410; Thu, 11 May 2023 14:21:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683840075; cv=none; d=google.com; s=arc-20160816; b=hhMtRe/0zOMZNMtqjCJAm4MXOxwCHXK5hxg29Ptse8qMuuUNeMLHew2Asvb+Gj0LBN 1TgsPw48ZnQvpy6RTBtyq2X51INh6yo9Z5aqk0A6AxqW18rRynNziC7TywFIIklO+l/i +EsQyryo5Vt1usFVVG7FcXfL+gfFBd+YLPsueOecrIv5UrzRTMQpnLac91cT5wJpvKaR 6TmNU7c7Uye2LQVqpFT8zBHbCBWhjPIr3T7j7JeLCIYrTlUZseQYJFh4APcumPk6e1pk xXjiccBMc/G4sWpsXYoFL+qvJBEVchNNYy3ezbFc0kvkJVv+R+3RjZuHnDwFqC2lRKUZ G39g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=iMJSAuzmDEOyslGFpKNIuHv7WTx2jYS+xwESl4OR1aU=; b=KCVOccYWau9/GEeDvbayd4qYnRsqilYi/O3G6OtrorOIAzAEtz7FtWi6CMtlyLiImH d2MNXOQe0bSFzslCpkn+0tEbIttmCmZ5zWdfcGvRK7whcPka9heDui39/OFX5AAxhTn6 mlpJ7T1yxVP2YsvYMDa6x7lZKGwJyW+W0T/TknuFzvhL6DMrSX0B2gRTHY8oD6wwN/TR fsy/otGk9lzUoC/Pd8kUZAX5coghIosnXtES67P9JLceDkkYNUpygNHP+vpHoTZHUlRZ nhG5pNQb3KXRiYquqkNZYkUgJYMx3zEDWQb6fYO2T5mOk7+6CfZ9WqHIxSnHdPACHdxt knig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="JrlILs/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id em14-20020a17090b014e00b0024765bb4f7esi20428884pjb.25.2023.05.11.14.21.04; Thu, 11 May 2023 14:21:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="JrlILs/F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239160AbjEKVH5 (ORCPT + 99 others); Thu, 11 May 2023 17:07:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239197AbjEKVH4 (ORCPT ); Thu, 11 May 2023 17:07:56 -0400 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1486C10F6 for ; Thu, 11 May 2023 14:07:51 -0700 (PDT) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-55c939fb24dso85722467b3.2 for ; Thu, 11 May 2023 14:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683839270; x=1686431270; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iMJSAuzmDEOyslGFpKNIuHv7WTx2jYS+xwESl4OR1aU=; b=JrlILs/FJvcqjFimI5g8pLCwZ7MlikV+mp66z3cACXcbS1BbgdeUUlwPgpDYjOZ9N5 JEcC+QlYiJQB7bxuXZuug+8mQXYNE4D4eFkybnQ3pnEjFqw7zgqwVrvCGajgde2f4Mcq GOUKw/vsgB0PLN2AoH0WRkZ4lkkCU1Ylf+McKd01DUUSqGOMKozMV1idVjXpuW+69+by Kj65G4SKjtiP3DpPGJ+2mlrLS4FvsYr2x+HtVwQJjLnt6d5ua/w7ZXP2ofUBRz1ZgXiN /CJPKvt6C3OTXYCaEW5EEqq6exRx+7x7Iohej2pGkTN+QRIalksSCq65PFEhO/EYZB0v 3aig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683839270; x=1686431270; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iMJSAuzmDEOyslGFpKNIuHv7WTx2jYS+xwESl4OR1aU=; b=OzQRtnx1G2dIuvKZVAqwNIuKadXzKDWfwDmOAvPGcNmi46UxnWW58RjuyCOHaTX/Pi Zu4rLJDQZJtNEivt4CQ1hEwPbO0s0iE7jGLyg6KJcK+//yLEPZQF0pLrOWik9nmqXWqE rADoLcl+5O6kU2NCGy5j0KjkWWdp8wSxUYOXwfXalRyZ0a+nOq1pRKu4TAq7wMXoq6DR 8SAA6wWvoxUKEE7DEein3dK/OcTKF/4UbBLmr933SN6lMP8dD3xmwRFgQ5KzpcwbdwwL Hm2jioaj8HRdoyWT+u7xxYgxsj/gf+TuxOPfAPGExZ4+77ZzLRxHptFM10lqzeTf7wmp VtFA== X-Gm-Message-State: AC+VfDwGcOkbkmAzoU1+/HDvGCk8RDjbAnVgpYAo7il10zE388tmcw4b NoQQIgMTovX4OE5C6VdioZhv0SI5Z/VAxRS1m8Usew== X-Received: by 2002:a25:aa0c:0:b0:b9d:b5f0:3b33 with SMTP id s12-20020a25aa0c000000b00b9db5f03b33mr20809376ybi.58.1683839270282; Thu, 11 May 2023 14:07:50 -0700 (PDT) MIME-Version: 1.0 References: <20230511175844.185070-1-xiang.ye@intel.com> <20230511175844.185070-5-xiang.ye@intel.com> In-Reply-To: <20230511175844.185070-5-xiang.ye@intel.com> From: Linus Walleij Date: Thu, 11 May 2023 23:07:38 +0200 Message-ID: Subject: Re: [PATCH v8 4/6] gpio: Add support for Intel LJCA USB GPIO driver To: Ye Xiang Cc: Greg Kroah-Hartman , Arnd Bergmann , Matthias Kaehlcke , Lee Jones , Wolfram Sang , Tyrone Ting , Mark Brown , Marc Zyngier , Bartosz Golaszewski , linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org, srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com, andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com, zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 11, 2023 at 8:01=E2=80=AFPM Ye Xiang wrote= : > Implements the GPIO function of Intel USB-I2C/GPIO/SPI adapter > device named "La Jolla Cove Adapter" (LJCA). It communicate with > LJCA GPIO module with specific protocol through interfaces exported > by LJCA USB driver. > > Signed-off-by: Ye Xiang Overall this looks very nice. > +static int gpio_config(struct ljca_gpio_dev *ljca_gpio, u8 gpio_id, u8 c= onfig) All other functions are prefixed ljca_* except this one, so I think you should do that on this one too. With that fixes: Reviewed-by: Linus Walleij Yours, Linus Walleij