Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7f6c0fc4-abfa-4e73-7cff-ce04239bb54c@intel.com>
Date:   Thu, 11 May 2023 14:38:14 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.1
Subject: Re: [PATCH v1 5/9] x86/resctrl: Call mon_event_count() directly for
 soft RMIDs
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     Babu Moger <babu.moger@amd.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Stephane Eranian <eranian@google.com>,
        James Morse <james.morse@arm.com>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20230421141723.2405942-1-peternewman@google.com>
 <20230421141723.2405942-6-peternewman@google.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230421141723.2405942-6-peternewman@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHRXdjdxYmFLVUs0WWFzc0dWMkFkSmZ6eWlEc3IrRmhUcWsxWjRUdWN2UmVW?=
 =?utf-8?B?RWZ4NGVZUnJNV3JqaENqczFidlA0a0JmalVmSm51bmpJUFZOdnlyNStpTDhT?=
 =?utf-8?B?cWVNWUV2RS9MeGpxSmlEOTBuS3FMRmhsa2hidGRKQXBUT1ZlbEVRcVNCN2tj?=
 =?utf-8?B?Y1dpMnB4L2dNL0MzV1diVUEwWkNRRzRiTFhYenZQNmpscFV6NDJKN29wN3NV?=
 =?utf-8?B?eFI2QytEbS8xYXFLdncxRTh0RTkyS0E2ZXExNDY5V3krMzdlTjNvWnpMVnkz?=
 =?utf-8?B?SzRwNGhuQnVEcUlWemxLb09CR01sVG1iVVlVaC9sYW9XSURlZjJqWWlqZjRR?=
 =?utf-8?B?ZjNDUys3STNsNHM2MEtUZWI0QUROUjlpOXNFWHIyTHhMc25mbzYvSlNJbDNv?=
 =?utf-8?B?TnNVZU1ZOE5SNUlnaDN2L0tnYjcxajl1dUEzaGozbUpuKy9lT2dYYUEvSW9V?=
 =?utf-8?B?Ym1EM21pS0lJMjhLRjc1QkVTUWxHRFFyeDhqNnl1WXE3Z3lDZzVvaGc4ZWZF?=
 =?utf-8?B?S2N2b1FMNi84bno4NExFcEo0SDR0bnFpV3ZQSXFwVUdTZTU2cDVTem1QU01G?=
 =?utf-8?B?K2NwWVVybkVHRFRDUUphdEp1UDF1WXlmcVQ0alVwa3dBWWJTdUM1VElrNVMw?=
 =?utf-8?B?aFE5aTdxNUoxNGFMakt6VlMyeDJiQlQxaEhGSjlyQzZlMnQ4aVUrdzlXeEk1?=
 =?utf-8?B?R0E0cHllckxFbGtmSWNacm9xcUdqcENucTFsT0xZb0R5WFQ2VmxhVEVNTFJa?=
 =?utf-8?B?NnRzNjk0eEdNQmxBM0VZamx6YjRFbFp2VWRnWWNnWUlyTjY4WVVQSWtvV1JL?=
 =?utf-8?B?V0wybWI0bDNFVFJrTFZLbWpkWGV4UVYvVDdndHVTTnMzbmZMVnQ5NEhVcVR4?=
 =?utf-8?B?WlpkS20yUVlFTHFCZi96ZmFQU3d5MTJKZjNMMEcvdUo3MHE3SnZoRFEzVHpj?=
 =?utf-8?B?L2lRRFZnNDVhQjM5L0s3K0thbWhuOXhCOFJDcFZlMFlVYjNZdEZZUWdOeHJs?=
 =?utf-8?B?d2JhK0x1VzV3TjJBdjJTNG9VUU0zT2FYZktzaWJRMUNPdUlXZk5MenFjT1Nl?=
 =?utf-8?B?Wm5nbnY0dDVZLzd5TzhhazBGaDJYaXh5Uk1SNUwxQkdLOXZtbVNTUVZGa2hY?=
 =?utf-8?B?QVNZMlZyd0hXVHJ5YnorSVBLazc5d2E0RDY5U0NEWTVNdzVBRDBoSjBtSVJp?=
 =?utf-8?B?aVB0bkVrVFR6cHdWS3JGdWRxemJIemlGaEZCQ2dsekd5OG5YZTZkbnJRSlp1?=
 =?utf-8?B?cmp3MDc4Ni9la0QvdEFJVWt4VnFRaE5FOXU0b3JtQjk3M3c0NUF1QzJycmFk?=
 =?utf-8?B?dXcxMm1wbE9IRnYzQ2M2UzFzT0lYSGZ0dkIrVjFVSVVoMFNYSkJsSzAwY1dF?=
 =?utf-8?B?WXMxaXpiOWFPZGVHQTd2MkVBVHJFTDYzVGx4aSsvd3ZWc3dPbEdIN2JBeVJT?=
 =?utf-8?B?emZNSlBvS0FLcC9oNWxHeFlla3liby9hTkVDb1dMclF3UzVxd2RuaVBnVVYr?=
 =?utf-8?B?U3d0NnRFSW9Tcmo0dm1XcnpvTjl1Y0ZDM2IzQTZZVU4yVUQ1U0h3Qmk4UmJn?=
 =?utf-8?B?Slh1cEF2dGR4OXVBTTEzTHY4YlVINzhLR2Q2WUk2amRPMDV2NGJZUnFVckkz?=
 =?utf-8?B?eGlqWERhc3cvOWpTNlk4bVlrVTBMVGU1L0VnbFJELzFocW91dWNkdHA3dzM3?=
 =?utf-8?B?NXhxSDRhSDdVZ3YrMERIVm9IQmdyVnMwTVljT083Ymt6U3ZwWS9TZVBna2JV?=
 =?utf-8?B?SC9XcXpDby8rZGdWRUwyWVA0U0NsQWVtSG9yVTNQQlJvQzFNVjlSRFBDdEVS?=
 =?utf-8?B?UnNzT3lkbFVMNWdpVk10VkE2aDQ5Q3A1bkk0NlNacEhHZTFpVmMrL2poVkdB?=
 =?utf-8?B?OVowVU9ZRnZiV1BySjUrek5UQzJleFl2c3ZJc1g0MWxacmtQUDRaQzZFZnd5?=
 =?utf-8?B?NCtpSmlIRFFhdzgrRENiYmFqUTNPM2Z2RU1CZ0lBczE5UEdFajJ1c1JIMnd1?=
 =?utf-8?B?Y0VMOWZKelpUY1Z4UE5PQzRYeDNQc1ZnNk5US2pLcVhRNVI0UnJSTHp6REZK?=
 =?utf-8?B?UzJvemEzL3poNGhRaVdydHhLVFRveXY2aFFBZ3VCYi9KN05zMmt2UHZFSGF2?=
 =?utf-8?B?RUV6YUVLamtseTVKZk83RkZwQ3BpL1RPaEluTTRraldjZ3pEdGRvMGNCZlpp?=
 =?utf-8?B?Ymc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b919b084-65ff-4412-24ec-08db526807ff
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 21:38:16.8906
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oAPC+3W8hUfBfH/UPs585/0p+vR2h/hdKaiOuDrXquqGGKJTueSqAwejuoysTtnA6WQ9ZjttfHkpHvPkF+RUOmWFAwqUUFRwa2txw0MUSiQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5964
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 4/21/2023 7:17 AM, Peter Newman wrote:
> There is no point in using IPIs to call mon_event_count() when it is
> only reading software counters from memory.
> 
> When RMIDs are soft, mon_event_read() just calls mon_event_count()
> directly.

From this patch forward the patch ordering is a bit confusing.
At this time mon_event_count() does not read software counters
from memory so I think this change should move to later.

Also, note that rdt_mon_soft_rmid is introduced here but 
the reader is left wondering how it is set until the final patch
in this series.

Reinette