Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c27972ef-1b17-36dd-50b8-790f7994733f@intel.com>
Date:   Thu, 11 May 2023 14:40:43 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.1
Subject: Re: [PATCH v1 8/9] x86/resctrl: Use mbm_update() to push soft RMID
 counts
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     Babu Moger <babu.moger@amd.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Stephane Eranian <eranian@google.com>,
        James Morse <james.morse@arm.com>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20230421141723.2405942-1-peternewman@google.com>
 <20230421141723.2405942-9-peternewman@google.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230421141723.2405942-9-peternewman@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHFRM1p0YyttNU1SZVVXTTRhSHlQbU9YVnlrS1dPZEJhNk02b2RDYTdJSE16?=
 =?utf-8?B?YlNXY3lyeWtiekx2aUZCRHJuVjVPVUtFUmVlcGVnRUxldkRsUkVqUGNMVXFC?=
 =?utf-8?B?MzhsRzVlMmMyOUxxWi9Ld0d2YTJFV0lEaElidEpabG9zWVl5ZExmaFZvR2ZF?=
 =?utf-8?B?SU94czNYRmRaK2I1ckVLSElJMjJrWEdqM0hrWnFHTFlZU09YUytydzZSVklE?=
 =?utf-8?B?T3Y4YWIzeHBYWkJMSVdLSEdndXh4bGkvTHNlaHpMTjV1ZlBpNWdPWm1rMmw0?=
 =?utf-8?B?MC8rVDVHV1RWUG5BUU9QRGNBQS8xOXVaY1NOelNMZUNzNm1KSUpqalcvNkl0?=
 =?utf-8?B?V3UxSi9VSWNkSkdsTCtWQkloeU1DaEloM3Y5UERjM0wrNjlxUmJwbnRTL2Zj?=
 =?utf-8?B?RXdBcnF3YlVwU3liWjhobzdsOUlJWkdBQW1Kb3g2T3ZVQW1rRVVRUlZtUUxt?=
 =?utf-8?B?SDA3Rkk0NnorandvQW1veWUxY3BYWFJQOFBGRzZXbm1kQ1laNlorclpYcmNx?=
 =?utf-8?B?MDl1SG1TNUVDMjRCbUxDbkF4Wml0Q1lQRjN0eXAyd2FDdjlrellKcXd3Z2ti?=
 =?utf-8?B?WUNFNndJWUFEaTU2VDZDcnZvTUFLb3FGWFdMMUhNVzVQdjBjMWFhcUxXWWlZ?=
 =?utf-8?B?ME5ua01KTFRjMHZ5QkJGcDZ1KzJwY2x1S3BQZ1hJSS9SZ25iWUZHWlpRMTVo?=
 =?utf-8?B?TWNhSFllYXBUUmdkNFlzVnROd2UyaDlDV3YwaXdPZnB2ZG1UQ0grRVNCbUZ6?=
 =?utf-8?B?emJtMEZGT29jdzk5NTU0NzVla001L2xsd0Z2b0pIbHh5N05OeHRnZ3FFS1J1?=
 =?utf-8?B?UHZxczEyMEFNb1g4QkEyMDliTHI5QWN1cEl3OTI1a3JESmV1U3M0aHc5NkE1?=
 =?utf-8?B?QXZ2bXl3V01yWTRIdHpkV3ordHE2YzJmZ21rQjlwdkVzaDA5cGdyVUk3UmtV?=
 =?utf-8?B?RHIraVNISk56dmpaTnVvZ2hMVjR1SGpzSEQranJUdTNrMGRENGxvQ1l0UHZh?=
 =?utf-8?B?djRpQkFZdnlwc2Q1SmtQaG1OQ3VYTnFNSEl4MnFobGFZaWdBUGNWWWRQNE8z?=
 =?utf-8?B?ZktGZDVJVm53Uys0YVBHTGViZ3lvaTdSMDZldUZPU2RYKzEzUllmbHJJYWQw?=
 =?utf-8?B?WWVMb0Z5bXgzVHBpUk9sTlRJcEpXbzdINUpNK2c2SFNndXBWL1pJeTFOT2tI?=
 =?utf-8?B?TzlRcXMxblc4M0c0NU5tQ0pEdnRYWG9XRXVRWSszcFZUbC9qV1BuUzNWWHlr?=
 =?utf-8?B?WGV0YmFSRUMvOGFmSXJGV2Yzc2lFMWFtTFd4bE5uTWlQWjBlRVMyeGdhTDV1?=
 =?utf-8?B?OVdJMXIvd0s2cjYzK0hNMmlEWHhUNmVEc1ZJTXpMREFLNHB4cUtBdHZYKy8w?=
 =?utf-8?B?OXQySlFnUFBkMy94RFQ0YmoreUJUazhzZnJRazFySkNlS1NheHZCYUsrMU1h?=
 =?utf-8?B?RDFiS3JLZ2VTMlhESTdWWHR5WStWV0tZUTQ3dVp4dTJjeWdoSVYvVFV5cW94?=
 =?utf-8?B?S0JNRlREZEorTTFhakxIZ0tudk1lUXd0ei81YWgvSzdXaFcwMzZ6TXF6TmhG?=
 =?utf-8?B?RjhSc3I1bDJtYlkxV041dVlwWEg5VzNsdW5pZEVYZDAxaTR1U2htMHJ5T0dv?=
 =?utf-8?B?Si91ZXRHSE9NcXdHZzNJSDJSVTRhMTB0UFViR2ZBV2t1dzVqV243TnVGSU1L?=
 =?utf-8?B?OXhpYTJhYXNxODkzV1cwTUpld2VVZ3c1eFZPUGtNcUdpVFlzaWxhR2VjaHpL?=
 =?utf-8?B?aHNHeU9uWlE0WlB1ak1xWVUrT3NhY2liNjdnNHZ2cUw5d2JxbnhhYzAyTStv?=
 =?utf-8?B?dFArajdTMVBJaWtZSkd0bDZPUDA0S3RqemFnVXpOVXNZUU1meUV4WXJWaHhE?=
 =?utf-8?B?ajRzVUppdDlPNTVrbW5SbWhqdXJ4aFhLV1FSOWpBcVE1NGxZRXd4bVpuVFlv?=
 =?utf-8?B?Z05veFFpZU51Nkl2UVJwTW9nZjhhSWJKSjVwbG1LMS9SdmtTOHNVQzdHVVRy?=
 =?utf-8?B?RGFETDlnVmQ5d0UxczVOM1VqWnljWEdXMml3eUp1OFlIK1hQdkVDZFdCMUxR?=
 =?utf-8?B?dzdWZkFCK2FjcCtzbHVqYlZ2MDE5ZVppRi9iNnNLYzhjUEZ6MkdaRW03b1c4?=
 =?utf-8?B?OGxjL1VScnF0Y01ZVFhlOUxXNnNVOUwycFNibUphVzUxcUVkbS9aQ3RoODky?=
 =?utf-8?B?K0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d38fd84-2217-4f02-d217-08db5268609a
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 21:40:45.5447
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +5Rbk7K7TGTfSf9PTC+BdDZI/isNcdxJnkxmXi37FoOXO/GQGJnCUE95Fr0s6taZWiZTjPwMBkoqt7ivc7wq85KCbmJdo+q5X2ZvXujtcTI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6109
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 4/21/2023 7:17 AM, Peter Newman wrote:
> @@ -806,12 +811,27 @@ void mbm_handle_overflow(struct work_struct *work)
>  	r = &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl;
>  	d = container_of(work, struct rdt_domain, mbm_over.work);
>  
> +	if (rdt_mon_soft_rmid) {
> +		/*
> +		 * HW RMIDs are permanently assigned to CPUs, so only a per-CPU
> +		 * flush is needed.
> +		 */
> +		on_each_cpu_mask(&d->cpu_mask, mbm_flush_cpu_handler, NULL,
> +				 false);
> +	}
> +
>  	list_for_each_entry(prgrp, &rdt_all_groups, rdtgroup_list) {
> -		mbm_update(r, d, prgrp->mon.rmid);
> +		/*
> +		 * mbm_update() on every RMID would result in excessive IPIs
> +		 * when RMIDs are soft.
> +		 */
> +		if (!rdt_mon_soft_rmid) {
> +			mbm_update(r, d, prgrp->mon.rmid);
>  
> -		head = &prgrp->mon.crdtgrp_list;
> -		list_for_each_entry(crgrp, head, mon.crdtgrp_list)
> -			mbm_update(r, d, crgrp->mon.rmid);
> +			head = &prgrp->mon.crdtgrp_list;
> +			list_for_each_entry(crgrp, head, mon.crdtgrp_list)
> +				mbm_update(r, d, crgrp->mon.rmid);
> +		}
>  
>  		if (is_mba_sc(NULL))
>  			update_mba_bw(prgrp, d);


hmmm ... I think that update_mba_bw() relies on mbm_update() to call
mbm_bw_count() to update the data it depends on. Keeping update_mba_bw()
while dropping mbm_update() thus seems problematic. AMD does not support the
software controller though so it may make things simpler if support for
software RMIDs disables support for software controller (in a clear way).

Reinette