Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1a84e1ad-4f6a-17e2-b49f-bf02c7b70fa2@intel.com>
Date:   Thu, 11 May 2023 14:38:45 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.1
Subject: Re: [PATCH v1 6/9] x86/resctrl: Create soft RMID version of
 __mon_event_count()
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     Babu Moger <babu.moger@amd.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Stephane Eranian <eranian@google.com>,
        James Morse <james.morse@arm.com>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20230421141723.2405942-1-peternewman@google.com>
 <20230421141723.2405942-7-peternewman@google.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230421141723.2405942-7-peternewman@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QStzdFY0R21VU1ErTzNPbGpINDJnT1J6cU54N2N1SUljOWFBRVl0UGlUcnJn?=
 =?utf-8?B?YzVVSkxjVURkUHQ5WnFQcDE5MXpNaWZ2U0t2NjJGYVdVU05CKzlMeERoajhu?=
 =?utf-8?B?QXA5T2JWNnlWeFVLR3JXMmVIcHZFSzYrMjVrNmNjVlY4Umsrd3kyaWk4MCtL?=
 =?utf-8?B?VUhDTEdzZk54dWdnSThQRXVwWExJWm9mYjJtR3JESWNnRlY3bmREa2ZYODIr?=
 =?utf-8?B?dEU1d2t6UjFqakZTOUtqK3RXMko3OXZnbm1xNjEvNjFXWWs0WXZZYjlVdit4?=
 =?utf-8?B?dVMrZ1Vqb1pWOHU1OW5CYnRGUGlFOUtTVXN0dVU2TlpEejRTcmdHVzFWVWd3?=
 =?utf-8?B?ZytzNnZROFBVeWhoMTNuVWNVd2x4TnBWa2ZuU2pJdDI3THp5V3dLUFd3NDR2?=
 =?utf-8?B?VkFIbSsrU2svaTAyTVFLRFlnMGpBMTFvZ1JVYXdJelBYNW1aMFNXOUlndXhX?=
 =?utf-8?B?WVlubEFhMXNrU1FhZ0ZscWdYalRDSnphMC9HS05LZ3VlMHhoT0FtWGNtUk44?=
 =?utf-8?B?bzZ5L0YvWVB2SElUc0FJNnpFZXdJV0tEK2Y1dWJmRURYUUxzSlJpakZlMEpY?=
 =?utf-8?B?endHUHBPcm1TWjFxZnVXcmJ4bEt0blRTOHhSWitmT0dHbWJsWlZGZWJDdi9S?=
 =?utf-8?B?QkRSUUhCbXowWGdtL2pyeGRqMURkQlg5S24rcWFPdk5RTG5XTXJmYllLVjgr?=
 =?utf-8?B?ZXFmSEJqcjVPU09rVFZ6aTQvR0ZQTHZPaGcyKzNTekxMZCthQ2oyWE83aTNY?=
 =?utf-8?B?dnNwV1Z3SHlScTRQTEo0YlZXSjhyU0lFK0ptcEdaSVRPLzVmZFM5OEM4THdw?=
 =?utf-8?B?d0dCTzNEWUJmK0RyeUJCVFgrcVEyNUJXZ2NSMUFqVFF3dkNQSXlSMEdJTnhF?=
 =?utf-8?B?dTY0bjRhWjdUK1YzRjJtZDU3VXpyZi9mQUJ2RGJUbC9hUkdaYi9tSys4cDhU?=
 =?utf-8?B?SFN5NFcvTkVGemRNRG1aNTF0VDVKenFpbkc4RVNhTWVrVE03ajJmL3dSalZC?=
 =?utf-8?B?TmlkREZtQU5NN3M1QkNlVzFkWlEvbVVHTlRkUDZ3am45eWJ3eVNERnN6cGhr?=
 =?utf-8?B?ViszSmV2V2ptR3JudDQrQm1ySGVEdWtESklmYVJXczdJVlZEbXVtSXpYemdI?=
 =?utf-8?B?T3lTWEJwNTE1L2ZLTFVWSnFEdzNBT2hKbmNGaHE4WHlGQVQ1NFZKWXV2UkF6?=
 =?utf-8?B?VEtLN2FWOW5LZHhjR2llV3NyVTRpbmllY0hldkttcUlUaXBNZDJINlV4d2t2?=
 =?utf-8?B?akdoSEZOYmxxb1dpQ1lVeUNtUW5PRUo5TzhSUUVzMmhyTitWWk9VeUNzRFBH?=
 =?utf-8?B?WnJOb01QRmRmYmxvWmJscjdCMjU4dE9uTjhHQXdOaGhOaVZBRVFHYi9oSTlh?=
 =?utf-8?B?QkdxWHhoV2hnK1JKTnU1blFJWmhwRlVvK0EzbXlNcWFCY1VKSWlQbmJaKzhp?=
 =?utf-8?B?dVdwdVhMKzlWblhsNjc4YXRkWmZkd0crRHdNY2RyaFV4dEd1aGExY1djZWkx?=
 =?utf-8?B?VktCTGo5SlprQllINUpxZlFRWDNVenhGcTMvSTBOcmY4cTF1UWdzdDNvNTk1?=
 =?utf-8?B?MmlXcklpVDFlK0RtMWRCaktFRVFtcnpwcjhEMmIyc1lJU0JJK21TVktRTnZB?=
 =?utf-8?B?YlNIb2pUbTc1UGpPc0Q3R2UzeHBZVDBEZmpGVW9KeERseVhRNDBtck82bmo1?=
 =?utf-8?B?ZzdpWGZYcERuMnFaMUlyN0xrWXlMOThKM3BvSEtZNmc0TTJoSHlEMloyMlNq?=
 =?utf-8?B?WEFYUTVSUlV5V2lHNTN3cmdMdFV6bHlmNU5BRnZSVHJrUWZCY0U3S3hSK0p2?=
 =?utf-8?B?V1djTDJvaU96dm43K0tadldHMzlQMjY1ZXRPY1J4L1pLdUtsZnRHOWo5eklz?=
 =?utf-8?B?VkdnVDlyaW8xMzRIZjBJTEJRenhMa1JwYUt4cXVycE1oV0k0anlVckxMbTJh?=
 =?utf-8?B?blJCdVdDVzVNbS9sV3BFZEZPc3hKUU8zbDlaU3Nscy92Qkd3UDBPZjcwaHYx?=
 =?utf-8?B?eG83S3YvZ1NDc25XZ3VBang1aUhBd09FbEp2c2szWFZSaW9Qc1U3aGNxQUJI?=
 =?utf-8?B?MkluUk5OZzJSVDE5VmJCWGpJYTcvZlUwRlhhV3NTbzNTejBPdms0cHFCNFox?=
 =?utf-8?B?c2dYcEprcEd2OVZRc3pXREo3M0JoYnJwV3E2UzVibndsWVg1ZldEa2QxY01I?=
 =?utf-8?B?SlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bc4c87aa-6637-4c83-bc51-08db52681a35
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 21:38:47.4397
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LXfIvTHDRox5+YmtWrm0Ck+0ngYjWQ3gizHwwdlEu/kzzWoxMHvf9FcN6LTDOdI64mpQOFUawYIbZnpIt4lRvx4ZCGu0EL5gTEN1mcFB1Z0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5964
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 4/21/2023 7:17 AM, Peter Newman wrote:
> When RMIDs are soft, __mon_event_count() only needs to report the
> current byte count in memory and should not touch the hardware RMIDs.
> 
> Create a parallel version for the soft RMID configuration and update
> __mon_event_count() to choose between it and the original depending on
> whether the soft RMID static key is enabled.

Please note that the changelog refers to "whether the soft RMID static
key is enabled" but the patch uses a bool instead of a static key.

> 
> Signed-off-by: Peter Newman <peternewman@google.com>
> ---
>  arch/x86/kernel/cpu/resctrl/monitor.c | 33 ++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
> index bb857eefa3b0..3d54a634471a 100644
> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
> @@ -487,7 +487,30 @@ void resctrl_mbm_flush_cpu(void)
>  		__mbm_flush(QOS_L3_MBM_TOTAL_EVENT_ID, r, d);
>  }
>  
> -static int __mon_event_count(u32 rmid, struct rmid_read *rr)
> +static int __mon_event_count_soft_rmid(u32 rmid, struct rmid_read *rr)
> +{
> +	struct mbm_state *m;
> +
> +	WARN_ON(!is_mbm_event(rr->evtid));
> +	m = get_mbm_state(rr->d, rmid, rr->evtid);
> +	if (!m)
> +		/* implies !is_mbm_event(...) */
> +		return -1;
> +
> +	rr->val += atomic64_read(&m->soft_rmid_bytes);
> +
> +	if (rr->first) {
> +		/*
> +		 * Discard any bandwidth resulting from the initial HW counter
> +		 * reads.
> +		 */
> +		atomic64_set(&m->soft_rmid_bytes, 0);
> +	}

The above is not clear to me. If rr->first is true then it would read
soft_rmid_bytes and then immediately reset it? 


Reinette