Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <78f3f6c9-c051-6004-570e-25966b1bc58a@intel.com>
Date:   Thu, 11 May 2023 14:41:13 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.1
Subject: Re: [PATCH v1 9/9] x86/resctrl: Add mount option to enable soft RMID
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>,
        Fenghua Yu <fenghua.yu@intel.com>
CC:     Babu Moger <babu.moger@amd.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Stephane Eranian <eranian@google.com>,
        James Morse <james.morse@arm.com>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
References: <20230421141723.2405942-1-peternewman@google.com>
 <20230421141723.2405942-10-peternewman@google.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230421141723.2405942-10-peternewman@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3pZcWZWSEFhRDhzZnpyNndLYVFBeWRjdUM4UE5Xb3h0cVRCOHZrQkV5eHRC?=
 =?utf-8?B?bTgwN3Q0cHZua0JvbllPQjh0MXZlUmF4NytGUkFITXlMMTkra1hZd3V2eTRi?=
 =?utf-8?B?a3NKZE1kaXJ5Ym5vaWF5UWQxVXdtZFN3T1dBK1k3bDVvYkFoeDc2RXFndGhz?=
 =?utf-8?B?VVRya3JHMFJEVWZhb1BneHFiVHY4dkw1Y05XYVpKVmZ5alBxWnRRMjhBRXpw?=
 =?utf-8?B?TEdkUS9LbVFXMjg3bEtwV3F4L0k4aTlWRitTc1AxOG8ySUxQdStHSmZBY1pE?=
 =?utf-8?B?UFd6U01zbEFLaUJIcXlsR2Nub292VFNicmlOZEo1TkxBSzd3MldWbk9tMWpC?=
 =?utf-8?B?Vmh3a3lnemF5azQvdnkzOElvbElISUkrV0hsbWtncjBjQTJOVEl3VmlCUVlW?=
 =?utf-8?B?amJzeGpNbXJqQkNzZWlmUWJvRHNQb0I0QXhhWWVRNDJNNS9ramlLS2poOTdG?=
 =?utf-8?B?elJ5a25aanNjVU5JZkZ1Z09ub2Q5UU16WkVvbHpqVFdUbXM4b0FTejkzNkt2?=
 =?utf-8?B?M1FrdkNBRzY4eHRET2RRdDdueTZlNS9LWW5HdnZTV2tlbTZvQUR3aTkyVjBD?=
 =?utf-8?B?OHZNM2RxU2hDd1l3Nmh2SXkza1hTdXgyay9zT05vazNJZTlFc1pmY0Q1Vmxm?=
 =?utf-8?B?R3JWdnlZV3dKcmdLL3JBeC91R1YxSFMwaU1vREFsUWdLWXB1SWNWTitaV0pq?=
 =?utf-8?B?aTZsdjFvVEVLL2FVdXh6Mk1ReENOUUVmSUJabnFUSVFNaDBPVmpsRUVPczEy?=
 =?utf-8?B?L2FWajE0UUdrQTAyWXV5dnFrY0Q3WHFZeFJlcU1zQ2NlZzd6dllQbDRIQ0ZZ?=
 =?utf-8?B?N0x2bzlvT0d0eWc3RmJsSjRubmJLRm9YeG1iVEdVVGtLMzlOMkhWbmFXcnZo?=
 =?utf-8?B?UURIeVhXemZPb1RlSG80L3NRU3UrNER4a0Z2V2hHRU4wYkgxcDB5UDVIdENB?=
 =?utf-8?B?dWhiWXRkdy96TWozdVZueGZVMkcyT2N2MnY4M0VlTWxpUFVGYnJLNW9QdVM0?=
 =?utf-8?B?cHJFY0xhYjZsTE5WZFZmNjVENVdSajZ3NWJWeHpNRkV1V2JQN2xkUjJCc2RZ?=
 =?utf-8?B?N1YzTVJURlluUHRKY1U1SWZHRW9sUUU5RUVYSDV1NXZoRUJINDFpNDVDbUpD?=
 =?utf-8?B?YlRHeC9xRC91d21vRGVCaGd5UVpMcVNOVUY2ampKSmlPS0pXWFR4UUREY3JJ?=
 =?utf-8?B?elJUTG9nc1YveG5WaTBmWmMrWE9qQXdhWC9wYVEvMU5YcVFlZjNicnZvbUFs?=
 =?utf-8?B?aWJoWmMyZkNaTndja0lVdE5yakNMT3N5TUhPcThNNnFOL1N1Nmx1SlVGbGFi?=
 =?utf-8?B?WFBpTnFvNU5Pb1JvS3J4Mk5YOGdUdkYvcnhrNEQ2V2JFb3RMZE9YaUpkQmhu?=
 =?utf-8?B?cTY5VGVRcjFxdGZkV2ZrYzZURUtvUFRVT2ZRME9uMzZDTGZiMXovWUhLa09T?=
 =?utf-8?B?ZURtVmRwTmZLek1vbjhSMm9KWldoaDJBUTRSbXp6UUE4Z0c2anJnbmNVTXVN?=
 =?utf-8?B?QmNWcGZlVnBucTV6YUs3ZGlwWFZaNFNpYnBhUlFRQ0dzU0JMY1pjUjBVNDRT?=
 =?utf-8?B?SzJJdTFxTWtwcThxUDlTTmR2YUNOWHJYcm5iWDlkQVkrcndiYWVUbngzK2sx?=
 =?utf-8?B?djVUem93NFpLMVkrOCtuUEd2eFBleDkzQlFaNHBCOEttRmdGY3BjMWkydnVq?=
 =?utf-8?B?TGdvMXRRaHJpWDVJS09kMERDS1FycnFLQTE5ZUtGY3dla05xVGJ2bkVVTzVL?=
 =?utf-8?B?VmJMUUpPamIyT1hhK0NDeHQ4MlVRMzYyOThrVmNOZzNEdE5jc1kvZjJ4ZC95?=
 =?utf-8?B?YzBuL1hzVlpUKytEM2tJcStNQW5oYU1RS3ZjaXpRQmkrUEZFRGlqZjJUdFhM?=
 =?utf-8?B?ZGhWY0gweVIwRFg5QlY2QThMRStqMElIRm1sYjlSMmljQk1wODVQbjNpaVp1?=
 =?utf-8?B?bkFKT3hkT2RaMytaT3Q1cWtsOVpEdmRsNFdLVHQ5NW56VUxoWEtZd1lReSt4?=
 =?utf-8?B?cnkyOXE4U1daSmozQ2dVeHAydFFNUEFSdGVZM2YySjVvU0tlQ2lqUTdLemlo?=
 =?utf-8?B?U1pwRnJWZ2lwSFFVZGl6dUNUQUsyN0VJZDJ2WVFEY0w0Z0pMWlFYclNGc3Ur?=
 =?utf-8?B?YTdlSENPZVA3SVNsRjlGM0JlUlVtYUhibS9tZDgwM2s4S2hubjdpZjVpbysw?=
 =?utf-8?B?RXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 555ffced-b700-42f7-e446-08db526872a8
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2023 21:41:15.8365
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: blYCgiBd37OLhGFn4lSX6/l6guHGhaD7COmDWZIRHGXq+GxQReUUijYKu4t6G0SDiN+9arjwE6c34cX8TPHx1zzXkZjAKihmVNrkMEQRo30=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6109
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 4/21/2023 7:17 AM, Peter Newman wrote:
> Add the 'mbm_soft_rmid' mount option to enable soft RMIDs.
> 
> This requires adding a mechanism for disabling a monitoring event at
> mount time to prevent the llc_occupancy event from being presented to
> the user.
> 
> Signed-off-by: Peter Newman <peternewman@google.com>
> ---
>  arch/x86/kernel/cpu/resctrl/internal.h |  3 ++
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c | 51 ++++++++++++++++++++++++++
>  2 files changed, 54 insertions(+)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index e6ff31a4dbc4..604e3d550601 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -59,6 +59,7 @@ struct rdt_fs_context {
>  	bool				enable_cdpl2;
>  	bool				enable_cdpl3;
>  	bool				enable_mba_mbps;
> +	bool				enable_mbm_soft_rmid;
>  };
>  
>  static inline struct rdt_fs_context *rdt_fc2context(struct fs_context *fc)
> @@ -76,12 +77,14 @@ DECLARE_STATIC_KEY_FALSE(rdt_mon_enable_key);
>   * @evtid:		event id
>   * @name:		name of the event
>   * @configurable:	true if the event is configurable
> + * @enabled:		true if event is disabled
>   * @list:		entry in &rdt_resource->evt_list
>   */
>  struct mon_evt {
>  	enum resctrl_event_id	evtid;
>  	char			*name;
>  	bool			configurable;
> +	bool			disabled;
>  	struct list_head	list;
>  };

Note the description of member named "enabled" of member
named "disabled".


Reinette