Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 16:22:06 -0700
From:   "Darrick J. Wong" <djwong@kernel.org>
To:     renlei1@chinatelecom.cn
Cc:     linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: xfs_nfs_get_inode support zero generation
Message-ID: <20230511232206.GG858799@frogsfrogsfrogs>
References: <1683800241-14488-1-git-send-email-renlei1@chinatelecom.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1683800241-14488-1-git-send-email-renlei1@chinatelecom.cn>
Precedence: bulk

On Thu, May 11, 2023 at 06:17:21PM +0800, renlei1@chinatelecom.cn wrote:
> From: Ren Lei <renlei1@chinatelecom.cn>
> 
> If generation is zero, bypass the verification of generation number
> to avoid stale file error. (Be consistent with other fs, such as
> ext4, fat, jfs, etc.)

What code is affected by the gen==0 handles being rejected?  Is there a
user program or test case where this is required?

--D

> Signed-off-by: Ren Lei<renlei1@chinatelecom.cn>
> ---
>  fs/xfs/xfs_export.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_export.c b/fs/xfs/xfs_export.c
> index 1064c2342876..cbee32c5ad37 100644
> --- a/fs/xfs/xfs_export.c
> +++ b/fs/xfs/xfs_export.c
> @@ -146,7 +146,7 @@ xfs_nfs_get_inode(
>  		return ERR_PTR(error);
>  	}
>  
> -	if (VFS_I(ip)->i_generation != generation) {
> +	if (generation && VFS_I(ip)->i_generation != generation) {
>  		xfs_irele(ip);
>  		return ERR_PTR(-ESTALE);
>  	}
> -- 
> 2.27.0
>