Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp9590142rwr; Thu, 11 May 2023 18:03:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Gq600U/703DuRg/NpbObhIsiRSXv43Md4xJJXuLuC8xDIBvEM8wH9qNdnlEHfmuFOwTqI X-Received: by 2002:a17:902:d484:b0:1ad:7bc5:b9ea with SMTP id c4-20020a170902d48400b001ad7bc5b9eamr9189035plg.60.1683853415221; Thu, 11 May 2023 18:03:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683853415; cv=none; d=google.com; s=arc-20160816; b=IABS725i/qljqKn1SbYVtar2b6YUbVyWKFNd1bdbTyA0tqjluVNEwcx32XYZMpUE6U IZp5xgMbKFtHoS2wjWZ3aI98jDo6jrwgxK9h0TPexIIaSqLlNR4Fz8SBQbfiORnSXYVk Hjw0+VeUMnlGSuXA6bZoEJZhaIeURViQnuTNpNa6m741Cv1LoI9CdBxZcdkm0UnrTmv3 7FoYxa+p5hhPI3HnZ7l/rqKyw6OVB7CNAvZTGOnM+LbC/LQlUAWB6ct2vSDoiGFGQYar 7AP4Mn8ufDoi4nVslv3VK7fgABqACMg08svH64VQDNGIvkGbPJrvBNy7Lv6nSBzZ704h kXYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Y3dxY0ULXsJVc+QLSZyEdcpRPXwJKS/uFcjfHSd3arY=; b=V+PyjfcQVtP9NOcdHGei8E+/82kwomc+nlmXzLyOsQPS+V2Bv2tBSDZYHqmb5x4Vno joTOv3nJk6BF0z+fJYQWBhyTADVOvuU/uKRHZiTlAsMYAABWbcwxi+T2G+wnpZIVJqQ9 t+kUuiuEd2vDpuJJKR8bkTfmtmc/h5Da6CoSy/wJHe7VOLWud3zakJr0GtizTq9wBpUJ wDh0FEDhpe8X1usrqrPOtRBU9VpOr/QHGN6FlppENnHtzkGFHbj5T8guO7IZjw5HutEh NGCtbdfvFuJr0UB/RVcbKVEzS9nQa/ILJRJCb533UQNVn0V1lsdImxwUmQE8sUBXtlFE zYTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="P/t7XsQE"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j4-20020a170902da8400b001a94f85b0besi8702613plx.406.2023.05.11.18.03.22; Thu, 11 May 2023 18:03:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="P/t7XsQE"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239603AbjELAzq (ORCPT + 99 others); Thu, 11 May 2023 20:55:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229654AbjELAzp (ORCPT ); Thu, 11 May 2023 20:55:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 142714C1F for ; Thu, 11 May 2023 17:55:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE99560FBA for ; Fri, 12 May 2023 00:55:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5497BC433EF; Fri, 12 May 2023 00:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683852944; bh=hqORGTuFn34NPCgboOJIrkMoupu4sFw407EbC5EaQvE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P/t7XsQE6C2iwFL92q8S3BwoVjW/bpJnxJCbKUDm2psz+EnRaR4ottamzangYgV/4 aPJ4t+q4Fcn1Yy14q0EIgVFR+oUi29GoGRi+1kyV6wtOwZjSzKLjFXUy4kqnvfjc/S QTfSBbRnB+gURKB2jYfLk89h/Qo2IezfOeoR+BGFOaG8/mjUR/42cJQKVTPycgM9QN i7FfiTcCPg78v4jt4jkEJQt4Hwg0v7qzXTOSVsv54dta73VaWjTrCEAcsWoWpzMhcg 6D3fsoADyRMYrNTrsmGyBvoYCMHDT0i9ts5+8x45oy60fJfv/PVG818ZTuVBy0x6nM CiGcHh+cRj/6A== Date: Thu, 11 May 2023 17:55:42 -0700 From: Jakub Kicinski To: Shenwei Wang Cc: Wei Fang , "David S. Miller" , Eric Dumazet , Paolo Abeni , Clark Wang , NXP Linux Team , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Alexander Lobakin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v2 net 1/1] net: fec: using the standard return codes when xdp xmit errors Message-ID: <20230511175542.0bf5b773@kernel.org> In-Reply-To: <20230510200523.1352951-1-shenwei.wang@nxp.com> References: <20230510200523.1352951-1-shenwei.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 May 2023 15:05:23 -0500 Shenwei Wang wrote: > - xdp_return_frame(frame); This line is a bug fix (double free). I'm going to apply v2, it's good enough.