Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp9607550rwr; Thu, 11 May 2023 18:22:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4adkn1lbt0nHd+uSIZCDcHiMbF9U6lq1YEK643qeXPP6H1rGw93XnKKqdOMb4C6pqwqEpq X-Received: by 2002:a17:90a:8a05:b0:24d:ebf8:b228 with SMTP id w5-20020a17090a8a0500b0024debf8b228mr21857991pjn.19.1683854577401; Thu, 11 May 2023 18:22:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683854577; cv=none; d=google.com; s=arc-20160816; b=soUx5BkCpVWVnv/d7znmIEyWEBxbmXxUy66bBRoRd/Zb3S2DLN8pIHmw81NvOT/OnZ oh01HP+lNMLyaiWiOP+vw69865RaUP9L9q7RxspMUYmNLmDpLlnxZ9vdKMoavTI8gcbB yDkrMjonHAkhKDQYOMlQEEVU+03Ga80p7OzalG9uPoFjmkDYPXp6YoalmO7R3/VVnO3O KkNgXcDVrh6GGfCf4N/b+fpb/TArtIGUUIOYBkfq4TAoES+zKgvYJJr4BMBx616o1S+h MhLQhRdGlDMdo06FleyAV00EfaHF/T/9ZsfX6So91ecrrgqm4QyWpVRKUvnxB7q0/vUw 7zZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=7FidZPL6/JjR3aTG0/yt8Rh22XZmVz74jmu+VOu18Y8=; b=zmMefWcyhGQQ6KEn7zBCmT2B8If1sLVdZP4jt5+kq5Ovz6mFEQXFY+Q12Eq6DhInXm xonBIQfbPEcBfAgi2QltgwKdHSLi7v/zbgNCFDDv9VitqUTHMuuoYcHha3ok/ynruiAT Fq77RqALuOgVLUxSjL9vRach1QKyaJfG+HVbZu5GuJwX0R6WkFQHdEvDOHAMgPHvDZqW i8RiZEXMz7BtvEbIRs/M63lPtHnlnohvBbwjpNH3W0JE1D8KtXIB/3tYAh/ys+CX7jp8 THYY3SP/62oF/vj1oGlaqnD4HYaqA3nbY9e12ph6vcZ290KpI2tCw3giDJe12fAZVF7Q 44uA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Bjf5oJYI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f16-20020a63f110000000b0051b930b2b4esi8460036pgi.620.2023.05.11.18.22.42; Thu, 11 May 2023 18:22:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Bjf5oJYI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239663AbjELBAN (ORCPT + 99 others); Thu, 11 May 2023 21:00:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239544AbjELBAM (ORCPT ); Thu, 11 May 2023 21:00:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D7EBCE for ; Thu, 11 May 2023 18:00:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E63C6108A for ; Fri, 12 May 2023 01:00:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4773C433EF; Fri, 12 May 2023 01:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683853210; bh=7FidZPL6/JjR3aTG0/yt8Rh22XZmVz74jmu+VOu18Y8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Bjf5oJYI8oN3E17VPraPX2agydE7OjsCS3FUzf65OoQ5iXw2Cm4PcTV9Y9/e+uqet Q+t0DzA5XTqAJD2zLFzWthP2Swto6kSV2zdkywDU+XTiYr70v5jnAq5yFzn8XduN0E KD0caRgfYN/zIj4UQkUJauhosv1gtGdLPKVBqPt8qilVNDXxSSUSjHPu+Bv8xzgkA/ qMoan7ub0mpsIVWgZy1yfX1L1ZKVcwvMRRO/GIsdx/aEH7qdrQLAHTFHM/icwrUz6D K3dn2+9VLe/01/EjfQElNp9YcnjZfBa0CpvFiMhWgOHnyenYfeZdICIP1SvDT44tby w2pLvpsTTnO0Q== Date: Thu, 11 May 2023 18:00:08 -0700 From: Jakub Kicinski To: Shenwei Wang Cc: Wei Fang , "David S. Miller" , Eric Dumazet , Paolo Abeni , Clark Wang , NXP Linux Team , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Alexander Lobakin , Horatiu Vultur , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v3 net-next] net: fec: using the standard return codes when xdp xmit errors Message-ID: <20230511180008.0a216e0b@kernel.org> In-Reply-To: <20230511152115.1355010-1-shenwei.wang@nxp.com> References: <20230511152115.1355010-1-shenwei.wang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 May 2023 10:21:15 -0500 Shenwei Wang wrote: > This patch standardizes the inconsistent return values for unsuccessful > XDP transmits by using standardized error codes (-EBUSY or -ENOMEM). Let's split the return code cleanup from the double free fix. Please post a v4 patch with just the xdp_return_frame() removed, and none of the other changes. For net (rather than net-next), with the Fixes tag back.