Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp9629480rwr; Thu, 11 May 2023 18:50:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4LwA2bf96t6v9OrQ90PGt687VJ0MVR8jXr5CkUY/txjFTm8iMgk/G7F6p7DROBTVKgFCXF X-Received: by 2002:a05:6a20:54a2:b0:100:8592:9a7f with SMTP id i34-20020a056a2054a200b0010085929a7fmr21591663pzk.45.1683856251889; Thu, 11 May 2023 18:50:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683856251; cv=none; d=google.com; s=arc-20160816; b=bwfugAH1qO8ElDsnHO45WeR7PJkWgvJTntbDFGl6KuKlZnGvJ8mvrych2xx0TdSxXd 5yi1avEX9aYKVVO9kYkZy3REOJplEl56QM8fYU6tuHCdZcHm4WYPWVC1csjUbArfCEGI rTRypWcBLRGxzDbESHifQjGSrg4trMc8bE4v051bUWeDVCLRf8EOpKS5Lzge63C62HHW bfK4aQrfkWWpbJb0Ow/4Q95aQHGxweQypzhvg4GtMAwwD/OWMihmmLcoFQjER+J8H8p5 IqKQyP7lp19C79pzLktsj5Ujt5KrpjT1VRwEybfNqFY66i8+SSlD/Oqo2iLswF0mjqPE V4RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=SCyoiyETjbR2Gy1/Q+DZmv1+/D0Q8RRI7wExIc4hVqo=; b=DSuiskzX+Ysbr4jOF0PYCInTE+swfKTgEOVMP1qCLDbON5yuV/cUvgXGJEmcsP65LF G7j/+Q57fyEeGooVmW6cZOtJv62Vhvjlzf5rrS4LFq3aL0ds9pcgi71qTFuULhoLwimA 8moXrgVIDQg34l26feABfz6TLTuK7tIZKr8VRBO3WAxJNJGpsj462BjHjOak6Leqd0cy HbNREsto8srVnU+5akNuzmmq1uZgls74NlgQff1mna+vhjQRoNMGDB3992yM5zrPqEnF Ne8kvJLSKbA5aE6K/hMXF7FnNYQ17XXgVuk5ur3+Q90e6YiKkAUlYOEio7WjAEFgbv6/ cbdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pBrwLga7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k187-20020a633dc4000000b0050e7254402esi3545681pga.208.2023.05.11.18.50.40; Thu, 11 May 2023 18:50:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pBrwLga7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239685AbjELBGN (ORCPT + 99 others); Thu, 11 May 2023 21:06:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239656AbjELBGM (ORCPT ); Thu, 11 May 2023 21:06:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4671465A0 for ; Thu, 11 May 2023 18:06:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D67A86135A for ; Fri, 12 May 2023 01:06:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A27BCC433D2; Fri, 12 May 2023 01:06:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683853570; bh=O2xWsXKa4DjDdRZtiAgJqkrBYrAeY725PaQRhhhgrEQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pBrwLga7/TezsQ1Kh7o15ipSWuuCVFFIHPkIkomN4nRFP0Wxljj/vefQ32eDNjIJq rpQ/eJoZ/LRvVBiOWMj6ZuEq0xoTzt0enapdJ7QNjA6PC5sAOpvQ2TqIAxjKxJZugX r/AZvRyw4bcHXmSFA6+Yc88DAq30831M1neh3OhcpHsMofQczURhSqI5mHlMbslRAQ vIgiC9wweJ+8Y1lZkhtoGmOuOnTValycTxHzZrHlqrCTAGwTQ6M/Eq0sZ01yxBCZOe cSpOHkWWAiFjaIxsWrHvfIZ2WT7Q/SnHFJ52/ZwRgpMf7apNU/D6AI6IOdaQ1VCGVq ToPHUTgvERRKQ== Date: Thu, 11 May 2023 18:06:08 -0700 From: Jakub Kicinski To: Lorenz Brun Cc: Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 net-next] net: ethernet: mtk_eth_soc: log clock enable errors Message-ID: <20230511180608.6e1f6620@kernel.org> In-Reply-To: <20230510181350.3743141-1-lorenz@brun.one> References: <20230510181350.3743141-1-lorenz@brun.one> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 May 2023 20:13:50 +0200 Lorenz Brun wrote: > for (clk = 0; clk < MTK_CLK_MAX ; clk++) { > ret = clk_prepare_enable(eth->clks[clk]); > - if (ret) > + if (ret) { > + dev_err(eth->dev, "enabling clock %s failed with error %d\n", > + mtk_clks_source_name[clk], ret); > goto err_disable_clks; > + } dev_err_probe() would be even better, I think? -- pw-bot: cr