Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp9629889rwr; Thu, 11 May 2023 18:51:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6hYzgln2v+KNp78L+LcGkivQapwvGMCOMf0nKBaBz8fS3Ujy2fnLmfrP2hlVlhM5rhpmxr X-Received: by 2002:a05:6a20:734f:b0:104:c2c:52ed with SMTP id v15-20020a056a20734f00b001040c2c52edmr4428380pzc.34.1683856285503; Thu, 11 May 2023 18:51:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683856285; cv=none; d=google.com; s=arc-20160816; b=HBNvwfm6NOuZjr0jimkoBRexIOnIy6xEab4AukwiQsVZQUcdETkrGsVmPU/7A6YIVX 4aAF/w6r4wbgnXvrrZiEBWrlQsIptJN865k4MDtwdbdOvZmfyUnOzfcTzhgaJb7LrNsU b0kfV6wub/2/ghdIwpI9yfRuYNratY8X2BE3xXGwwjMWTchhz9MtuN9TNHhDpoDE4E0g xFhbtmHPBx6xZ5UrDsKLIm36xuqLPVWSpG1yD4nD0v7yPL2gUDshlkj5swDAfj4dnPTI 8yC+NX9eyXRLVcUuVmMXYmyJ5SVEatqKrfbqvQOLaM0zA3nnCtKUWrm0+rmKh8bP8Krp VD6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ywx9G+DrKBvZRDFtOGT4ISz+VQ5aSq/WPKktriGbW+8=; b=JD5pH17+5KOkF1AMP4POfDp/zbnL2R/tU3djiwQhTvybxqmZeDcetiefkb/B3kG7LL C5ZBdS7UgBITC+C3+AeWtJ1r0itfiv+eafS9BL2qsjKj9fgnr553N5y+UO/BdjyYWdwu HYTGLy+jXkE2AlkZmVFDXZS23wUTQok1Oftlee8PlUlSRtwjo5mFQYlwMJlOo/YvRgKO qYdEcPUx8f6gaT4C+72RYW6dxmsFEp6eMvmjIL3zVcAvdWZcpbqul6xQTEK8UWYdBNMT tTimd0dQRDRKADpZ4kkiP/GCmKpMMNFpDMqITdANjmJG7kO5fLdpqzslEZldwLhXRYnv fvgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ap1p4ygC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z26-20020aa7991a000000b0063b235abe2fsi9076902pff.64.2023.05.11.18.51.14; Thu, 11 May 2023 18:51:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ap1p4ygC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239658AbjELA6i (ORCPT + 99 others); Thu, 11 May 2023 20:58:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239561AbjELA6T (ORCPT ); Thu, 11 May 2023 20:58:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43B127EF5 for ; Thu, 11 May 2023 17:58:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F08C6132F for ; Fri, 12 May 2023 00:58:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5282CC433D2; Fri, 12 May 2023 00:58:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683853087; bh=Na7tNUvEVf6ByVUC4k87U3onJNIuQV7IWaT3nOoxrPA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ap1p4ygC9tf7kD886uOAEwUgJVinAxtgj6i8xx+YbFmZllbUDXazxNaM5rPdydFTo 9qtNJO5RVcIybs+Z13CIck/ETTTsOxKoNh5mFhGFOd2c7tLmfip5Yv6mAWDn3NLJt3 14ddehiK2OMAn5laRsPWu4WfW7FUi6naMMhvSNX4dk5/taJV5qHjhhtZT195R2msb8 v4LHG/1cdnfeOppwShDTLotMgoLA4s3fYTuAOSLZ3FciDrogG8D9T96NsyHyX7hEqb Sb16m7V/SXK81T7BuyOl+IgfLiNBBSEJDiaDnc8mNtBzMA3BUs4yXLofvdfWsMGu2I l85908kduF9pg== Date: Thu, 11 May 2023 17:58:06 -0700 From: Jakub Kicinski To: Shenwei Wang Cc: Wei Fang , "David S. Miller" , Eric Dumazet , Paolo Abeni , Clark Wang , NXP Linux Team , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Alexander Lobakin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: Re: [PATCH v2 net 1/1] net: fec: using the standard return codes when xdp xmit errors Message-ID: <20230511175806.4b1f84f6@kernel.org> In-Reply-To: <20230511175542.0bf5b773@kernel.org> References: <20230510200523.1352951-1-shenwei.wang@nxp.com> <20230511175542.0bf5b773@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 May 2023 17:55:42 -0700 Jakub Kicinski wrote: > On Wed, 10 May 2023 15:05:23 -0500 Shenwei Wang wrote: > > - xdp_return_frame(frame); > > This line is a bug fix (double free). > > I'm going to apply v2, it's good enough. Let me take that back, I'll reply to v2.