Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 12 May 2023 12:30:29 +0900
From:   Mark Brown <broonie@kernel.org>
To:     Boerge Struempfel <boerge.struempfel@gmail.com>
Cc:     bstruempfel@ultratronik.de, andy.shevchenko@gmail.com,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] spi: dt-bindings: Introduce spi-mosi-idle-low flag
Message-ID: <ZF2y1YNkSbXzRm4V@finisterre.sirena.org.uk>
References: <20230511135632.78344-1-bstruempfel@ultratronik.de>
 <20230511231317.158214-1-bstruempfel@ultratronik.de>
 <20230511231317.158214-2-bstruempfel@ultratronik.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="crcVxhkxf83g7XbZ"
Content-Disposition: inline
In-Reply-To: <20230511231317.158214-2-bstruempfel@ultratronik.de>
Precedence: bulk


--crcVxhkxf83g7XbZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 12, 2023 at 01:13:14AM +0200, Boerge Struempfel wrote:
> Some spi controller switch the mosi line to high, whenever they are
> idle. This may not be desired in all use cases. For example neopixel
> leds can get confused and flicker due to misinterpreting the idle state.
> Therefore, we introduce a new spi-mode bit, with which the idle behaviour
> can be overwritten on a per device basis.
>=20
> Signed-off-by: Boerge Struempfel <bstruempfel@ultratronik.de>
> ---
>  .../devicetree/bindings/spi/spi-peripheral-props.yaml       | 6 ++++++

If this is always required for a given device (which I'd expect to be
the case) why configure it through DT?  I know we've got some legacy
stuff like that but not all legacy DT choices were good and no need to
continue the pattern.

--crcVxhkxf83g7XbZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRdssoACgkQJNaLcl1U
h9C1fAf+OxB7rCOtlPof7FqZqSfBXMUMxSO9PukmbYkdxUV/iKlWoo+TI2D946t/
buUcDGkK2j+ubWF0uwQUuLyCbzsL4O2oRnKi5CJgEZeiCkRAhbddWFSYLCyEaKNq
fp1MiV5/2bdtfD/WIz0CvQD4YIB7mSNj1o1U7/+K8BD9a2oACXnmlW1p2sFafi5a
AOtv1AssMLY8nxnUZD68d7CKqVxRdFpR0NGhhdmOqViDY/Vwt3Hig/zgbegBTHWh
CAsMZz8WWmRXq2dIJIjHOd5QKloNlSsCgtlEQFMX/35ZCXTRKLlimYwBN1wUtaN4
XWLyuvm5QH8uHDoseqY+1dteVb0Csg==
=Cu0M
-----END PGP SIGNATURE-----

--crcVxhkxf83g7XbZ--