Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp9724113rwr; Thu, 11 May 2023 20:55:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ72rnzITke679+q7kIryfSE552OYc2Xw6EiaGHxKhMvmp2tlp835GRJMMcNQXF2ZVWwRe5p X-Received: by 2002:a17:90b:1bc1:b0:24e:2248:31c with SMTP id oa1-20020a17090b1bc100b0024e2248031cmr23811169pjb.22.1683863704742; Thu, 11 May 2023 20:55:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683863704; cv=none; d=google.com; s=arc-20160816; b=YAplwjYYuQ7KHMbywzSnvClo/SgAv5tkzLdcAXJMfL9A2AYPm4OlaOnF8u0hb05bw6 HJ43EL5FqEcmG74ViMRja0YoIJzm9VlPdy1hFxa0azrfIIYAbEJdLWVymDzD7QPF5JFt bidJpDeA+tmy46puKfQ0jSgt901W5jrrwfNerxaCDbdZCHq3MFA0mfNK9QkJ6QYN0vhE tzkRCefs0f7AeR8i7wDfKHPxGAjXckN+6+5BJeEx/pTtU19rHoPRUN8bv2U7FYdv+C4E ny1gfGPxLhf/xBoaz5tO3hmxUUjK1XmwBM4c8t3mxKQ0T1KNLoxG6mNNol+ncDMTqYaY 9vww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=GHwWm07TJl57/VvMnXhiMR8VTzvMJogNYkCzwB6imVw=; b=wLWi/bp+P2GlQR65eEX+wxiox+2jMkpSnueSwMfqiaRtdIkchIs2MqfsZ5JK6VQ47W aMCx5ZbUmW1D0D95u/toqu+2eU89KOo75ys521Re7wqLMKKXCQDIlHgHTVL0zBwI1J0Z A/e9rY/JPTlJXvhI1Pj5S8w0t0dT7qQPH3MD/I6hAbizU2lyFEcMPhDc8OAT80OrnmYE GFOpVXbRLDSv8dGPvUBTUwzywLXnFzj2YEr7IlvmnRQKbnwnRDrEtAqroFIK6atg7Do2 AZHrThu0+ruxN9cWAHOgKCYtw/YhHTRTO+HKaCjnCBnfS43z77kgPQ77V9KQWrWYlksE 5+MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=xKEZx2tz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a28-20020a637f1c000000b0052c40a97d9asi8321885pgd.283.2023.05.11.20.54.52; Thu, 11 May 2023 20:55:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=xKEZx2tz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239625AbjELDp2 (ORCPT + 99 others); Thu, 11 May 2023 23:45:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239887AbjELDpW (ORCPT ); Thu, 11 May 2023 23:45:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A0DF559F for ; Thu, 11 May 2023 20:45:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CBF5C64EA6 for ; Fri, 12 May 2023 03:45:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CDC8C433D2; Fri, 12 May 2023 03:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1683863119; bh=LwXFBCIUn0qm0zeQk1M2Kj8pN5JJyhizS0k2YqjjrOI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xKEZx2tzEI51buUGGzKH5QJ7PBGdG992TJmfpaxnYgMAMzaZ3FpNcs3PZkXbqm4M/ /HR/cZNsnu3ldz5pcncGMlOV6OuZK72I3TEDHWbROxv+jS+IOJjGjpZewksm/bxplS uIwzeTnp9fq09Q5OQzXCY0N+Q+TPmqnc9Ank+EaE= Date: Thu, 11 May 2023 20:45:18 -0700 From: Andrew Morton To: Heiko Carstens Cc: Ilya Leoshkevich , Al Viro , linux-kernel@vger.kernel.org, Vasily Gorbik , Alexander Gordeev Subject: Re: [PATCH 0/2] statfs: Enforce statfs[64] structure intialization Message-Id: <20230511204518.eba10b4cbf9568a24d1d428b@linux-foundation.org> In-Reply-To: References: <20230504144021.808932-1-iii@linux.ibm.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 May 2023 16:35:15 +0200 Heiko Carstens wrote: > On Thu, May 04, 2023 at 04:40:19PM +0200, Ilya Leoshkevich wrote: > > This series fixes copying of uninitialized memory to userspace by > > do_statfs_native() and do_statfs64() on s390. > > > > Patch 1 fixes the problem by making the code similar to > > put_compat_statfs() and put_compat_statfs64(). > > > > Patch 2 gets rid of the padding which caused the issue; even though it > > may be considered redundant, it documents that s390 de-facto has an > > extra f_spare array element. > > > > Ilya Leoshkevich (2): > > statfs: Enforce statfs[64] structure intialization > > s390/uapi: Cover statfs padding by growing f_spare > > > > arch/s390/include/asm/compat.h | 2 +- > > arch/s390/include/uapi/asm/statfs.h | 4 ++-- > > fs/statfs.c | 4 ++-- > > 3 files changed, 5 insertions(+), 5 deletions(-) > > Al, Andrew, should this go via the s390 tree? I'd say so.