Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 12 May 2023 13:18:19 +0900
From:   Mark Brown <broonie@kernel.org>
To:     Ye Xiang <xiang.ye@intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Marc Zyngier <maz@kernel.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, linux-usb@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org,
        srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com,
        andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com,
        zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com
Subject: Re: [PATCH v8 6/6] spi: Add support for Intel LJCA USB SPI driver
Message-ID: <ZF2+C0CqaBff2hl+@finisterre.sirena.org.uk>
References: <20230511175844.185070-1-xiang.ye@intel.com>
 <20230511175844.185070-7-xiang.ye@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="iDLgAwJ74STo+Yb8"
Content-Disposition: inline
In-Reply-To: <20230511175844.185070-7-xiang.ye@intel.com>
Precedence: bulk


--iDLgAwJ74STo+Yb8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 12, 2023 at 01:58:44AM +0800, Ye Xiang wrote:

> +++ b/drivers/spi/spi-ljca.c
> @@ -0,0 +1,290 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Intel La Jolla Cove Adapter USB-SPI driver

Please make the entire comment a C++ one so things look more
intentional.

> +struct spi_init_packet {
> +	u8 index;
> +	u8 speed;
> +	u8 mode;
> +} __packed;
> +
> +struct spi_xfer_packet {

These should be namespaced, especially since they look likely to collide
with other things.  Otherwise this looks fine.

--iDLgAwJ74STo+Yb8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRdvgoACgkQJNaLcl1U
h9DNXgf9H7gFOZGlxttpn5v/IJdK948NNyKBgpz2AkJQVHOk848wbYpxrFsuWD5D
1KYc0NYmt4CkyGz3JDwQbJy6Ipo3A38uzzn2OGphxlE35SVsoMgI4htCJ9X3gnU/
wi9SPTlKbv3IH14IaMKyiyTWgmpobEV8lQ7VOXJPtwBwzGOQ8xPi3nbvCeGfkDFV
/UPuODRaIBbBbABVC6pibA+GklJGO+i1q2cPGydqEk8gP2OaUbdWG8tpm7Bv2lQG
ziu6dzm5UaDiIR+KAtbBILrdFvXInL0f14wK0xRgmHv9nYsMfxG69AXv2GsMI3iP
OnTTtJ664+d3gz3fk27WKjuay0OZ+g==
=G2/K
-----END PGP SIGNATURE-----

--iDLgAwJ74STo+Yb8--