Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 12 May 2023 10:11:41 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>, Marek Vasut <marex@denx.de>,
        Fabio Estevam <festevam@denx.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        "open list:CPU FREQUENCY SCALING FRAMEWORK" 
        <linux-pm@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: imx6q: Disable only available frequencies
Message-ID: <20230512044141.n3l6l75cfal7i26d@vireshk-i7>
References: <20230511092334.3017-1-cniedermaier@dh-electronics.com>
 <20230511095355.5t7ldsyg5eglrrtv@vireshk-i7>
 <a7bfc85a9b664daf84e90adf520c0a56@dh-electronics.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a7bfc85a9b664daf84e90adf520c0a56@dh-electronics.com>
Precedence: bulk

On 11-05-23, 14:38, Christoph Niedermaier wrote:
> -	if (val < OCOTP_CFG3_SPEED_996MHZ)
> -		if (dev_pm_opp_disable(dev, 996000000))
> +	if (val < OCOTP_CFG3_SPEED_996MHZ) {
> +		ret_opp = dev_pm_opp_disable(dev, 996000000);
> +		if (ret_opp < 0 && ret_opp != -ENODEV)
>  			dev_warn(dev, "failed to disable 996MHz OPP\n");
> +	}
> 
> If that's OK, I can do a version 2 with it.

Looks okay to me.

-- 
viresh