Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 May 2023 22:56:01 -0700
From:   Mike Rapoport <rppt@kernel.org>
To:     Rick Wertenbroek <rick.wertenbroek@gmail.com>
Cc:     rick.wertenbroek@heig-vd.ch, David Hildenbrand <david@redhat.com>,
        Oscar Salvador <osalvador@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memory_hotplug: Fix format string in warnings
Message-ID: <20230512055601.GG4135@kernel.org>
References: <20230510090758.3537242-1-rick.wertenbroek@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230510090758.3537242-1-rick.wertenbroek@gmail.com>
Precedence: bulk

On Wed, May 10, 2023 at 11:07:57AM +0200, Rick Wertenbroek wrote:
> The format string in __add_pages and __remove_pages has a typo
> and prints e.g., "Misaligned __add_pages start: 0xfc605 end: #fc609"
> instead of "Misaligned __add_pages start: 0xfc605 end: 0xfc609"
> Fix "#%lx" => "%#lx"
> 
> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>

Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>

> ---
>  mm/memory_hotplug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 8e0fa209d533..9061ac69b1b6 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -325,7 +325,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
>  	}
>  
>  	if (check_pfn_span(pfn, nr_pages)) {
> -		WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1);
> +		WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1);
>  		return -EINVAL;
>  	}
>  
> @@ -525,7 +525,7 @@ void __remove_pages(unsigned long pfn, unsigned long nr_pages,
>  	map_offset = vmem_altmap_offset(altmap);
>  
>  	if (check_pfn_span(pfn, nr_pages)) {
> -		WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1);
> +		WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1);
>  		return;
>  	}
>  
> -- 
> 2.25.1
> 
> 

-- 
Sincerely yours,
Mike.