Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp9942497rwr; Fri, 12 May 2023 01:14:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ZUMLINQJi780jHlOh6pf7Zm3VQmDBzM02Qk+de0vO715O/ppDD2ppSG+pV5kLJBg/pAYJ X-Received: by 2002:a17:90a:d24f:b0:24e:4a1a:39a4 with SMTP id o15-20020a17090ad24f00b0024e4a1a39a4mr24801793pjw.17.1683879262256; Fri, 12 May 2023 01:14:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683879262; cv=none; d=google.com; s=arc-20160816; b=HICDyOGlZXVzL8XHMrLCyWyZ/2as7IHKKmiEO44PXuExiaP4/3joJe9Js0ucIDsMEs LhyciRbIcAHjZPVX644QSGf/BtWhC5/rBEpLejgn2S1UYX96eJYWR5kgYyVOB0IXdka+ 0ygRQ+6XRmU6bqtjZ5OWqFAszp/ku7rNFw4PfW9htwUcLZnPta3p2p88WIhcsNzyGI01 F1qSnJsIBK8eRAb2WLnQfNftysM8XJTaFxsdasy4mCFNfHMmCnnaBkBOiRmiDoirP3ve iYtMflXXtHbINv4uA8tqMNXmUyCRNBH7Bsb0NwfkVE6Gm/OSAmCzAjY9XGwhZiRPuzVq Gp4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=9z3t3j1vSgUk/zW5GyRVtwm3YtXLJA1vQYYbGQ+ChGI=; b=kwoaotwudaT+YwOlK8OLuBPVXONVWxnWr+3asvf5ILwzTMQOFQPHvq1FfG5qSJUDct TylD7qIfyQ54zvDFmcp9RPeOfSTxqzlEcpwFwk4k/Au2NxxV12+twUopRL9FVgeBBArW 7G2k0A5P13PuG09u/I4eOBQmkYMuk+Ge0o7io06fOHCAa0jXiROZyyjxEhbMEDF7dLZG tZZ3gOoA3rHboZetLTK7GFMEEAoyLhcBmQVPwpKLcyFxaaPtndOgy8haTWjq5zQGaYBx bUhTN/NS6o7tAiqVcySBlkvrGm9J4vHocXIafJxW+yoWZ0X8rseqYay2OJrff+FDfGKW FHQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OnJNS9oN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z10-20020a17090acb0a00b0025287b1f177si3995496pjt.9.2023.05.12.01.14.08; Fri, 12 May 2023 01:14:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OnJNS9oN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240315AbjELIAn (ORCPT + 99 others); Fri, 12 May 2023 04:00:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240192AbjELIAa (ORCPT ); Fri, 12 May 2023 04:00:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE3D810A17 for ; Fri, 12 May 2023 01:00:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3E672653CD for ; Fri, 12 May 2023 08:00:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 9C736C433A4; Fri, 12 May 2023 08:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683878423; bh=h1PIBDDkN9KYnWVwY4ASDt+IVOga5TEjRfO84XcCOH4=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=OnJNS9oN8Dkrt7nSKwcADAtlseKmjllGV4YxFjyvpXr4fBqMomxIPXb3j27x5XCvM gL2Pk5OjOW4fLFYrbUvh1QsnWa56Oj8Bcg5r1Y/nTej/RMXbnJrWol74PcbL5m8CTZ drFWOqHaDDtYjD8rwl1UJq6uTCW/GShHsdhH6FE6WbkIiAMWbJPvtYfVN3istIJL9H A/XfLCfonXsrNM4eXolMNVLYtWvqvofGQFFuey7NU6e4IFJWwq8WwK16H18mbNozft K8JVPW1snnCKDQ0RNpJ0VItXwAymqIfynxsmfFThbeOF6qgOenYxpQXKQHCf8GXaCR XUKkesUtvjyDw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 89CF8E26D2A; Fri, 12 May 2023 08:00:23 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] ipvlan: Remove NULL check before dev_{put, hold} From: patchwork-bot+netdevbpf@kernel.org Message-Id: <168387842356.16770.3411961008492273688.git-patchwork-notify@kernel.org> Date: Fri, 12 May 2023 08:00:23 +0000 References: <20230511072119.72536-1-yang.lee@linux.alibaba.com> In-Reply-To: <20230511072119.72536-1-yang.lee@linux.alibaba.com> To: Yang Li Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, abaci@linux.alibaba.com X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Thu, 11 May 2023 15:21:19 +0800 you wrote: > The call netdev_{put, hold} of dev_{put, hold} will check NULL, > so there is no need to check before using dev_{put, hold}, > remove it to silence the warning: > > ./drivers/net/ipvlan/ipvlan_core.c:559:3-11: WARNING: NULL check before dev_{put, hold} functions is not needed. > > Reported-by: Abaci Robot > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4930 > Signed-off-by: Yang Li > > [...] Here is the summary with links: - ipvlan: Remove NULL check before dev_{put, hold} https://git.kernel.org/netdev/net-next/c/0fae8847563b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html