Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp10007483rwr; Fri, 12 May 2023 02:23:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7DBhMC6P4D9UPb+YFmJ8Em/88Z+QFi3fbemsJBVp8RW4NGKDid0+3j87fTQQfL5Ws83E1S X-Received: by 2002:a17:903:48e:b0:1a2:a904:c438 with SMTP id jj14-20020a170903048e00b001a2a904c438mr24024956plb.58.1683883408052; Fri, 12 May 2023 02:23:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683883408; cv=none; d=google.com; s=arc-20160816; b=ybahTwBeT2uiprQsy3pwlNA8gmADs7AS0TDVvzZ0eTqn/1whIkT6R5qGTjYbmzi8wK 3L61MJyy7I9Mdhw7X8LgGF7g1cByE4UaMvALT32WJRUTuO0jzSH0j6tvV/5wCHgwFUH6 3pKdesYUh2rr1QaFZn8q9VIAXvT0ReTVSwOsn36K8w6hrJkrbMiytoJe07kw3heZizXb D9kiakwcYu0f4VKujya3idMIgxDdRhH/QSbtqMlqNv5GBHStUnCnnuHci9AvNOOExi2T +6NpiG+jq5QIfo3yLYDwNI4NfGheCnfDMq1LgFC1rV9dZgFbmQagxwd9CGA2tLkMVBYm CKNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=nkXPQqGAfq9bUrbOXmFI4RRGeSUmWiNVqtOYiJD2pBM=; b=SewkzgkqfyKMQqFi8V3reaolXQnctq4DGlVLK7kQtmuhFFsYC9H3f/AbvZ8LyZPybz EjVizYNjjlXy6dZac9uAQUi3u2v5+u3Pg1HmLMwy1+/nwKSkQxgjruyQW9beTJRzrDjD gl0HqEeqtyQiMHJ1oJpDmbiYNVFU1jTTNWurPnifC3sh+BVhR4vnHpzAu+IMZY/IZHR+ xJhfYMGY6ctRh7boJvm2DwLP5jsIUGhouWraRYp6O++/hSHqF0ohThoz05AH3UOYbn7p 5UO7lyXRIlIiGsDNbCkm3I4jc3jJz2PvXFz/5/ML/9fMc+gZAaRHNAI0Gd/TtYMmROdS h0PA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=kt4q7hr3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n13-20020a170903110d00b001ab0acfc1edsi9436157plh.262.2023.05.12.02.23.12; Fri, 12 May 2023 02:23:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=kt4q7hr3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240057AbjELJQG (ORCPT + 99 others); Fri, 12 May 2023 05:16:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231767AbjELJQF (ORCPT ); Fri, 12 May 2023 05:16:05 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 706412721 for ; Fri, 12 May 2023 02:16:04 -0700 (PDT) Received: from [192.168.88.20] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3361B2D8; Fri, 12 May 2023 11:15:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1683882953; bh=8aj3gkZp6VDWp4PUGeLKxpnkIoSmqes4md/485PvAn0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kt4q7hr3Votllg0InPdSLsBr00s8bqAP8YwqlaiSKPbOK6Nq1YZimlPDhBZNEfaQi 65CpfaNHB3EfNCVxUtuDRdf3bAw1NIat7ki1GqsCWFeViCjKah0YkmwzmgHc3kqVsl y0U9QyscePQ28eNJZOqoijXNK+pgB6Iu4TjW7kp0= Message-ID: Date: Fri, 12 May 2023 12:15:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation Content-Language: en-US To: Aradhya Bhatia , Jyri Sarha , David Airlie , Daniel Vetter , Laurent Pinchart , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Rahul T R , Swapnil Jakhade , Boris Brezillon , Francesco Dolcini Cc: DRI Development List , Linux Kernel List , Nishanth Menon , Vignesh Raghavendra , Devarsh Thakkar , Jayesh Choudhary References: <20230509093036.3303-1-a-bhatia1@ti.com> <20230509093036.3303-4-a-bhatia1@ti.com> From: Tomi Valkeinen In-Reply-To: <20230509093036.3303-4-a-bhatia1@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/05/2023 12:30, Aradhya Bhatia wrote: > From: Nikhil Devshatwar > > With new connector model, mhdp bridge will not create the connector and > SoC driver will rely on format negotiation to setup the encoder format. > > Support minimal format negotiations hooks in the drm_bridge_funcs. > Complete format negotiation can be added based on EDID data. > This patch adds the minimal required support to avoid failure > after moving to new connector model. > > Signed-off-by: Nikhil Devshatwar > Reviewed-by: Tomi Valkeinen You need to add your SoB to this and the other patches. > --- > > Notes: > > changes from v1: > * cosmetic fixes, commit message update. > > changes from v5: > * dropped the default_bus_format variable and directly assigned > MEDIA_BUS_FMT_RGB121212_1X36 to input_fmts. > > .../drm/bridge/cadence/cdns-mhdp8546-core.c | 25 +++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > index f6822dfa3805..623e4235c94f 100644 > --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > @@ -2146,6 +2146,30 @@ cdns_mhdp_bridge_atomic_reset(struct drm_bridge *bridge) > return &cdns_mhdp_state->base; > } > > +static u32 *cdns_mhdp_get_input_bus_fmts(struct drm_bridge *bridge, > + struct drm_bridge_state *bridge_state, > + struct drm_crtc_state *crtc_state, > + struct drm_connector_state *conn_state, > + u32 output_fmt, > + unsigned int *num_input_fmts) > +{ > + u32 *input_fmts; > + > + *num_input_fmts = 0; > + > + if (output_fmt != MEDIA_BUS_FMT_FIXED) > + return NULL; The tfp410 and sii902x drivers don't have the above check. Why does mhdp need it? Or the other way, why don't tfp410 and sii902x need it? I guess at the moment we always do get MEDIA_BUS_FMT_FIXED as the out fmt (in all three bridge drivers), don't we? Tomi