Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <KL1PR01MB54488021E5650ED8A203057FE6759@KL1PR01MB5448.apcprd01.prod.exchangelabs.com>
Date:   Fri, 12 May 2023 17:28:47 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v5] net: mdiobus: Add a function to deassert reset
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <KL1PR01MB54486A247214CC72CAB5A433E6759@KL1PR01MB5448.apcprd01.prod.exchangelabs.com>
 <ZF4AjX6csKkVJzht@shell.armlinux.org.uk>
From:   Yan Wang <rk.code@outlook.com>
In-Reply-To: <ZF4AjX6csKkVJzht@shell.armlinux.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: KL1PR01MB5448:EE_|JH0PR01MB5708:EE_
X-MS-Office365-Filtering-Correlation-Id: faec82a0-4b30-4c62-4d11-08db52cb4df8
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: PVdk6HvBOSIxT7AZxekJyFrzJH6jRB6APLGD5gAQT3prboMl2iCmlYqL/Jxgq0n2DjVDrO4xW8TssILU0fRBCEKj2hTUekc5GpAeWQx08a3y6Nctd1ddluCjVBOJJ7SyGGOtI/MyOBuVORoLCeHxmJQTkvxLwccWY3wEVbGcwYl9t+BDsJD7WrPz6nGOjkgLmUYKoAwNiVe76DmCCp4fA+BpvClx3Hdh81DDy2XPacGUKHB39tuLXLQP3eL+pi+FbWAzwMl+4nBApFMt+aPScUxEB/gvpRF7Vqmp9eC000VC69noD4qfC3HZA6x62ieyyQ/cprIsjViXsDZenDZVp/DYDlajXNQz2pLddWfyVnfzf6ihcx+w8QcSvDH2Fkxgj/N8k/cHT0ee22Ud+WP7BGX/INTLf832nSI8JiL+kiTzjJRz/DtGaR1GYh5jdra+4KeiJcbJy4O9P8dU0PxHyZG1UnJ2GzT6L8ONnnevZ9mdP9vwKc8akv7qKQPLSxKFZem+GATXjGbnO2zWaT5A7/TtBTilCPnHdEbirIETcU4ixCZXLhH+5h7pa/KF9AApYlsOSPIq0UokSjD19jgU7EjlzrIMsa3PWQpuxOlmVixqUJGAcVqGnHLUnX2DR1L5
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eE9CQXF4TXJlNVEzVHFCZTd1QnpJWUtpbzFXeU8rcFRkYUlvSURMNGk4VmM3?=
 =?utf-8?B?WE9yeHdXV1NadW9XUVRTYXZuTHljbmx1d3ZDR0tBR3FKOFdzVVhDajEySldl?=
 =?utf-8?B?T1IzMEhQTExBRFZIRG95UVRwTGVZL29TU1FNSkkzU0d3VEFobEN4RTNCMXA5?=
 =?utf-8?B?NHd4YkRESDBoZVp0RjlMaWszYjc2QzUrQ1cyeEUrZnhXQ0dDMzNYd21ISUh3?=
 =?utf-8?B?VGc3MUVGZHZjNktpMng2STNLYWxsejRBS2I4Z2lmSGd1bUFrVFo3S1BCbHVq?=
 =?utf-8?B?R29SOGEvNHJMc1ZQUEsyMzJxckxiRUtxWFJhemxtSW9YUk9aU1pla3pqaFJo?=
 =?utf-8?B?MTRFeGtEZC8wRnEzcVN3cHlpMUlZQU1zZ0N1M3RFaG1uZk9UR0ZYMkloLzI0?=
 =?utf-8?B?YzJVbnQ2aGRuMXRuV3NOMkpYYUo4ZGZJRHcrR0MzV2NXbkVVSWRmeUpkQVQz?=
 =?utf-8?B?SDlaSVN0TU9IN2UrWVk4c2kzVGs4aUxPWmZSZGdZMFQ5b3BiUW40RUJqZk5n?=
 =?utf-8?B?Q0xRendXaTRwa1Y4VWR5RVEwcno4Rnk0QVZvejRmNUhhSkludE5FRnF1ZkU4?=
 =?utf-8?B?RUZPeEw2aGZMSzVWVjRzaGt3UnJtVHJHT2gxNTBMTXpLWG9jVWYzbFVzbW13?=
 =?utf-8?B?MWZoTkc2SXhscVBBV3h0YVJlbmJXb1NtM1dYWVFzU2lHZGJrbGFpamxtMnIz?=
 =?utf-8?B?K3FCcTBpajlmZDYvRzlKb1h4azIybTlibWY2R2hUeElienhkQWVCYklBeU1j?=
 =?utf-8?B?TnFaZkVONGU0ZVBQQU1sWmJIVExicytJK0s0dmR1dzRYY0g0emljdENhcE92?=
 =?utf-8?B?aHQxV09sdytleDBlK1VlaG9mVjlqTTBYOUM4WnJVd2FCWUFOQkFSVmtiWjFu?=
 =?utf-8?B?QzlkUDVtRTd5U3dUaXd2cWdTdDVOOC9QVDdQWFd6UVl1N01PSk5OOXZYb3J2?=
 =?utf-8?B?ekczRjdKcS9semZyamJZYzFHdGxaaFVkalozcjZNK3dVanpwcW5YYlJ5clF1?=
 =?utf-8?B?WFI0ajBMWHZmZzdRa1ZnZThQS1FhT0ZDQUVCRGhSVXh6MTRlRS9ZM0N5M0lu?=
 =?utf-8?B?WVNGSjluVW5GOG9pbksrZEloYlZEdWtLNERzdzlUL0xxeWdOamQrb0cySlFj?=
 =?utf-8?B?emRZaUhCSlZHNGhZNC94aVNFa1hJZ3owbmRSWXZXdWQwNzZaS0NVTklhYk5p?=
 =?utf-8?B?aGxoL0xkTkpIaDdpcms3MnZreVJYd1BTTGEwYWR4S05QYk44T1Q0T3hXZzhQ?=
 =?utf-8?B?bXlyWGx5VUdrMnB6ME9VY0xzUUQ3VkdNWmRteVplNzc1YWNkUFRidFBCZURa?=
 =?utf-8?B?bjlWM3I4V1FVeVBkRTJHUnQyNE5MRUkvUFZnNE9YdzFiU0U4Zk5VTE9Zem1j?=
 =?utf-8?B?R2JoN0tZQ2pXNURkUi9LWnVVWlV1OTMyMnRPbFpJNnZZOCtxdXBjWG1Gc3NU?=
 =?utf-8?B?UUY4ZU8waVhXb2RxTHRiOUJ1Y3lKemN0N1pMMWtuN2d1eEtLUjYyME84RmpG?=
 =?utf-8?B?eThGbzlNdlA3RnVzajZXTTM5QnBMYWcyY0NUOW5UR3FNcENucHRic21MajV2?=
 =?utf-8?B?RXNaNmtvL0M2c2kwTzIxeEJjRjhGQVBlbUNFeVJNdDExRzdpNUR3TFVmTUhv?=
 =?utf-8?B?YU9aaE1MWVBCb25IeXR0b005ZDEyMEE9PQ==?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: faec82a0-4b30-4c62-4d11-08db52cb4df8
X-MS-Exchange-CrossTenant-AuthSource: KL1PR01MB5448.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2023 09:28:54.5183
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR01MB5708
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_MUA_MOZILLA,
        FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/12/2023 5:02 PM, Russell King (Oracle) wrote:
> On Fri, May 12, 2023 at 03:08:53PM +0800, Yan Wang wrote:
>> +	gpiod_set_value_cansleep(reset, gpiod_is_active_low(reset));
>> +	fsleep(reset_assert_delay);
>> +	gpiod_set_value_cansleep(reset, !gpiod_is_active_low(reset));
> Andrew, one of the phylib maintainers and thus is responsible for code
> in the area you are touching. Andrew has complained about the above
> which asserts and then deasserts reset on two occasions now, explained
> why it is wrong, but still the code persists in doing this.
>
> I am going to add my voice as another phylib maintainer to this and say
> NO to this code, for the exact same reasons that Andrew has given.
>
> You now have two people responsible for the code in question telling
> you that this is the wrong approach.
>
> Until this is addressed in some way, it is pointless you posting
> another version of this patch.
>
> Thanks.
>
I'm very sorry, I didn't have their previous intention.
The meaning of the two assertions is reset and reset release.
If you believe this is the wrong method, please ignore it.