Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To:     Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Cai Huoqing <cai.huoqing@linux.dev>,
        Jingoo Han <jingoohan1@gmail.com>,
        Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
        Vinod Koul <vkoul@kernel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Rob Herring <robh@kernel.org>,
        Manivannan Sadhasivam <mani@kernel.org>,
        Serge Semin <fancer.lancer@gmail.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        =?iso-8859-2?Q?Krzysztof_Wilczy=F1ski?= <kw@linux.com>
CC:     Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH RESEND v5 05/14] PCI: dwc: Drop duplicated fast-link-mode
 flag unsetting
Thread-Topic: [PATCH RESEND v5 05/14] PCI: dwc: Drop duplicated fast-link-mode
 flag unsetting
Thread-Index: AQHZhDwZvGSMdLqDnUS1Z2y/X9+Jo69WZwYw
Date:   Fri, 12 May 2023 09:55:57 +0000
Message-ID: <TYBPR01MB534152367C653DDC7760E0DFD8759@TYBPR01MB5341.jpnprd01.prod.outlook.com>
References: <20230511190902.28896-1-Sergey.Semin@baikalelectronics.ru>
 <20230511190902.28896-6-Sergey.Semin@baikalelectronics.ru>
In-Reply-To: <20230511190902.28896-6-Sergey.Semin@baikalelectronics.ru>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?UGI793xwxY394qOxe0e9ZcIPt82LPlJsjR7FHOVDELbJrRpYGo8A52vgC3?=
 =?iso-8859-2?Q?ZLRiKHKxMGLIZmjxv4nPITAkYwGQ/K19+SrWBdm/m4IKauY6GsgK3gvpZk?=
 =?iso-8859-2?Q?LQbinx66ib/WOZTiix8Kx2zzkIJaMXfebAlQeXyS0AZSKApESkz5Of6v9L?=
 =?iso-8859-2?Q?EZSfpchKJlUeH0l0e2MiDCqhvZSxbDhRbP1IH/AaqVLZcugWTdWW6s4C8E?=
 =?iso-8859-2?Q?ZcY2MImS8ePgp/uG1KajJx6PVwiDofmmvIe9vQF79ziKJ/ZDRHwZMqiyAz?=
 =?iso-8859-2?Q?8O+8MnuNd3YYETRnHg6aEMpNQ7swZCQU6omW9cCvrnDh2vZxBtmoj6o4we?=
 =?iso-8859-2?Q?iE3+lyVD/KWe6wRNmYKyryg9EtXFyoly4To7F+i+cekN+0G4YyVOgYueqp?=
 =?iso-8859-2?Q?wPO9b7bDXzWYGFdnTdo4mDt7LyUPg4K7VR9TNu1L7A5rQ7/IpVAXVMnzcF?=
 =?iso-8859-2?Q?8p0OTlOVmWMrJW1tAAB+lOVZNZFU++H6qk0jdsYX4qpdkydeE6/kc6l2Vv?=
 =?iso-8859-2?Q?c+k2gexZM0HGbJga/K0buesa94jBCF1o8WTi4GLQ+HZ0A2g/809cq15msc?=
 =?iso-8859-2?Q?00N+ixEgNaz/rzOafTG5N4pJpm7fekIXKY6g3Tn+0+A4PIE0UXQEgi20BD?=
 =?iso-8859-2?Q?+d2VanRiwH7oBfqGPVo95qia6uBmlXlTZ9KGh4QJZGfMcv7sdHtEpoPbTS?=
 =?iso-8859-2?Q?MqDmFpvksUA45LhEUMczrdAnMiQ6vFwAGODWnInBV+x0a5v/3o01AYNnHB?=
 =?iso-8859-2?Q?4QTGuOA+6a1zq66A4sPVPwpsLcAo1B/EiyvtDaR1vrMzn10B5O0WPObwLX?=
 =?iso-8859-2?Q?4H1J1ZWY1do4haIX2s4Myzwk1lXwvgThWD9zW6EBtCKnODa1+2UewIDrfn?=
 =?iso-8859-2?Q?hN6EzuUgybd1fmDfvwbKwX61XgR9k83tMwBbXE0gbU6GqtfJbSamL8OSH5?=
 =?iso-8859-2?Q?myGMJImreMm2hbFu26tzsfiwU2qdOVGoO2y3Jn++bJg2SSvlyUIIRzxnKa?=
 =?iso-8859-2?Q?WVPB/b0M4Ag63MGJt6SBSjtHDqJ3fH59uW+V/tKbGKErwV+gDqQizUNgLj?=
 =?iso-8859-2?Q?wwAGs+YNYPT2OMx+csCEvaJt2Ecl+6uOS/vZ2q2PnA7UP2RiWv4F6GPoZs?=
 =?iso-8859-2?Q?7blouv3f9fR9y4OG1n0RoIsF7pgXgyKUNN7cMTzFAmNQ13eyNnLc9Abm+1?=
 =?iso-8859-2?Q?eyNkL75mSD1inTmNBzArOTbJAfSEpTUdxcri0YQxA8hAzeyRsGMuZy5qj0?=
 =?iso-8859-2?Q?INTK6yQb7oDWauZCTJKra2HP8Z8YmJDTvueNjE33XP1l00rwngNHRPQT1O?=
 =?iso-8859-2?Q?zRmtFBkeqKNauKp0rYaUkA2jWk5KzNkRTdJ4twXNpZ5hJiKjkz/E7qmBEU?=
 =?iso-8859-2?Q?hswbtaevACOODTdKJ3LfEOlXlLmWyC2mIOJizHCQGFJLraOGMUkFnRVw23?=
 =?iso-8859-2?Q?tvFKR29Lgswk/jYwwglHj3kokZhFlwmymK3C13c6R+n4tW31h6XX5+LhVf?=
 =?iso-8859-2?Q?y/6yf57f/f1ECSbaTYl8F98z9CvatiAky/HkLW7H2hRIfc16OfHwM01JqK?=
 =?iso-8859-2?Q?obW8Qy9VCq9QmNot4dEwW4clGLo8fQ3o9v5cfNI/00VhZBL8yoVshznRBv?=
 =?iso-8859-2?Q?W4VLsS8dsUN0IOZYuvH9e+v/7jjQ4w8dSeVopZPlv/4La2KGaR7zWOXw?=
 =?iso-8859-2?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYBPR01MB5341.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b94dd63-061a-475e-0b61-08db52cf15a2
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2023 09:55:57.7239
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: O4jdGgTMMR8XjXRikVFcSW6pQvugtsr28HoE0AeWxgR//QJ0iKjcVBYvHU73d4vQEkhJNwMZZT6y6bbHGpXYujX2gsjef8gI42cfD+dhwcnh9feEpPbM3X8GGMylVyaC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB9669
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Serge,

> From: Serge Semin, Sent: Friday, May 12, 2023 4:09 AM
>=20
> Most likely by mistake the PORT_LINK_FAST_LINK_MODE flag unsetting was
> added twice in the commit cff9244432e8 ("PCI: dwc: Ensure FAST_LINK_MODE
> is cleared"): first it is cleared right after the content of the
> PCIE_PORT_LINK_CONTROL register is read, second it's cleared in the
> framework of the link-mode initialization procedure. The later action is
> redundant. Let's drop it.
>=20
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

I'm not sure whether my review is useful or not, but anyway,

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

> ---
>  drivers/pci/controller/dwc/pcie-designware.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/c=
ontroller/dwc/pcie-designware.c
> index 8e33e6e59e68..e55b7b387eb6 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.c
> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> @@ -1019,7 +1019,6 @@ void dw_pcie_setup(struct dw_pcie *pci)
>  	}
>=20
>  	/* Set the number of lanes */
> -	val &=3D ~PORT_LINK_FAST_LINK_MODE;
>  	val &=3D ~PORT_LINK_MODE_MASK;
>  	switch (pci->num_lanes) {
>  	case 1:
> --
> 2.40.0
>=20