Date: Thu, 4 Oct 2007 09:38:28 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Hugh Dickins <hugh@veritas.com>
cc: gurudas pai <gurudas.pai@oracle.com>,
       Nick Piggin <nickpiggin@yahoo.com.au>,
       Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [BUG] kernel BUG at arch/i386/mm/highmem.c:15!  on
 2.6.23-rc8/rc9
In-Reply-To: <Pine.LNX.4.64.0710041647090.17987@blonde.wat.veritas.com>
Message-ID: <alpine.LFD.0.999.0710040920400.23684@woody.linux-foundation.org>
References: <47048A0C.4020608@oracle.com> <200710040053.19570.nickpiggin@yahoo.com.au>
 <200710040139.04201.nickpiggin@yahoo.com.au> <4704BA1F.4070408@oracle.com>
 <Pine.LNX.4.64.0710041647090.17987@blonde.wat.veritas.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1146
Lines: 33


On Thu, 4 Oct 2007, Hugh Dickins wrote:
> 
> Very helpful, thanks.  Guru, please try the appended patch, I think
> you'll find it fixes it for you (it did for me, once I'd puzzled out
> why I was failing to reproduce the problem - tests on ext3 don't work).
> Thank you so much for reporting this just in time!

Ouch.

The patch looks obviously correct, to the point that I don't understand 
how this bug happened in the first place.  It seems to have been 
introduced by Nick in d0217ac04ca6591841e5665f518e38064f4e65bd ("mm: fault 
feedback #1") if I read it right.

So "do_nonlinear_fault()" would effectively end up unmapping the PTE 
twice, right? And if I understand the problem right, this wasn't noticed 
immediately, because it probably only matters on:

 - CONFIG_HIGHPTE
*and*
 - a filesystem that allows VM_NONLINEAR, which became very rare with 
   dirty accounting.

Correct?

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/