Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp10109495rwr; Fri, 12 May 2023 04:05:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ57XDUTlikyyHsG7zDMx3WmCmv4uGaB/fV3gYZ2E2+KL6DkXWMqJYj9XfwoXBjGi6hns2Es X-Received: by 2002:a05:6808:686:b0:389:78b6:62be with SMTP id k6-20020a056808068600b0038978b662bemr6118517oig.49.1683889531250; Fri, 12 May 2023 04:05:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683889531; cv=none; d=google.com; s=arc-20160816; b=KglqxBcAHYZYr4i3rddAgfTQSQ4C78Ptz6x3JQWkPVRva2fEjqAni0wigziRiFd2W/ e3Mc9X5G+m3pkYzoU5ZfJpSIy2XZ8s8Hcw1QYD5jmOMTTWUgGW/CWjSsCnkx0qnVdbs0 BRu1UgODrVcnmRwmeOLxKN4IoxzD6bcTbUzCxaGItbNtBxBGK+QymGrDSet+xVjkw7hJ WYZHWTS+70BOrUEND5gs378cCF5wqnFEg6/InYNYlwtFEQnZ23f1NEVe0mZLkCEzP6sn A3E5zOMTsoGLygjgBIV/tNmwBf8j6JnjIR3PZrBfF3FXNsLqzbp4L69rZSOGlD0czpG5 eegQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=NOl7x+Psyj4YgahuDt2DgXbzK7bC66/jiEWCo+kEnGE=; b=tmnOqdCgZ6SNExkfAeNLnSEOfZ2oEQbJ+z2Fykzg4pXbOdCsTvvOm6lWKDkfArlooT hOpvWaL/ZuidnJ7N1jA0nYfn+QyrFT6ywo+HYnbPcenXZJAb47yOSmhY6Aq80synU+oS +rlBvLAnBeidPFK4cqEkwfE4xJaVdPvMYBv02F1Flw/qyOBTv7sc2SeMACjkvAjAOvi1 jrs6qrIRNK3sBtEzM3TBneoCDfs8JRZ67h1ZmULRiZrpD8E3v+byNcKTOlFvq5ZpMTFm JG7EB/eG0wgwJeFxhCuWM7Dx5A+LlWIbhxgi+Wu+nBxg8Qtu99SKgjbPEZJlZ7Ufwv9T aFzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=U7FKVour; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q129-20020acac087000000b00383ef567e82si5729083oif.89.2023.05.12.04.05.17; Fri, 12 May 2023 04:05:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=U7FKVour; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240587AbjELKpD (ORCPT + 99 others); Fri, 12 May 2023 06:45:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230322AbjELKpB (ORCPT ); Fri, 12 May 2023 06:45:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19FA51208E for ; Fri, 12 May 2023 03:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683888254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NOl7x+Psyj4YgahuDt2DgXbzK7bC66/jiEWCo+kEnGE=; b=U7FKVourZx7H417POPVhM+Sv7+rsNoF66ZJK33tZLBBHXn5aI0gqM4yJMoGHMWWrrVPWJ2 VZLa2npA2QGnGnVfA2u7QC21UPTcOfNMWu9bGs6xGVyN2ns4QMCe+3jHhecw0ONVoZ0H6H d7XrsB7e+BwpvsiJB4xffkuRPFgTsWA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-637-s0bepFT8PyyvTgCpxhjl6A-1; Fri, 12 May 2023 06:44:06 -0400 X-MC-Unique: s0bepFT8PyyvTgCpxhjl6A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5D2D73C0D845; Fri, 12 May 2023 10:44:06 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.40]) by smtp.corp.redhat.com (Postfix) with SMTP id 8055314152F6; Fri, 12 May 2023 10:44:04 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 12 May 2023 12:43:52 +0200 (CEST) Date: Fri, 12 May 2023 12:43:49 +0200 From: Oleg Nesterov To: Josh Poimboeuf Cc: David Laight , 'Josh Poimboeuf' , Peter Zijlstra , Thomas Gleixner , Vernon Lovejoy , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] x86/show_trace_log_lvl: ensure stack pointer is aligned, again Message-ID: <20230512104349.GA6220@redhat.com> References: <20230427140054.GA17800@redhat.com> <20230428043158.r5omehiaqawcac2y@treble> <20230428065513.GA22111@redhat.com> <20230428235747.b5smutdttv5eeopi@treble> <20230512022059.ltlzs7irvbvoj2cl@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230512022059.ltlzs7irvbvoj2cl@treble> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11, Josh Poimboeuf wrote: > > I do like that better, except... put the initialization in the 'for': > > for (stack = stack ? : get_stack_pointer(task, regs); > stack; > stack = stack_info.next_sp) { > const char ... > stack = PTR_ALIGN(stack, sizeof(long)); > please see v3. Oleg.