Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp10148564rwr; Fri, 12 May 2023 04:39:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5WCbNyyXG/11Z9psKpUDmpEurQyzAeQZIyYjGiuGrw87RwascOj0xUP3fEij7IXuxGr/zn X-Received: by 2002:a05:6a21:920d:b0:f5:b7c9:57b8 with SMTP id tl13-20020a056a21920d00b000f5b7c957b8mr30112000pzb.42.1683891541271; Fri, 12 May 2023 04:39:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683891541; cv=none; d=google.com; s=arc-20160816; b=gYc0cBaZ5CHuzcg6Z1pucr0D9FBJ5QODPVhZa6ten+Lyg6ToP8o7j7h2n2R+eDI+Jw C1qtIPcmbz7UQ6uQPtDv9PVCgRl8lEP/m5rb+n48WpGT61nGM/M6T9ynOclrf1FmBlLA z4pWSoQg6ZX2ekY6oDy7o9SHfO20V5m6IpYDML1M4Fe6mdSQOCWaMpXzQgtuAv2tq3h/ fkMZqm5jz65L5btGdruSLItwSeOziXIFZd/zKagtnT+ZUxiAxo1sIuJm/tQAEqZwjoDV T2Z9QmRk0AQXQnQycBv05+U0Nb64O1p6TlxL0JT+XGKhfnQVdGrYbWaJHpBLKA6eUzXG 4bvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uDIHzqSm61MKbT6kGiuqSoH/DEpNRj7S5RHa6wj5DkY=; b=JSm47w5Z/ymvq1qmzejKYDQNS/pRrkx+HFZuZ5xsj+l46u8NOvqSqX3CtQE/SI0p4D s4IEo8aRprDASyMWr5TEzpr+RA5P6ZF121umWUiErGBacKoMYhfNHFhs00qKdXX4loCp zV544mwTfv1HjiniXYgFwquFccOUnkX0qtCjlpM7UpI5F0xQewCPDvqiuc6jz7vJOyEk vjSyZlAW456xofqtWxFUtRkZO3CJaD+Td6kkDXohMCnyMP7WU3vJyIFwhXHOEll1rNeH 8QeSyDsSupRiSJu85HJq2/zJWoJNTVmmJzyrzj+xcA7Sfp/uyzYaH3vK49XF3WXHuA3b XCeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Qawc5t5f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q28-20020a63751c000000b0051f71428e9fsi8760429pgc.285.2023.05.12.04.38.43; Fri, 12 May 2023 04:39:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Qawc5t5f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241093AbjELLXs (ORCPT + 99 others); Fri, 12 May 2023 07:23:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240782AbjELLXp (ORCPT ); Fri, 12 May 2023 07:23:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C5F0BD; Fri, 12 May 2023 04:23:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9A10264E80; Fri, 12 May 2023 11:23:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A07A0C433A8; Fri, 12 May 2023 11:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1683890623; bh=LCee8NPgW5Z48oHs2X+4LDjkaisXA9d7iMkzZ/oL7EE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qawc5t5fo15Uxf3XH5wX4ydaoUgTaiH5Gxx8rNDVp/biF33zfq8hDHrcqmf5PcCRx h5D6KyvrhmHBnN7SoDNKMu4CspgF+DSO0P+kgN08ypYVZZ3jPJDU6Ka94a2pzGDJPb tn6BzE9cqryGUhjbkdQqBbBwgFOFgT0RJq0Y7/jo= Date: Fri, 12 May 2023 20:23:37 +0900 From: Greg Kroah-Hartman To: Bagas Sanjaya Cc: Linux SPDX Licenses , Linux DRI Development , Linux Kernel Mailing List , Linux Networking , Linux ARM , Linux Staging Drivers , Linux Watchdog Devices , Linux Kernel Actions , Diederik de Haas , Kate Stewart , Philippe Ombredanne , Thomas Gleixner , David Airlie , Karsten Keil , Jay Vosburgh , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sam Creasey , Dominik Brodowski , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Wim Van Sebroeck , Guenter Roeck , Jan Kara , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam Subject: Re: [PATCH v2 00/10] Treewide GPL SPDX conversion and cleanup (in response to Didi's GPL full name fixes) Message-ID: <2023051243-bunch-goliath-7380@gregkh> References: <20230512100620.36807-1-bagasdotme@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230512100620.36807-1-bagasdotme@gmail.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 12, 2023 at 05:06:11PM +0700, Bagas Sanjaya wrote: > I trigger this patch series as a response to Didi's GPL full name fix > patches [1], for which all of them had been NAKed. In many cases, the > appropriate correction is to use SPDX license identifier instead. > > Often, when replacing license notice boilerplates with their equivalent > SPDX identifier, the notice doesn't mention explicit GPL version. Greg > [2] replied this question by falling back to GPL 1.0 (more precisely > GPL 1.0+ in order to be compatible with GPL 2.0 used by Linux kernel), > although there are exceptions (mostly resolved by inferring from > older patches covering similar situation). > > The series covers the same directories touched as Didi's ones, minus > Documentation/ (as should have been inferred by SPDX tags on respective > docs). > I'm glad to take these types of changes through the SPDX tree, but please break them up into smaller changes that show the justification for each type of change in each subsystem, so that we can evaluate them on an individual basis. As you did here, you are lumping things together only by the existance of the file in the tree, not by the logical type of change happening, which isn't ok. Also, you can send them as subsystem-specific series, so as to not have to cross-post all of the changes all over the place. I doubt the drm developers care about ethernet driver license issues :) thanks, greg k-h