Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8627aa12-a020-35ac-d954-5a7872957e13@amd.com>
Date:   Fri, 12 May 2023 13:22:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] firmware: xilinx: Update the zynqmp_pm_fpga_load() API
Content-Language: en-US
To:     Nava kishore Manne <nava.kishore.manne@amd.com>,
        michal.simek@xilinx.com, tanmay.shah@xilinx.com,
        mathieu.poirier@linaro.org, ben.levinsky@amd.com,
        claudiu.beznea@microchip.com, ronak.jain@xilinx.com, marex@denx.de,
        roman.gushchin@linux.dev, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20230503050158.1936467-1-nava.kishore.manne@amd.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230503050158.1936467-1-nava.kishore.manne@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z05HLzRpdTFDQmJwK1pSbFRWMHRlMGwwNGl2bTJaT29VUUs2aTFjNm9rbGlT?=
 =?utf-8?B?ajF1OU1LalFoMmhTblE1SlBMdk1EL1ViV1hMK241SnVNbFBoVTJ3WDA2MzEy?=
 =?utf-8?B?N3dUemFWQ3REYnptYXNWR3p0cVpsUmFKNnhTbVE4Ny9pdEpYWVFBQjEwSmJW?=
 =?utf-8?B?QlcvSkNLZEcrNjdTUkl1M1pYMW9WZTZxYnRUNDBOd1V2Q20yUkxHRS92bzY0?=
 =?utf-8?B?STJkVVExdHVVenEvNXpDOTB6MmdSV2l5M0lYVElUNlJwdWd6eVhIWFJXS3Ey?=
 =?utf-8?B?NmZLZWhaVnF2NWUxL3RCUGtXbk5qT3RSakV4N1F3dWdjL2FBV0RKbUFlUlRM?=
 =?utf-8?B?T2xHOFhSbjM1SjVXaUpQZ3ArcEdudnV6THZ1U2xnWGxVVXYvaXR4aityaWxY?=
 =?utf-8?B?c0g5U3FjMHFjZVZGQjBhZFA2QVhnTEx0RzRBQ3FTa2E2NEhMMDZybUJpK3Zp?=
 =?utf-8?B?SHFOWXNtTzE1dEY4UUpqRFZDSGJPeGhyUTZGenF4b0JLQytYby9DWGRvV0xx?=
 =?utf-8?B?dFhkSGsrZzBXRnBiZUE5Qk5jejYrWWlERlBLazVnc2RtZEZwcHh1U3ZDMG9q?=
 =?utf-8?B?N3ZuMHJnVk4rcnUvNkg1Y0d3VXBmYTE0OG5raTlBb1VpSVFUZDJVK1ljL1FH?=
 =?utf-8?B?OEprVTBuRE1SSDRjQ3JxUEFDNFphZ2drQ2ErUEVkUmt4VVFEUHVpN3F1am9r?=
 =?utf-8?B?N2szcmtKT3NzWFl0ZWJ6dG5MVE4xWWNvYU5tMCtCQ3dTdE4zWEVRUzVnRzFN?=
 =?utf-8?B?ZmFvaW16OE5RODM1SXo5QjFEK21UMU10aThNUTdrN3lQV1dHN2JWM095THJv?=
 =?utf-8?B?YzFDNDZZYTlBMXRGekQ4TFRKRVNuVXZtR0djNVk1Z0ZFWWs2YXNpRE9ubklr?=
 =?utf-8?B?aTFMamdsTjFwUEVGT2VGSFVQLzFMVG5oa3g0TXEyaXR2MW44YTJHS0Qvb0Fy?=
 =?utf-8?B?bWpRZDkwaGlOeExSVVplaUJ2eWJ3RnBRNzMrbFhFYUpTNHk1N1k1QW12b0Yz?=
 =?utf-8?B?Rk5QeW9saUpCMkEzQWMzc3BzR0V3eW1hanZjTU5KOGVnRkVRR0Z4UWVFSFkz?=
 =?utf-8?B?cjNkL1diemt3bVdYVDVXV1lWYWJMaldGKzVxUzRwTDdWV05KYnFIOGdVbzRu?=
 =?utf-8?B?b0c2d2FxVWRyd2JGVkdhekhMMlhiR0IzdUR2aDdpVUxQci84QTJzaUt2cnAv?=
 =?utf-8?B?ajZnTEF5WTkrK09zd1duVDFScHY2dWxvTWNlaCtvcHpuajNFVUcyK0tBOGRH?=
 =?utf-8?B?d1pLbHVKZy83ZCs1eWZsWXpYaFF6SDVxY2V4OWpNbEVRMnJCdS9JdUROQk4r?=
 =?utf-8?B?MjlWaVo1TXBDc1J0eDl0bGJaSzBGTmVKYUlwb1NkcjhqYWFEcDB3bjljdVV6?=
 =?utf-8?B?VnFFeld1bnVZMURCUDdmZ2F1TDVQckVmZVk3RDF3SW9KeURINFo5VjhvMnZH?=
 =?utf-8?B?aHlEeHFCUHQzNEcweUlkZ05xb0lvaTdvQVFpby9naEh5cjlqUHVWYmQrMVRG?=
 =?utf-8?B?c2pRMzlTb1lCT1BYSndVYzlzdElDQTVUNktrOFRsbVdMT3NwNVdsMW1kakVk?=
 =?utf-8?B?L01YditBeVZUMkgxR082WThZK05CUVJUY21rMnZyUThObFlOekwwa1pPWnV4?=
 =?utf-8?B?eFhTeWt0WEg1SEZkUkc4cGZvdHdlYXVzdzRGMENLZEJINGpxVVJYREU5UVFB?=
 =?utf-8?B?MWlUWm1CWGpCWnlLa2kwS2pBY3IrWDdlSnd6empzeU5NZzlBNlVJVnpyS0dY?=
 =?utf-8?B?ZE1CZ2Rxb1QzV3RheFlSZmtrc1Vkc2ZCQmJxSnArZUtDelRzbkgyOFFQRDk4?=
 =?utf-8?B?RUxQVERaRXdEeDZKSjAvS1BKZGsrM2hWN3Vta2Rha0dnMG0wWngzQ082RnQw?=
 =?utf-8?B?bmc2OXowYWQyRThwVGNTcE9tVUE4ZmpnUThpR01TQTJHMG1lUmpYT2ttMjZ1?=
 =?utf-8?B?eGRxT1JpRTFhYUdYd055WjdtRUU0YlAxM0FXYVN2ZjUvcWtzR2lLL1BQb2tV?=
 =?utf-8?B?NGpRek1lY3FTMTZaWEtVd1liRmFZVlRlbWRXL1B2SEdVd3R0NHN2eWlWQ0dZ?=
 =?utf-8?B?RC8vbDk2ME44VktoTmZ3eW05dCt6cHRmOGEyQlE0dXhZalQ5bkE3NHZGNE9a?=
 =?utf-8?Q?bcbn0taEZPpBxf2zw8+CQwJPl?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3ec01b9-2fc5-4f2b-03d0-08db52db2955
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2023 11:22:25.3020
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q7GttJKl/FOj2hJy3VonLMpFs9S1W0YlfCX3XsGQ5aXOkLf6c7PEByCUsAaCOl8f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4161
X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/3/23 07:01, Nava kishore Manne wrote:
> Update the zynqmp_pm_fpga_load() API to handle the firmware error’s
> properly.
> 
> Signed-off-by: Nava kishore Manne <nava.kishore.manne@amd.com>
> ---
>   drivers/firmware/xilinx/zynqmp.c | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index ce86a1850305..398ab86e2bec 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -942,8 +942,16 @@ EXPORT_SYMBOL_GPL(zynqmp_pm_reset_get_status);
>    */
>   int zynqmp_pm_fpga_load(const u64 address, const u32 size, const u32 flags)
>   {
> -	return zynqmp_pm_invoke_fn(PM_FPGA_LOAD, lower_32_bits(address),
> -				   upper_32_bits(address), size, flags, NULL);
> +	u32 ret_payload[PAYLOAD_ARG_CNT];
> +	int ret;
> +
> +	ret = zynqmp_pm_invoke_fn(PM_FPGA_LOAD, lower_32_bits(address),
> +				  upper_32_bits(address), size, flags,
> +				  ret_payload);
> +	if (ret_payload[0])
> +		return -ret_payload[0];
> +
> +	return ret;
>   }
>   EXPORT_SYMBOL_GPL(zynqmp_pm_fpga_load);
>   

Applied.
M