Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <452a60bc-cb8e-b5de-4317-c107521db7c5@amd.com>
Date:   Fri, 12 May 2023 13:28:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] Revert "arm64: dts: zynqmp: Add address-cells property to
 interrupt controllers"
Content-Language: en-US
To:     Michal Simek <michal.simek@amd.com>, linux-kernel@vger.kernel.org,
        michal.simek@xilinx.com, git@xilinx.com
Cc:     Harini Katakam <harini.katakam@amd.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Michael Grzeschik <m.grzeschik@pengutronix.de>,
        Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
        Rob Herring <robh+dt@kernel.org>,
        Robert Hancock <robert.hancock@calian.com>,
        Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>,
        Tanmay Shah <tanmay.shah@amd.com>,
        Vishal Sagar <vishal.sagar@amd.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
References: <e3312910db0922bb8c24a8e681de41709ca11bdf.1683035456.git.michal.simek@amd.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <e3312910db0922bb8c24a8e681de41709ca11bdf.1683035456.git.michal.simek@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Uk1DN3d6WG1rRWNSY0tIampEeEQ5UlZBU1hPbXVWTXhvcHgxM2pSc1ZYQjc2?=
 =?utf-8?B?bE9GMXZhQ2syZFE5Q2YwQVdXNXpnaW5YbWl6cWIva1h6K1lyTE9XWVZUbmRs?=
 =?utf-8?B?VTBPZlViTkpHMTlkUlh1SFdDSkVhek9MUmFxbmh5Q3E0VForWVg1THovWUZl?=
 =?utf-8?B?d0FIaUFEZGNGb2ZHTHJSZjdUNFBFSXhEVVp6NGZNT3hTWDZGMkJZZkZJU2o0?=
 =?utf-8?B?ei9ZNG9aQllxTXFTc1VTb2ZqdGwzRmdjQituWjhMUFFkN1duZmFIbHlxWGJB?=
 =?utf-8?B?MXBrQ3ZHMGZHNm8vd3docUdXVjM4a1FUb3BiUnJNMW1mQW4yd0gwVTB2TkVG?=
 =?utf-8?B?Q0R6K3BmVXVibmlXelBybzIxNXBwaW9LRmV6V2pHVW5jWm83NjN0NzJkTlFs?=
 =?utf-8?B?akRSQzUrR0hheDFuNE1hbWRlR1B6cGxWUmZQV3J3TFQ0U2lrbXVieDRqNWFo?=
 =?utf-8?B?Mlh6dXZFcnV5dndOQy9JL2dwREt3Q0JZOS9mbllDL203UmlPbXh6SGI1RGhU?=
 =?utf-8?B?ZGNlS3hoMXQvbHg1Tnpva1o0a0M5RTVoeHovbUt0eHNydklZMm5VS3FBWTJj?=
 =?utf-8?B?cDdYY2IvMk5DOXhzSzhWZXA0cWJSWC9BSkdCQ3UrVGU5d29WZGZ5V0VtaElO?=
 =?utf-8?B?WE1SaUJqUlRERTk2Z0M4b3RsR0wrUXFObmJBbjhNdS9uRGYwUDFBL0l6cUlH?=
 =?utf-8?B?QWNGSXplVXFVUDBDaGVlWndpZllZOUR1c3g0NzNnYmNqd0k1cUJ2SWJPTEN0?=
 =?utf-8?B?d1BiLzU5bFh3QWord0dNcFdPUCt5Qzg1b3VzNkdFaWgzbDJ0TlNQeTFoVDg1?=
 =?utf-8?B?VUFMaFlQSDdTQ2NxMHNWZWs1cG1vMmZlKzQvZldVc0ZhUnVRTHExTkhKSkRC?=
 =?utf-8?B?cko0S2hNVkZUMVlzWmt5MXVWY1R6RkJQQVJ4T0FsS2JxZjJqUkhVaFNRbld5?=
 =?utf-8?B?NEUzcVY4Vlc4R3lPVVZkY1lFTDRWMUdLaEhsYjdCMkV1UzZEOXU5Vml0RkVF?=
 =?utf-8?B?cXNPc2lGcmd4TTFydWdxbThEUTVXajJROFU5WURjZzhiRzUyb0JmY21WRlFX?=
 =?utf-8?B?dWZHUERmd0p5SkxZOE1uN3NKd05QSjB2TmtiRHBTVjQyY2gwZjdSM2x1Z3lO?=
 =?utf-8?B?cmtZWGRUbi93MDd4bTJ3T0dZbzhWVlJ4RVRxOUpScDBscmdNb1BwY3dVMnVi?=
 =?utf-8?B?dXUxQlBodXpBRmtEdkYrUVJwMHRUVCtVUDE0YmVSeVFuSnI3a1B0RDJvLzlq?=
 =?utf-8?B?aHlIZzhIWWxpSU4rWm55SW9jTEhmRnYzSjBXTDNhMjFWNml5Mk5weEVFU1VQ?=
 =?utf-8?B?U3lFblhNRFpNN0MvQmV4K0xPcHRyRnIzK1ZncEIyWHNQTGJGOHVqeDMxcWp6?=
 =?utf-8?B?ckZPUWFqaCt6NGh3dU1iUkpqSGVYNVcwK2tUd3J0anVhWXI3dnBFbk5FKzFQ?=
 =?utf-8?B?ZXdzNWxScTZnTEhZVk9WaXY5dVNuRFVHTWZ2QkM1NUVHREFZRGhubFJxUjk5?=
 =?utf-8?B?MTRQeXE4QWR1VXJjc2Q2QnBGdUl0NUwrWTBpZ01wWXFJWFNmMHd1ZlA1UVE2?=
 =?utf-8?B?bU5qaU5Pd3NiZ2FvSGkxNFoxVDJ6SEhYN2w0enpxZllFb0hpNDk1MHZHSHll?=
 =?utf-8?B?dm1TL0FWemlrZm82aThhaEdveU8waG5jYXJCUzhQVFhYUHJFQVV1d3BYa21M?=
 =?utf-8?B?RlVLQ2U3ZTZvODUzUXNlb2gxRzNzY2M3S3JEak1JRlUyUUVtRVpXMUhDLzcv?=
 =?utf-8?B?aWVyNGlHeU5RVHR0d3NFS09wWXJLWVk5U3QvRGZ0V3dmUkIyQ25yS1prQXB4?=
 =?utf-8?B?SW1kdEhTWWJWSHg1Y3RRcEY4c2NLL3NoU2M1eTFhQnVRM01jeDZmTjJJVVVt?=
 =?utf-8?B?WDNNREcrNzJKRlgyNkRZaC93Q2N5R1krYUlqUTBZdDBpbWd3ajl3KzFSOG9Y?=
 =?utf-8?B?OXFLWCtWU3ROOUtUdlRvYWFRcUdRWnRXRzZWek84Um91ZjExUCtWREJsQjVB?=
 =?utf-8?B?Zko4NnJVQU5OQzVFVGxQMS93T2pETXJXMjNhUzRIazNobTFZSEFzQWEwQkcv?=
 =?utf-8?B?aGg0MDkwVndkQlNGdXlhNW83aWttZTd3NWxSaDVmZStROG1VaDdlNkhDTmYy?=
 =?utf-8?Q?9QB3iYkaLJ5x9qL4p51mUPe3H?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b11148a8-c012-4b25-c508-08db52dbfae6
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2023 11:28:16.7540
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NpeYV4Wy3S5V97TrsuU67asYtm8VVmpA+SrAxqw1ncHY0/M32zaMaGmRrtGO7vSQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7001
X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/2/23 15:51, Michal Simek wrote:
> This reverts commit c6badbd2d321c19d4f55ee56b0ef12bb3352feac.
> 
> Long time ago this was discussed with Rob at link below that there is no
> need to add address-cells to gpio and interrupt nodes that's why reverting
> this patch for ZynqMP.
> Also there is no visible DTC warning which was seen in past.
> 
> Link: https://lore.kernel.org/r/91e3405245c89f134676449cf3822285798d2ed2.1612189652.git.michal.simek@xilinx.com
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
> 
>   arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 51b8349dcacd..2d564ba7e9e4 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -419,7 +419,6 @@ fpd_dma_chan8: dma-controller@fd570000 {
>   
>   		gic: interrupt-controller@f9010000 {
>   			compatible = "arm,gic-400";
> -			#address-cells = <0>;
>   			#interrupt-cells = <3>;
>   			reg = <0x0 0xf9010000 0x0 0x10000>,
>   			      <0x0 0xf9020000 0x0 0x20000>,
> @@ -633,7 +632,6 @@ gem3: ethernet@ff0e0000 {
>   		gpio: gpio@ff0a0000 {
>   			compatible = "xlnx,zynqmp-gpio-1.0";
>   			status = "disabled";
> -			#address-cells = <0>;
>   			#gpio-cells = <0x2>;
>   			gpio-controller;
>   			interrupt-parent = <&gic>;

Applied.
M