Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Oleksii Moisieiev <Oleksii_Moisieiev@epam.com>
To:     Cristian Marussi <cristian.marussi@arm.com>
CC:     "sudeep.holla@arm.com" <sudeep.holla@arm.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Peng Fan <peng.fan@oss.nxp.com>,
        Michal Simek <michal.simek@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [RFC v2 1/3] firmware: arm_scmi: Add SCMI v3.2 pincontrol
 protocol basic support
Thread-Topic: [RFC v2 1/3] firmware: arm_scmi: Add SCMI v3.2 pincontrol
 protocol basic support
Thread-Index: AQHZeEK6SX8vcPOUbkqIYZzlwR9d3a9MJZqAgApEBICAAAT5gIAAPBmA
Date:   Fri, 12 May 2023 12:31:00 +0000
Message-ID: <20230512123059.GA3497038@EPUAKYIW0A6A>
References: <cover.1682513390.git.oleksii_moisieiev@epam.com>
 <b4d60f3408f8fe839933fa3938ecdc9bfceb75d7.1682513390.git.oleksii_moisieiev@epam.com>
 <ZFVeY3jVNfAkW1G9@e120937-lin> <20230512083805.GA3424996@EPUAKYIW0A6A>
 <ZF3/Ge4b+49ni+e6@e120937-lin>
In-Reply-To: <ZF3/Ge4b+49ni+e6@e120937-lin>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?f089g+hUqd3igRGvrEMFTWnHFvkaPwBWrEHsXOcnZdM0fZbWv332zoV5OyNE?=
 =?us-ascii?Q?4f+qE5bH9pHJUJyAXOaK+IcTJNKijd57zYoqEWBd3PN8i/r01BNJROhE7tAy?=
 =?us-ascii?Q?/hA7sOhkw3kfJ8/u9ZImtocEnZcGlZ2F0dK989MFB4Ok1GNptyaEbo0SR/d2?=
 =?us-ascii?Q?g1PQAQHkrk0jsKVeFjhKZtEpFVrObuwc//Z1r23V0q76hJWcYD6efI7kuwU/?=
 =?us-ascii?Q?XAt1JtozDK/u3Qbjik/UKHReUWRdG3uf3Swxg6mhtSfIvK6xuHj0ieMB+G16?=
 =?us-ascii?Q?/mi635HzM9aTd2jorw1U7slJk0oqqd0V8jsZPdU6x6YE70+D8uEzxNwSqosZ?=
 =?us-ascii?Q?OUW9i28BvJIr/2B8+Vy4On5K1QK/FOT411j6/L71wQAqQlpgyEClrzcOwvYH?=
 =?us-ascii?Q?Q0KHr60dsSymmwzpAt66KGt/5Qm4PEU5bRl/lUSK9tWPWcCUztRczD1EaR+C?=
 =?us-ascii?Q?+R8g9ZLwFJ2BZifLURNH2SJB9HgToTJDHtqBJwTR+6YMaNNPVF86FtKEQZ3a?=
 =?us-ascii?Q?JrkNxSuIbFPEoCyQ/JBy8ohn7oa6lDP/jABEm2MNyOnk2ivXPHbLOjbqStYu?=
 =?us-ascii?Q?Kg2vrUdnZwIYcpbD9C2NoMjFWIPjHJA+oo1lxBz5mMBNXtBQI2JSM1cJaEk7?=
 =?us-ascii?Q?pGJqlEwG5pkjPPlFNmd68vvIUkqmLXrd7W1FWBAV19mXPn81Wri8eIzrX1wC?=
 =?us-ascii?Q?X/Tyy8tAcwHa6XDgK2bme/2jEmtbOcYRLl4Pftm350F5QDWxYbxyeJKPB6+0?=
 =?us-ascii?Q?OcFmYlrtSTduQFaIsChPQ3cFgH1COUXLUPJdSt1ITxuSZovYHbY/HOEFWxhp?=
 =?us-ascii?Q?BtpJ85QhANUgOVJiTJXaNWe2GvBn72p2Nvr0wACjP1Ob+LMbjvY5ACJmvnRJ?=
 =?us-ascii?Q?pWLzJlzF9HxYNIcfiHV2eN51VrIU8ZzshFp0dffokPWTDmnmxkdowhg6gAqf?=
 =?us-ascii?Q?9nSDB4ZUOflVIS4qd0eddu9MAtnRlTbCQgpdZvNFMUQeu+lf/7/4NixcRmJp?=
 =?us-ascii?Q?kyfEmdb2lAVfk3woS/dtRrjcx++qaniTf2qwfe9+mAp8QqKc2mqMRu5Ktli4?=
 =?us-ascii?Q?cTE4W83KOwK6q07JpB9aDJ7UXvs0PlssS8DkQ41OcjqqlDiW9xAmC139aGI7?=
 =?us-ascii?Q?N2r5Cdd+Ak4kBYGcTy5VcrGwVeL+82b4ZvX4JrlueHSmJK0h4IqtGrOH/MHu?=
 =?us-ascii?Q?+ss0Yo8Ant6MrlLEOOasbxJ3+4ZDzVpjdyezlNo/4ksxY546tBdyjPVrR9jj?=
 =?us-ascii?Q?wqjJLCFY/5S9fGG8Z4CteDYT7Vs/FYea4V0rfso41K2mTqQ7hBhabDYjl6CW?=
 =?us-ascii?Q?C7ieK93L17tURduU7m+17YsZFCgBxTTADhOpOnRDMwJl7kLZvAikQ8GF54V9?=
 =?us-ascii?Q?fxz+G3ojU+D4AWnPJaSouSzUB3zEDjWqM/+6PIGaG++XTO+h4mt/SNthUX63?=
 =?us-ascii?Q?gNq+eETchLCK9Lg2fsuYoo5b2jr0pTH1iDmksR5L5eUYhQRCg+i5rlZLKF8Y?=
 =?us-ascii?Q?ZmhZza5K1GYiepFuxc/FLMRxq6VEf1QbczWLjqgAH2c7homsb6XO1i9C3mX0?=
 =?us-ascii?Q?W1HGUQ0FwVxV9fV8Idu/u3957hJo3C3a2THwVzVK/gr/GTuLXCFf45GZNOaI?=
 =?us-ascii?Q?Aw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E9F70458B700F14FA33B34FEFAA860C7@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ceb7863d-6b19-4365-48ba-08db52e4beb1
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2023 12:31:00.8110
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4FneXLEp7bSm7fF0izCZ6c2LqwIs/wYxLfLJj+jNnwRp0b4VveR1A5KmRlllXnb3XkCsxe//CdRVWURzkWNWfW+VxCtWdX/B73Q8LqlE2B0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR03MB6848
X-Proofpoint-GUID: TTT4CF6RRQWhQaMzgFRjA9eN3LCquyjH
X-Proofpoint-ORIG-GUID: TTT4CF6RRQWhQaMzgFRjA9eN3LCquyjH
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-12_08,2023-05-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0
 impostorscore=0 bulkscore=0 priorityscore=1501 spamscore=0 clxscore=1015
 phishscore=0 mlxlogscore=999 malwarescore=0 lowpriorityscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305120104
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 12, 2023 at 09:55:53AM +0100, Cristian Marussi wrote:
> On Fri, May 12, 2023 at 08:38:06AM +0000, Oleksii Moisieiev wrote:
> > On Fri, May 05, 2023 at 08:52:03PM +0100, Cristian Marussi wrote:
> > > On Wed, Apr 26, 2023 at 01:26:37PM +0000, Oleksii Moisieiev wrote:
> > > > scmi: Introduce pinctrl SCMI protocol driver
> > > >=20
> > > > Add basic implementation of the SCMI v3.2 pincontrol protocol
> > > > excluding GPIO support. All pinctrl related callbacks and operation=
s
> > > > are exposed in the include/linux/scmi_protocol.h
> > > >=20
> > >=20
> > > Hi Oleksii,
> > >=20
> > > Thanks for this.
> > >=20
> > > I tried out this in an emulated setup and found just a minor issue fr=
om
> > > the spec/functional point of view...then I reworked the extended name=
s
> > > support using a modified hops->extended_name_get helper (as said the =
core
> > > SCMI support needed a small modification to support PINCTRL): I'll re=
ply
> > > to this mail thread with such core SCMI modification patch, so you ca=
n
> > > include this patch of mine in your next V3 and use it in your series.
> > >=20
> > > Moreover, given that I wanted to test such rework of mine and a bunch
> > > of other cleanups I did (as detailed down below), and it seemed silly
> > > to throw all away just to then having to detail all to you, I'll also
> > > include in another distinct reply the raw diff of what I changed in
> > > your series to use the new extended_name support and a few other clea=
nups,
> > > so that, if you want, you can just quickly merge that into your V3 pa=
tch
> > > (of course if you like it and tests fine also for you...)...these are
> > > small changes, if you take it, no need to bother with authorship and
> > > attribution from my point of view.
> > >=20
> >=20
> > Hi Cristian,
> >=20
>=20
> Hi,
>=20
> > Thank you for the patches. I've applied them and tested with powerpc,
> > mx68 and clang environments (as test-robot complained about).
> >=20
>=20
> Yes, sure, they were just tentative fixes, needed cleanup.
> I forgot to add the RFC tag on my proposed fixes to avoid triggering the =
bots.
>=20
> > > > Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
> > > > ---
> > > >  MAINTAINERS                           |   6 +
> >=20
> > [snip]
> >=20
> > > >  SYSTEM RESET/SHUTDOWN DRIVERS
> > > >  M:	Sebastian Reichel <sre@kernel.org>
> > > >  L:	linux-pm@vger.kernel.org
> > > > diff --git a/drivers/firmware/arm_scmi/Makefile b/drivers/firmware/=
arm_scmi/Makefile
> > > > index b31d78fa66cc..071ac65f22b9 100644
> > > > --- a/drivers/firmware/arm_scmi/Makefile
> > > > +++ b/drivers/firmware/arm_scmi/Makefile
> > > > @@ -3,6 +3,7 @@ scmi-bus-y =3D bus.o
> > > >  scmi-core-objs :=3D $(scmi-bus-y)
> > > > =20
> > > >  scmi-driver-y =3D driver.o notify.o
> > > > +
> > >=20
> > > Do not add spurios lines.
> > >=20
> >=20
> > Thanks, removed
> >=20
> > > >  scmi-driver-$(CONFIG_ARM_SCMI_RAW_MODE_SUPPORT) +=3D raw_mode.o
> > > >  scmi-transport-$(CONFIG_ARM_SCMI_HAVE_SHMEM) =3D shmem.o
> > > >  scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_MAILBOX) +=3D mailbox.o
> > > > @@ -10,7 +11,7 @@ scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_SMC) +=
=3D smc.o
> > > >  scmi-transport-$(CONFIG_ARM_SCMI_HAVE_MSG) +=3D msg.o
> > > >  scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_VIRTIO) +=3D virtio.o
> > > >  scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_OPTEE) +=3D optee.o
> > > > -scmi-protocols-y =3D base.o clock.o perf.o power.o reset.o sensors=
.o system.o voltage.o powercap.o
> > > > +scmi-protocols-y =3D base.o clock.o perf.o power.o reset.o sensors=
.o system.o voltage.o powercap.o pinctrl.o
> > > >  scmi-module-objs :=3D $(scmi-driver-y) $(scmi-protocols-y) $(scmi-=
transport-y)
> > > > =20
> >=20
> > I've applied patches you provided and made a small fixes. I'm going to
> > make patch:
> > "firmware: arm_scmi: Add optional flags to extended names helper"
> > as a separate and squach "Misc Fixes and refactor" to my changes in V3 =
if you
> > don't mind.
>=20
> Sure, that's what I meant: include my general extended fixes at the
> start of your series and just squash the misc_fixes (additionally fixed
> by you :D) in your series.
>=20
> A small nitpick I noticed later in scmi_protocol_ops Dox comment
>=20
> + * struct scmi_pinctrl_protocol_ops - represents the various operations =
provided
>=20
> should be=20
>   * struct scmi_pinctrl_proto_ops
>=20
> Thanks,
> Cristian
>=20

Hi Cristian,

Thank you very much for your help and your patches. I'm in the finishing
line with V3. I'll send to you the unit tests (when I fix them to work with=
 the
latest changes) I'm using to test my changes and driver for ATF.
Hope it will help you to test your environment.

Best regards,
Oleksii.=