Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp10351556rwr; Fri, 12 May 2023 07:07:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Z6Ge3PRF6Qd9QOLnAhnRh76ONaW4gXsP7AXfLlVBBeaaoYEWKOAZ8eDxihehFCLeHuuuM X-Received: by 2002:a17:90a:fc90:b0:24b:c580:1ab8 with SMTP id ci16-20020a17090afc9000b0024bc5801ab8mr23881919pjb.40.1683900475648; Fri, 12 May 2023 07:07:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683900475; cv=none; d=google.com; s=arc-20160816; b=Bgl6cyWSUWveOacGdciB2IeL13oPSmH2dSEQhhrDn7dJZdk50rbQUZlXZ8PUv/4Wbm mH+FpoINa4LHzOa6Chv3H7hbgS3Mry+TDVShxxS2DNdONQfzTpfEEtY5haQz/VeIfhwP 25dICH9ejTyfbZcrL47PQuywtOI//w9009HPWfLMapql4/fyl7iH8LOGNKufAoZgRfur oQdH8dxcBK0MCZoQ1kxFmicB9tfCOEP8j9A0OD6JMwjxM8vAsmqmEMgKsmnR1JxaZVod +OVwRicWbC0IGJvfcbiN+mvmwvELmqB9J1iZe2Fb6ULUTykCrOh2HDT7/+Bqko55IwPn Oa+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=dq0IpJFfSgCVlubYVkzsilL0voUwv/abAZezn66HITk=; b=u+6V4U4XfeNWLk1wjDM5nVRRroUATmYbD3w0bpiA2TAY4PXWPQ6GDGU0U+HxupsliP Dovh+odyv5CLH4vSGzxOZyWLgbE0c08rYZRmp2LHvqQ8V2H6lmSdK76boE5kcxKhlzPa ouzSSM8NGq9rJ96nWynZ075s53tUKYPCFafDPXcDQaVxiixgcZ/5CQqLvJnrhByd8pKy c1AxzIblMlAS6k89fWhAjWUgPNqkKB8JW6ev3iA5fRPRhnBSSCX+AigGQo161+7q6IrR c/A4JBzHhmQLdhLGGDFFT2V0P+8CvCOrrK3IPgEnuPOAxlU88Qm0VTKWZ6XMNHOlQSze bU1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x36-20020a17090a6c2700b00233e301c780si23207975pjj.31.2023.05.12.07.07.40; Fri, 12 May 2023 07:07:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241268AbjELNpR (ORCPT + 99 others); Fri, 12 May 2023 09:45:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241250AbjELNpQ (ORCPT ); Fri, 12 May 2023 09:45:16 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBDFB132AB; Fri, 12 May 2023 06:45:15 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 6671C68AA6; Fri, 12 May 2023 15:45:11 +0200 (CEST) Date: Fri, 12 May 2023 15:45:11 +0200 From: "hch@lst.de" To: Jinyoung CHOI Cc: "axboe@kernel.dk" , "kbusch@kernel.org" , "hch@lst.de" , "sagi@grimberg.me" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "johannes.thumshirn@wdc.com" , "kch@nvidia.com" , "willy@infradead.org" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 03/14] block: bio-integrity: cleanup bio_integrity_prep Message-ID: <20230512134511.GB32242@lst.de> References: <20230510084407epcms2p123f17696d3c30c749897eeaf2c4de684@epcms2p1> <20230510085018epcms2p5a3830e37b13e9a6799298050abdc77dc@epcms2p5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230510085018epcms2p5a3830e37b13e9a6799298050abdc77dc@epcms2p5> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find these "block: bio-integrity:" very unreadable. It seems like a lot of commits just use block, which looks neater to me. The same also applies to many of the other patches. The patch itself looks good to me: Reviewed-by: Christoph Hellwig