Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 12 May 2023 15:52:24 +0200
From:   "hch@lst.de" <hch@lst.de>
To:     Jinyoung CHOI <j-young.choi@samsung.com>
Cc:     "axboe@kernel.dk" <axboe@kernel.dk>,
        "kbusch@kernel.org" <kbusch@kernel.org>, "hch@lst.de" <hch@lst.de>,
        "sagi@grimberg.me" <sagi@grimberg.me>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
        "kch@nvidia.com" <kch@nvidia.com>,
        "willy@infradead.org" <willy@infradead.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 08/14] scsi: add scsi_alloc_integrity_sgtables() for
 integrity process
Message-ID: <20230512135224.GE32242@lst.de>
References: <20230510084407epcms2p123f17696d3c30c749897eeaf2c4de684@epcms2p1> <CGME20230510084407epcms2p123f17696d3c30c749897eeaf2c4de684@epcms2p3> <20230510085607epcms2p3d2b2dfc5db42f77c41f570c361a41c6a@epcms2p3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230510085607epcms2p3d2b2dfc5db42f77c41f570c361a41c6a@epcms2p3>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Wed, May 10, 2023 at 05:56:07PM +0900, Jinyoung CHOI wrote:
> +	if (WARN_ON_ONCE(!prot_sdb)) {
> +		/*
> +		 * This can happen if someone (e.g. multipath)
> +		 * queues a command to a device on an adapter
> +		 * that does not support DIX.
> +		 */
> +		return BLK_STS_IOERR;

Nit: expand the comment to take up all 80 characters now that you've
unindented it.