Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 12 May 2023 14:51:56 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Jisheng Zhang <jszhang@kernel.org>
CC:     Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Arnd Bergmann <arnd@arndb.de>,
        <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 1/4] riscv: vmlinux-xip.lds.S: remove .alternative section
Message-ID: <20230512-lunar-overbook-e34b468dda65@wendy>
References: <20230511141211.2418-1-jszhang@kernel.org>
 <20230511141211.2418-2-jszhang@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="KkOtcrj+AD9/k7Ew"
Content-Disposition: inline
In-Reply-To: <20230511141211.2418-2-jszhang@kernel.org>
Precedence: bulk

--KkOtcrj+AD9/k7Ew
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, May 11, 2023 at 10:12:08PM +0800, Jisheng Zhang wrote:
> ALTERNATIVE mechanism can't work on XIP, and this is also reflected by
> below Kconfig dependency:
>=20
> RISCV_ALTERNATIVE
> 	...
> 	depends on !XIP_KERNEL
> 	...
>=20
> So there's no .alternative section at all for XIP case, remove it.
>=20
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Just to note, this series doesn't apply on top of -rc1 - what is the
base that you used?

Cheers,
Conor.

> ---
>  arch/riscv/kernel/vmlinux-xip.lds.S | 6 ------
>  1 file changed, 6 deletions(-)
>=20
> diff --git a/arch/riscv/kernel/vmlinux-xip.lds.S b/arch/riscv/kernel/vmli=
nux-xip.lds.S
> index eab9edc3b631..50767647fbc6 100644
> --- a/arch/riscv/kernel/vmlinux-xip.lds.S
> +++ b/arch/riscv/kernel/vmlinux-xip.lds.S
> @@ -98,12 +98,6 @@ SECTIONS
>  		__soc_builtin_dtb_table_end =3D .;
>  	}
> =20
> -	. =3D ALIGN(8);
> -	.alternative : {
> -		__alt_start =3D .;
> -		*(.alternative)
> -		__alt_end =3D .;
> -	}
>  	__init_end =3D .;
> =20
>  	. =3D ALIGN(16);
> --=20
> 2.40.1
>=20

--KkOtcrj+AD9/k7Ew
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZF5EewAKCRB4tDGHoIJi
0qKNAP9aitzYq7AlSofj+QbNcfXCXhkwYqHc/PfL9wm6T+7L/AEAxM1sVUTR6Q5X
ZQQVS36s/TbfTTqMRH5b95PAfeWIzQo=
=W6hv
-----END PGP SIGNATURE-----

--KkOtcrj+AD9/k7Ew--