Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9dd68975-b8a0-b7ec-3556-c0d7e16ac585@amd.com>
Date:   Fri, 12 May 2023 10:04:57 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] drm/amd/display: Simplify the calculation of variables
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        harry.wentland@amd.com
Cc:     sunpeng.li@amd.com, Abaci Robot <abaci@linux.alibaba.com>,
        Xinhui.Pan@amd.com, Rodrigo.Siqueira@amd.com,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, daniel@ffwll.ch,
        alexander.deucher@amd.com, airlied@gmail.com,
        christian.koenig@amd.com
References: <20230512070451.107372-1-jiapeng.chong@linux.alibaba.com>
Content-Language: en-US
From:   Hamza Mahfooz <hamza.mahfooz@amd.com>
In-Reply-To: <20230512070451.107372-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0o1Q2QzVllubjBocG03RmlkKzd2djk0aGM2NSsvOVhhR2EwREZuSnpGR2Fw?=
 =?utf-8?B?MDRMSzBhSEJjMlV3S3h2L2g2dmk1NVdna0MwZmxmc3BmT0RDZWJXRk1sc3pP?=
 =?utf-8?B?VjhYcDV2QThKdUt6VldUdTJJQmV5Q2lWOER5dU5DeTdXdmpLd2VTa3dnV0FR?=
 =?utf-8?B?dHAzSEZ2UEsvUzQ3MHZuSWF1VDZITzJoWXFTQUYrcWppTy80Q1phMVczRG1E?=
 =?utf-8?B?YWNwVWtWSDR5TzdzbzFRdkNIRmt4R1d3UnZPQkJWT2FtL1lpUGFSbGo3WHls?=
 =?utf-8?B?VFJtb3pNSGwyejB1Y3ovRUxqTE5CdlhKYmluWWdsOHFyTlpsajVOUkV1L01m?=
 =?utf-8?B?eUhNOG03U0VuVzJva2ozNmNEOCs0dFMwQ2xIYi8vQnEwWWordmZ2S2Z3dDBC?=
 =?utf-8?B?TDlwMkJwTFhEZmxlQTRiMTFKMG9uOHVZblVmRm1ZaXRxY2lSdFRSR2hMMy9C?=
 =?utf-8?B?U3F1MXI4VWkwQ05SaWtMRk9MQ3hkZG84Vm9qWXY2WkZ6bkhWbVBjNVVsVkVI?=
 =?utf-8?B?WXV0TzZqQUFNclhNMjI1RFh2emhmUFRhbStLWDFsTEhDREkzM3B2cnZsMjJa?=
 =?utf-8?B?OWUxSmRkSHNYV09IaVBhd3BGRmZBOEZkUkl1MllPcU5VRzJ6bzkvVG1zd3d0?=
 =?utf-8?B?bXpMR0c4QW5sYXZlMzRObkpGR2NIQ2VyK3V0a0c4U3Q2NlQ5L21kZVNuRklx?=
 =?utf-8?B?U3E3SW5EY2NRVkVsUWNkQTZMVk1YZVFqOHptQ2MzK25pSVJzdi9KNlNLS2dG?=
 =?utf-8?B?MDJLUEl2VEEwSEF4dVZKeW5XclF6WnFaR05mMFZSSjNsOVdMYUk3endwdVZh?=
 =?utf-8?B?TnBUOHluOS9QTnE2TjF6c3JXaktjUjZSdXQ3KzN3YXBQM09jdWQxZ0pSOXla?=
 =?utf-8?B?MTNUMnlCRHdMMXpQRWNFMFVuSklUcGhhL2VhYXZ4MDZrd3hwa2c5TnVyQitS?=
 =?utf-8?B?cTFPMmNXNDBheHRmTmdQVGxvWFIzVWVSY09tSi90ZFJRY3hmNDJqSFJPTGsw?=
 =?utf-8?B?bHcvOUJLSlhrdTVPMFBaUmNsa0F6Z3hoQ2RHNkhvajd3aFRSRHJodEZKTkwz?=
 =?utf-8?B?VXlCYnZUcGZTL0VhKzlHMU85Vy82SkxsakNseDJaTTNndG8xb0JDYWZWbFJp?=
 =?utf-8?B?RXZJY09Zc1IvRWtSUnhnMFkwYVhEWGVGMC9TQnluKy95TmlQc0hzSEtOU2dm?=
 =?utf-8?B?T240OVlTQ2RFb1RrZS9UTDlxYm9sNjVaUWt2TjNnRVFMdW15M2R0S3Q3TXhk?=
 =?utf-8?B?N2RJZDA0TlNaQ3V3c29IajZtL0l1YnFDV0Vzd0N0NklJV0RTN1YreVNoMUp1?=
 =?utf-8?B?UjNvOTZWdENldk5BVDZ4NFhrVHl0ak9ZTk5UUjZkaEVNK3lYR1ZOc1Y0QTNr?=
 =?utf-8?B?akhVc0xPRmhhM1ZhNUtIYVRZdjBTZVBxNlFCWUlOZ2pXSERDSWk1N3B3MTVI?=
 =?utf-8?B?ZTRkNkVteEppcFc0MzBwVkVEV2NIWkd0TGdtMWVYUU1hWGJSeHRwTm1yY250?=
 =?utf-8?B?MVl5NlUrdzJXdHlCZ1dadXdqUmF3VHJmWEVoN01sNitxVXQvWHBLRTBpaVdj?=
 =?utf-8?B?Mys0L214V1FFdE9DeW9SR3lhU21PbkNBd28ycjBIN21waUV1ak5iOWhnVHlB?=
 =?utf-8?B?Q0MrMTVuTW9lUWoxMEgxMWpPQ0tHd2RLZjJxV0VUQmQ2QzdzVklHYjd6Tjha?=
 =?utf-8?B?L3N4RG1rV1RwRjRseXRmZlExWUpMczJxalc5OFllVHVZMWRxMzVFbG9ieGRV?=
 =?utf-8?B?OWdjdndGY043c2doMVc3RzdrOWhtT29tQW1WVXdNWk9FOHQrb08wWnZ0SmNP?=
 =?utf-8?B?azlyUys3WFp3YkFlQ3E4UDN4OWFzaHkzM25IR1hBdHlDZDk1TzM0UkFkRGxx?=
 =?utf-8?B?RVVpQzhNMWpQUUdBSnlwc2lYRTBWV1lZRDVEVDFCRE1LSHAxRHVqSEU0TVQ3?=
 =?utf-8?B?ckZiZm4vbWZFZFZFM0tMQmNVYVIxdEJGeXJxKysvQVV3eGN6a1o4R2NSWEwv?=
 =?utf-8?B?Q0tqMHNlQmNDdlBNNXBHZFEyVXFid0ExVmhUeFJkNytVYy8zN1VialBkMU9V?=
 =?utf-8?B?UWZLYzEyM0lNNG85U2pJNHJCdEVpYVZqVXR4YlRRSXNmRXZHZkdpQTlsSGhl?=
 =?utf-8?Q?nYV7rBan9toTxTS1Cul03c9i9?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 680f5503-8fd8-4150-b145-08db52f1e03c
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6280.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2023 14:05:00.8281
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i/6Oa2eJyPTeOAKV6H/HBwwLUu4Jt8KK0c8OjEeHo9bBhJ3wJGLRDg4XLXaEfIcE2pn39sjaE2zxxp6iqFVkvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7702
X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/12/23 03:04, Jiapeng Chong wrote:
> ./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c:586:37-39: WARNING !A || A && B is equivalent to !A || B.
> ./drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c:595:37-39: WARNING !A || A && B is equivalent to !A || B.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4941
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> index 4950eaa4406b..2de910e0ce75 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
> @@ -583,8 +583,8 @@ void dcn32_update_force_pstate(struct dc *dc, struct dc_state *context)
>   		struct pipe_ctx *pipe = &context->res_ctx.pipe_ctx[i];
>   		struct hubp *hubp = pipe->plane_res.hubp;
>   
> -		if (!pipe->stream || (pipe->stream && !(pipe->stream->mall_stream_config.type == SUBVP_MAIN ||
> -						pipe->stream->fpo_in_use))) {
> +		if (!pipe->stream || !(pipe->stream->mall_stream_config.type == SUBVP_MAIN ||
> +		    pipe->stream->fpo_in_use)) {
>   			if (hubp && hubp->funcs->hubp_update_force_pstate_disallow)
>   				hubp->funcs->hubp_update_force_pstate_disallow(hubp, false);
>   		}
> @@ -592,7 +592,7 @@ void dcn32_update_force_pstate(struct dc *dc, struct dc_state *context)
>   		/* Today only FPO uses cursor P-State force. Only clear cursor P-State force
>   		 * if it's not FPO.
>   		 */
> -		if (!pipe->stream || (pipe->stream && !pipe->stream->fpo_in_use)) {
> +		if (!pipe->stream || !pipe->stream->fpo_in_use) {
>   			if (hubp && hubp->funcs->hubp_update_force_cursor_pstate_disallow)
>   				hubp->funcs->hubp_update_force_cursor_pstate_disallow(hubp, false);
>   		}
-- 
Hamza