Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp10432879rwr; Fri, 12 May 2023 08:06:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7LOHND6X/tDs8TxSkYRhXrbVKizZxUAgzEMqmnS8GS3TpSbQBa1AhTyDZkLJs7ylh6/HaW X-Received: by 2002:a05:6a20:7da9:b0:100:95ca:b1e1 with SMTP id v41-20020a056a207da900b0010095cab1e1mr23997136pzj.37.1683903992679; Fri, 12 May 2023 08:06:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683903992; cv=none; d=google.com; s=arc-20160816; b=oMvJKe/AiTMKde9QCS09272hVGq+8p3TPjmj8YI4S0Cm/uaJJ/1HXFsKogwrHub4tP v9CabTdM/8WbKwmm/WGqCxYKN0WAiyjRYlGfXLG58DKZe1XrfOF1JbV2iwcmUAaTkmQX 7PsCBy5o9l7d+plxr6qyEENsZ6fuv/uin6n/t73SwZD/UeAgoQrATGOTcOmchEEQVycE 5Jm/+kjTwtFLVF7iOWUtroxmH+9naPev1RLVNHXLfaCxOKkjmjiqSYr9Z2R1D81HuMD/ oFmEzWdzPOat5f6xSoMVJTHEdT9ij0UsPiqq8hPJ1F6q38aPYxrBI8lyZOawS7Ao57aS Q+DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=gIKmWO5tzukwEI8c9S9P1AoN+6Xcn3IK4x6iJc8za/SfREUaCTe4OyoK8Wts7hxsdX ovIbIZKsptykRVXTo86/CRHubjntiGfxqCopqWaMUF6IhVhCIQBm4AjWR+AEg+lCOBh7 BTC9g1hPjjc1IKXxPzpQ2UVh7nIV1wQgZWUEOL67P/6qvYhrYfJdvOahIgQa60orDmop zhEqHaaj9Y6+ZeGACZhBfo8RlMk6DUw00JjwXHGyoi9xN3OKwTTfv9lGa5Js3fz/G4pY XrElaCz9GOoFk8ApaM3EjoAMSrC0KTVZP/zofennXhFMI+3BcGmILTAWl3Woe7E2xkbA NP4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a63-20020a639042000000b0051ba2478f50si9623218pge.511.2023.05.12.08.06.16; Fri, 12 May 2023 08:06:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241666AbjELO7W (ORCPT + 99 others); Fri, 12 May 2023 10:59:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241664AbjELO7S (ORCPT ); Fri, 12 May 2023 10:59:18 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52A033C03; Fri, 12 May 2023 07:58:49 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 6392A68AFE; Fri, 12 May 2023 16:58:33 +0200 (CEST) Date: Fri, 12 May 2023 16:58:32 +0200 From: Christoph Hellwig To: Yu Kuai Cc: hch@lst.de, tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk, yukuai3@huawei.com, lukas.bulwahn@gmail.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH -next v2 5/6] blk-iocost: move wbt_enable/disable_default() out of spinlock Message-ID: <20230512145832.GD5546@lst.de> References: <20230512093554.911753-1-yukuai1@huaweicloud.com> <20230512093554.911753-6-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230512093554.911753-6-yukuai1@huaweicloud.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig