Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp10449814rwr; Fri, 12 May 2023 08:17:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ48nwojBNRT6KWWZEDMofd7F9hsxcuyp5g70fTwxsC0hsEbEjXlh0jwlTajVRrqJUP3cahk X-Received: by 2002:a05:6a20:7fa9:b0:f8:ac26:b899 with SMTP id d41-20020a056a207fa900b000f8ac26b899mr31659728pzj.0.1683904640443; Fri, 12 May 2023 08:17:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683904640; cv=none; d=google.com; s=arc-20160816; b=AiLeBMioSpCtt1pfSLAxCDpKDm7OTBCfcQBrRiPCjXnJ65kBLAlQfXhV/OpZNgw/ww wyOmRO4sf102URhMt6xaTHCIdsqO4J1hhdiT52nZHdgfUKb0wYpPdHHR3PiZ25mxaKDt 3kG+FD1gTQKoU2V69GUFR/KrTlFpNOIKdV989OZuMYSHLXOlVqlGQwnhDOjR34LR3W+F h/BLnpVd4LQqPlXLoJCkr6G+RsYXJAQHZx1ZH2LwdVHadW54TEn96h1iPCk69QZPslAz a5dXJtakwin2TA2mURokrlqmiS38OY9zgbvOLZpwTUMk4SKGdn2+0DMOcCaB76FHO76V byUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=gCibvLLxmrwwjTg8tqAHybrQHxUO9Q8BGBSAxnFXhiw=; b=f4mrJ6lSIOo0C/HNS47ZDTDGjTqSZXdzABOuVvi/LMWkcJQX6yUJD13tFlUW+SLikc ZYs4tZHYiYTci6ke3d2YPKseM89lokK67IaL4/rEHIPTERh1QUgWXgDn6VXjvE1RxoIg tUw2jdOMalfjcYOBs9+YwMbZ/IqUNILVaDrpEjYVUYTbIFJBY5gZer18J+6CMJ/NS3mA 6nH5Z32BiHjkfvmEeZDh6j/vmvrCi1wca/PwZRcYLdYKx0YEZc9pNug1SENeWvn0Y1H7 gjbJHasLuo7J4f496bedFEppSgoEfT4ZXPYHG9DIIP0UYovva5AxhlWWhRrjJ7TDYQRC VBuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=uQb+J4jz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g9-20020a63fa49000000b0052c73367c13si9460914pgk.871.2023.05.12.08.17.07; Fri, 12 May 2023 08:17:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=uQb+J4jz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241727AbjELPJl (ORCPT + 99 others); Fri, 12 May 2023 11:09:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241730AbjELPJh (ORCPT ); Fri, 12 May 2023 11:09:37 -0400 Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A4765B83 for ; Fri, 12 May 2023 08:09:36 -0700 (PDT) Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-76c6ba5fafaso18798839f.1 for ; Fri, 12 May 2023 08:09:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1683904175; x=1686496175; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gCibvLLxmrwwjTg8tqAHybrQHxUO9Q8BGBSAxnFXhiw=; b=uQb+J4jzLKUfp8gagw5cGFiAeUpcv8jZJp1GHPpWmpH5ipBA16smx4xIf5dXo0kFt+ 8GFco37b1QZVTDLsrUc59o0pmGTqqi+/Qpf+QglCqnMTKQ7ve0Au+qGHWiu40eqcmuXq tRZZ+RomkmcHetSB4F4Ten7NhzlmLnvX+ZH5m5DO/LRzSGQqwgNL/qweq2O67gzIGqjc MiJgfs9oBjCHf6V3c9KE9H5PsHE6lUMNVV2lUxN9lnfahQMHEBGRb3KV40k7a+9VIaC+ B+AiDPgnY2JO6kEjuOgTgw3z+ikAybLXCLo3kEg3OrtP/hEreqnZzhzWQbgqssBrkyKF 0/xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683904175; x=1686496175; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gCibvLLxmrwwjTg8tqAHybrQHxUO9Q8BGBSAxnFXhiw=; b=gf2ebledd6ja/7Mhnn+l0GrhtgT7FqDM1sxUVD4HUcmv5e3LDaRQBoHCu2oYewBD7q 0kVNzpxxe7PPoZfTHlsir/Av9rzf2xTanslVlVxG1V1q0xdfqfk5q0bFzJlzocX0lQG2 YPmH764DpVepyj0XRhgFVzfSyQWUzWXFiy5iOTUcC09tBWOzdRC+am+Ci2VhBmMTCw7C K+nFgQSAh+jNrfG3tkrDAN/kYY6CU0EWybAG4QGzcW0uLiHkCa15POSeYVEObARwyL9I AT1yvI57Mc/HTt8m3ZheZZl3X+EHq2oGlyCEzfnURjgwWqJ9581DhC1iyB2GArUAVuT2 XY5Q== X-Gm-Message-State: AC+VfDyyvRbqvClIyQ15KmIPWKTvABYd1C7xR3yz2sPZodSFNO5Snu5K UhrK+YOGd7FHj25WfJGdVfVJdsd0E+CDGjzfgLQ= X-Received: by 2002:a05:6602:2b93:b0:76c:8a4c:ad79 with SMTP id r19-20020a0566022b9300b0076c8a4cad79mr2715877iov.1.1683904175386; Fri, 12 May 2023 08:09:35 -0700 (PDT) Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id u21-20020a6be315000000b0076c6f5b8db5sm1685542ioc.16.2023.05.12.08.09.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 08:09:34 -0700 (PDT) From: Jens Axboe To: josef@toxicpanda.com, Ivan Orlov Cc: linux-block@vger.kernel.org, nbd@other.debian.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, himadrispandya@gmail.com, linux-kernel-mentees@lists.linuxfoundation.org In-Reply-To: <20230512130533.98709-1-ivan.orlov0322@gmail.com> References: <20230512130533.98709-1-ivan.orlov0322@gmail.com> Subject: Re: [PATCH] nbd: Fix debugfs_create_dir error checking Message-Id: <168390417460.869582.2878039069012872149.b4-ty@kernel.dk> Date: Fri, 12 May 2023 09:09:34 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-00303 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 May 2023 17:05:32 +0400, Ivan Orlov wrote: > The debugfs_create_dir function returns ERR_PTR in case of error, and the > only correct way to check if an error occurred is 'IS_ERR' inline function. > This patch will replace the null-comparison with IS_ERR. > > Applied, thanks! [1/1] nbd: Fix debugfs_create_dir error checking commit: 4913cfcf014c95f0437db2df1734472fd3e15098 Best regards, -- Jens Axboe