Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 12 May 2023 17:34:22 +0200
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Janosch Frank <frankja@linux.ibm.com>
Cc:     Steffen Eiden <seiden@linux.ibm.com>, kvm@vger.kernel.org,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        Viktor Mihajlovski <mihajlov@linux.ibm.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Nico Boehr <nrb@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Hendrik Brueckner <brueckner@linux.ibm.com>
Subject: Re: [PATCH 5/5] s390/uv: Update query for secret-UVCs
Message-ID: <ZF5cfisjdpiFX/L7@osiris>
References: <20230512093153.206378-1-seiden@linux.ibm.com>
 <20230512093153.206378-6-seiden@linux.ibm.com>
 <ZF42vescJsAtK9pL@osiris>
 <b826b914-a3dc-488d-b4d8-23dbfee29e58@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b826b914-a3dc-488d-b4d8-23dbfee29e58@linux.ibm.com>
Precedence: bulk

On Fri, May 12, 2023 at 03:27:52PM +0200, Janosch Frank wrote:
> On 5/12/23 14:53, Heiko Carstens wrote:
> > On Fri, May 12, 2023 at 11:31:53AM +0200, Steffen Eiden wrote:
> > > Update the query struct such that secret-UVC related
> > > information can be parsed.
> > > Add sysfs files for these new values.
> > > 
> > > Signed-off-by: Steffen Eiden <seiden@linux.ibm.com>
> > > ---
> > >   arch/s390/boot/uv.c        |  4 ++++
> > >   arch/s390/include/asm/uv.h | 11 ++++++++++-
> > >   arch/s390/kernel/uv.c      | 40 ++++++++++++++++++++++++++++++++++++++
> > >   3 files changed, 54 insertions(+), 1 deletion(-)
> > ...
> > > +static ssize_t uv_query_supp_add_secret_req_ver(struct kobject *kobj,
> > > +						struct kobj_attribute *attr, char *page)
> > > +{
> > > +	return scnprintf(page, PAGE_SIZE, "%lx\n", uv_info.supp_add_secret_req_ver);
> > > +}
> > 
> > FWIW, another minor thing: all of these should be sysfs_emit() instead.
> 
> Do you want us to move all of them to sysfs_emit() eventually or should we
> keep the scnprintfs() which are already in uv.c ?

I'd convert the existing ones as well.