Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ec7b8f81-98ea-539c-c1b9-abf103e45b30@intel.com>
Date:   Fri, 12 May 2023 10:46:15 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] fpu: xstate: Keep xfd_state always in-sync with IA32_XFD
 MSR
Content-Language: en-US
To:     Thomas Gleixner <tglx@linutronix.de>,
        Adamos Ttofari <attofari@amazon.de>
CC:     <abusse@amazon.de>, <dwmw@amazon.co.uk>, <hborghor@amazon.de>,
        <sironi@amazon.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Kyle Huey <me@kylehuey.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        <linux-kernel@vger.kernel.org>
References: <20230511152818.13839-1-attofari@amazon.de> <877cted6pl.ffs@tglx>
From:   "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <877cted6pl.ffs@tglx>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmdQa0xPTTAwWlJTbzU1dmZsUEdCRzlSeFVMUG5oMVRyTmVpWkhuVG5qQnJE?=
 =?utf-8?B?b3ZJSjdld3poUFc4SjM2Yllwc2JUTHhWRnczbVVlNEN5NzdNWXQzalR1SkVs?=
 =?utf-8?B?ajE2ZThidDFETURuV0FiRGZzZHRKNnhUMHROaXlmemNjUjdyZG9rVGgwcm00?=
 =?utf-8?B?cHZJMEprTFE4ME9maUorbzZNQ0tMUWRDSnE2WUZMNldEYzk4VWVlUUJFVGJL?=
 =?utf-8?B?elkyb1daYVBZQkRzS0J5YU1jNmVNYWx4QVhuYW9ESXZ3TGVQNitQTlQ2TGlv?=
 =?utf-8?B?TUU2L2tYNDVvWUxMNXFiNUMvTFdFV2huVFNjOFBzSE5zY1JLM2MvNDBRNS9M?=
 =?utf-8?B?SUJWNW00Tk45N2VjYkRRczJmdFdGMDNuUjh4RHFYdklXcnpvaHRHckhmcGNT?=
 =?utf-8?B?Y1QySHpDelpIWFQ0VURIRFgxNWltK2lvM3ZkME5aMTdwUFJvV29EQWQxeDNR?=
 =?utf-8?B?d2Y5SUt5Q0pxRUZ2VEd5bTFkRlMvdTRhQU9KS1BWMnAwWXlpa1lnQXVmaXhs?=
 =?utf-8?B?RSsrR1JBZHZaaE5PaDdkdTlSNDFRVXA2YjgrTmd6UHR1bDgwVmM3Q01uSlNM?=
 =?utf-8?B?S2l3cXhDTjFnUEpFWEZET1NmNzZXb3dNcnpvNXplK0lCQ3RTd253YW1KTjhr?=
 =?utf-8?B?Wlk2OXR0Ukt3MnRNODduemU2MytyOTVtOS9wQTVlZUxkR1VpMDBtVkZlLytF?=
 =?utf-8?B?KzJXbnEyWjFobFhmYU5QbVllYjN6QlZ3OEJVTVV0UkxJczRGYnFBRUlvZlFE?=
 =?utf-8?B?K2tkMGJwWXFZZjJNR0ZaSEh3NFM2Z2x0K3VxMVhwV1I2UXBJZFIzT3k0Uys1?=
 =?utf-8?B?ajRraTkxdGJtejFLYmZUUEs3UGc2cnZjRUlkZ1M0bTlxUDlGU0ZxOVJrN0sz?=
 =?utf-8?B?MElpRmU0b3d6aTVIVUQ0czF3NVAwTjRXSTViQ01jZnU3YnFnKzNzQmJ1TXZz?=
 =?utf-8?B?dHF4YzhIcXZaTDNON2xYdEIvMHB4dWg0Y01VaDhsTGtGR2pVU1ZMRGR6QTRK?=
 =?utf-8?B?MGhyekx6QTNkdExRMlgxMFJ3clZYb3BJZ3FWWmhZdzRVZHN5YXhOZGJ5SXZX?=
 =?utf-8?B?V0kzbXQ5TjlYOHZCNXErZDMzY0FnSmFCTk9TUzJrY29IRStnditCdHRYbWZ3?=
 =?utf-8?B?Ym9SZW5DdVZKNU4xQ2txZ0VhcU1SYllCZ3I4OFhmL2paUHpCYlMrODhpZGgz?=
 =?utf-8?B?ZU10bE13MHkyOWY3RVBnTDdsaEFHcVlLQ2VtMElCbXBmTVI1VDEvb0plekRP?=
 =?utf-8?B?RE9QRjZIRndWbnk2ZDlwY3J1OXF3QU1yWnYwTHgwV1ZyaG9vWDNmdnlBUDIv?=
 =?utf-8?B?S1N4OVgvZnIrbmVhOHFZUW5xbzduY3JNby8yUUdiQVQram5pNE9tOWJaa2k3?=
 =?utf-8?B?S1E4M0NXU0dOdUNrOFRvaXBjNE1kUHVyODdnZi9PRjhHcEFPK09SU2diL2kr?=
 =?utf-8?B?VjE2YktXZzI4OEdLajVHVDZ2VDRVVkh6a1ZkWE1ka2lINzJUbnd5eDMrVnQr?=
 =?utf-8?B?dUtqVEltUFVUZkUrTDgwOGhRVlJieGRXTkVvN1ZPTXg3TnJiaWxod2VXaExq?=
 =?utf-8?B?WDBocUZETjN4aEpsdlkrbGhaYVU4bEh1MHZ1SG5pUDVFOGxuSGdsTk1XYXdO?=
 =?utf-8?B?WDhZUlJyVmp2RkgvakNUb3pENmF2QUlFWWhMWU5UYWl6REVVRkE5YzMwbWIx?=
 =?utf-8?B?ZHRjVVNGWEozcTJjRGxlNWFhdllkdVAyeTczRGw3b2twdHpnYWVibUtlRkNG?=
 =?utf-8?B?aVdZbVROdWYxMjJCVjFPUnZMcUFiRnZyMkhGTjRIZVd5cmROak03bHlZN2dN?=
 =?utf-8?B?cEJTSFBCYWRVYkI0eHFtVGlRc3hrdm45SVJvMW52MHUrSkZyaEpnbzJ6bHI2?=
 =?utf-8?B?bnlLWlNiRkM1SVo0emFFekRWVkZVWlJzWXIzZVFSQ3psZk40dENlL1RjQ2RI?=
 =?utf-8?B?bTN2U3N0RHNwZStTbFM3VHNvNWkvd1ZhajdUSmVtRkkyOTAwWlVSZTd4WUw5?=
 =?utf-8?B?U1Rxb1grVndOWmxuUUs3czhLRG1XbFFrd1FQbXdEQmdyWGdFOXpJbUtpQ2tT?=
 =?utf-8?B?MFBpWlVyaEhnYjA4OUhBWFRSSm1Sbk5VVjQ0bld2SU4vSnVtZnVnTHkrU3Rj?=
 =?utf-8?B?eHRNMmxhUUVaTlg1V2ZDc1hIWmNJckNSME5lcUZFeElsUXhyYjR4K09VaVlG?=
 =?utf-8?B?K2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e3123204-f2d8-476b-04e0-08db5310ccb0
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4855.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2023 17:46:22.3531
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ph3tnklrZp6KdmiBVcAL5fNdy0GoHjZL+vL7raJ/ZcbOf+So3q53+4YvD81dnPyjVEiEzTPtSh1w3FRhy5aMBQ+89vAPMjtEDNXsB+b/Nss=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7613
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/11/2023 12:11 PM, Thomas Gleixner wrote:
> On Thu, May 11 2023 at 15:28, Adamos Ttofari wrote:
> 
>> @@ -915,7 +921,7 @@ void fpu__resume_cpu(void)
>>   	}
>>   
>>   	if (fpu_state_size_dynamic())
>> -		wrmsrl(MSR_IA32_XFD, current->thread.fpu.fpstate->xfd);
>> +		xfd_update_state(&init_fpstate);

xfd_update_state() here is not a right choice as Thomas pointed out 
multiple times.

> On suspend per CPU xfd_state == current->thread.fpu.fpstate->xfd so it's
> correct to restore the exact state which was active _before_ suspend.
> xfd_state can't be out of sync in that case, no?

Indeed! But, looking around the code, writing 'xfd_state' here appears 
to be consistent and logical I suppose.

Every time writing the MSR in the kernel (except for the init), the 
value is saved in 'xfd_state'. So we don't do it on the sleep path. 
Then, on the wake-up path, perhaps it makes sense to restore the context 
with the saved.

Thanks,
Chang