Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230509104127.1997562-1-chenhuacai@loongson.cn> <20230512165309.896e063a9398639250eab264@linux-foundation.org>
In-Reply-To: <20230512165309.896e063a9398639250eab264@linux-foundation.org>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Sat, 13 May 2023 11:20:10 +0800
Message-ID: <CAAhV-H7zbc4hH=YJ9pZdT4jZC8=UUXewq6nbDVUjsAHp-bXWAg@mail.gmail.com>
Subject: Re: [PATCH RFC] kthread: Unify kernel_thread() and user_mode_thread()
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Luis Chamberlain <mcgrof@kernel.org>,
        "Eric W . Biederman" <ebiederm@xmission.com>,
        Kees Cook <keescook@chromium.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Andrew,

On Sat, May 13, 2023 at 7:53=E2=80=AFAM Andrew Morton <akpm@linux-foundatio=
n.org> wrote:
>
> On Tue,  9 May 2023 18:41:27 +0800 Huacai Chen <chenhuacai@loongson.cn> w=
rote:
>
> > Commit 343f4c49f2438d8 ("kthread: Don't allocate kthread_struct for ini=
t
> > and umh") introduces a new function user_mode_thread() for init and umh=
.
> > But the name is a bit confusing because init and umh are indeed kernel
> > threads at creation time, the real difference is "they will become user
> > processes". So let's unify the kernel_thread() and user_mode_thread() t=
o
> > kernel_thread() again, and add a new 'user' parameter for init and umh.
> >
> > ...
> >
> >  5 files changed, 9 insertions(+), 26 deletions(-)
> >
>
> Less code is nice.
>
> > -extern pid_t user_mode_thread(int (*fn)(void *), void *arg, unsigned l=
ong flags);
> > +                         unsigned long flags, int user);
>
> `bool user'?
OK, I will do that in the next version if the whole patch is acceptable.

Huacai
>
>