Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 13 May 2023 13:55:22 +0300
From:   Alexey Dobriyan <adobriyan@gmail.com>
To:     linux-kernel@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com,
        lstoakes@gmail.com, liushixin2@huawei.com, david@redhat.com,
        bhe@redhat.com, azeemshaikh38@gmail.com, akpm@linux-foundation.org
Subject: Re: + procfs-replace-all-non-returning-strlcpy-with-strscpy.patch
 added to mm-nonmm-unstable branch
Message-ID: <39b334c4-48e3-47ec-ae31-adeff2bf4839@p183>
References: <20230511043449.99AE6C433EF@smtp.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230511043449.99AE6C433EF@smtp.kernel.org>
Precedence: bulk

On Wed, May 10, 2023 at 09:34:49PM -0700, Andrew Morton wrote:
> Subject: procfs: replace all non-returning strlcpy with strscpy
> strlcpy() reads the entire source buffer first.  This read may exceed the
> destination size limit.

> This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1].

This is funny. C strings are always NUL-terminated by definition.

Reviewed-by: Alexey Dobriyan <adobriyan@gmail.com>

> --- a/fs/proc/kcore.c~procfs-replace-all-non-returning-strlcpy-with-strscpy
> +++ a/fs/proc/kcore.c
> @@ -419,7 +419,7 @@ static ssize_t read_kcore_iter(struct ki
>  		char *notes;
>  		size_t i = 0;
>  
> -		strlcpy(prpsinfo.pr_psargs, saved_command_line,
> +		strscpy(prpsinfo.pr_psargs, saved_command_line,
>  			sizeof(prpsinfo.pr_psargs));
>  
>  		notes = kzalloc(notes_len, GFP_KERNEL);