Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp11481206rwr; Sat, 13 May 2023 04:33:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6dASJfMWOZXvROa85r7bgdvVtYtd1Z61saAJ/A3kDExbjWKv9dQQrObF9LfkHvvgJ2r8DE X-Received: by 2002:a17:902:d491:b0:1ad:faf7:5c93 with SMTP id c17-20020a170902d49100b001adfaf75c93mr1825074plg.5.1683977629196; Sat, 13 May 2023 04:33:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683977629; cv=none; d=google.com; s=arc-20160816; b=Y8b5sV5pHzwwX0NaiCjP1LnpLqRjwZGfmuoJZCPFUZEPQCA9RRb2XkWNeSl7R0W1Cj c2505WTfE9wpo54UIX+zBlAhNRriahcZnsINnYueJH1pQUWU7016XVyfaDcFOQ2sU8Kz gnuLzF7HepqwZq5zAzbbnsVZ3l+y/yNByUWekCDx63UdaWBtC00u1UMg1rR+w+Ih3qU+ kJcwHl/+sk/gFgA1tCjHlL7ag1HevVEHNEEgxq66hZ9ilOT4K380L0LzBYUo1EAxznYa 9Ekzm/UpU2R7uniHsg4f9poW11z79MVvavXIMIefFbpWMKbEcJE0aL/+/95UqFrUGFr8 tZgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=rNewWpP+GvEj2PXHB6K/3b6wTSDIQG0EkEwU6jgQeQo=; b=Wg3Nac2C/eQMJtYtNjbaG9mr6jkOWLupZ6+DhQdUp25dWFCEI7TP5O+VyFkRUrv9sl t7MtVo1cjpmdQdJrkS5RkNF5FrIjQ+bD0s1oBNrKDn2XasX18exKHwYYnkIAs1pI6ZOX nQCT96ZKd4fMyt3ofWttzvKgGTP4FcE/lw8eXL2IW6DstixouOvNhvHUvIlwyugh6OE+ MC4mRm3jexrpAEUljz4NBvXBoPf8lEisuFzxNVleadu0E2ApeB9V7HUqJW/I73OnrQpK x8CueVDWQ3FjJwQnMXi9SI4CjXhQHwl92Glu5kL/50hQgl65daH+lseDKv1RgkK65Ikr +mbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q+zz4WuF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a6-20020a170902900600b001ab18eacb8csi10320852plp.526.2023.05.13.04.33.34; Sat, 13 May 2023 04:33:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=q+zz4WuF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237517AbjEML3V (ORCPT + 99 others); Sat, 13 May 2023 07:29:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231736AbjEML3T (ORCPT ); Sat, 13 May 2023 07:29:19 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F3532D5A for ; Sat, 13 May 2023 04:29:18 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-966287b0f72so1575002066b.0 for ; Sat, 13 May 2023 04:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683977357; x=1686569357; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rNewWpP+GvEj2PXHB6K/3b6wTSDIQG0EkEwU6jgQeQo=; b=q+zz4WuFUeDnQ814WpwLd5PeEwSdt9wDOQLQg6oc3OAn4TsEcOFt8joc7p4D2oVdr9 RGCtgpYuadZinGs/FbPCNIaIVa19Ttw7K9e0ESB6BME3SEVT2sVZnTwULS52lAVhGXBP D8ztSp7SDf25ag4Ng+e6vYPvORuUlyJj7ovRHv8J02er5jCRJTJBEYXACGeUOdB41889 rXO5d4ABvFxc9H7e271eDdeIUYQiji5ztGQ0VUSZj98J1jpXWtrIIImAU5UJl1QfJbWL rr7tpiimtNT0sWw7cI45lHjijZ36qCxSoKrc07MPp9N4psD1Inm9gep95oVsMInHy6LZ emjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683977357; x=1686569357; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rNewWpP+GvEj2PXHB6K/3b6wTSDIQG0EkEwU6jgQeQo=; b=bIfw46OZ+DdxEpK96bV8GgsrfT9MzIlmmrqtF6Gz0POgBTvAR3l3uApXFZ/GwL+yUu M1fK4v+/+STGrLSGqqxRRSR6U+1h7ZbfbFgRCioIGIts0T6SbJa6GM8YamjFIv8Qsdlh ykvF0uvVa8chiawOCf9Xuz2glsGInuzxcrtu5TFjRaTPHg4xIPTpkD6LswgIQUQLnVQi 1CQNsmEjmkMHif9Kpr/kwCSsDRxw5mCdNzVLIYrLeEQARsh5/QlN/aDAsVV5qadUX0U2 fl0+PMew4bruISStW7yhDlRLW82wVALWvIduP2SDXSuLJMrASDuoFr7PqFK88VoXs6cz Dc1w== X-Gm-Message-State: AC+VfDyBrH8I3/P+SvwrazD2VFYs/5mw9ysvoTqUQK4JbdKBi6fWYerJ 2UjzpS8+MasnvOl3rcGrve9G4w== X-Received: by 2002:a17:907:d1c:b0:966:5912:c4b with SMTP id gn28-20020a1709070d1c00b0096659120c4bmr20162276ejc.76.1683977356798; Sat, 13 May 2023 04:29:16 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3aa:fd4:f432:676b]) by smtp.gmail.com with ESMTPSA id k10-20020a1709067aca00b0096a1ba4e0d1sm5063946ejo.32.2023.05.13.04.29.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 May 2023 04:29:16 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] soc: qcom: rpmh-rsc: drop redundant unsigned >=0 comparision Date: Sat, 13 May 2023 13:29:13 +0200 Message-Id: <20230513112913.176009-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Unsigned int "minor" is always >= 0 as reported by Smatch: drivers/soc/qcom/rpmh-rsc.c:1076 rpmh_rsc_probe() warn: always true condition '(drv->ver.minor >= 0) => (0-u32max >= 0)' Signed-off-by: Krzysztof Kozlowski --- drivers/soc/qcom/rpmh-rsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c index f93544f6d796..0dd4363ebac8 100644 --- a/drivers/soc/qcom/rpmh-rsc.c +++ b/drivers/soc/qcom/rpmh-rsc.c @@ -1073,7 +1073,7 @@ static int rpmh_rsc_probe(struct platform_device *pdev) drv->ver.minor = rsc_id & (MINOR_VER_MASK << MINOR_VER_SHIFT); drv->ver.minor >>= MINOR_VER_SHIFT; - if (drv->ver.major == 3 && drv->ver.minor >= 0) + if (drv->ver.major == 3) drv->regs = rpmh_rsc_reg_offset_ver_3_0; else drv->regs = rpmh_rsc_reg_offset_ver_2_7; -- 2.34.1