Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   mirimmad@outlook.com
Cc:     skhan@linuxfoundation.org, Immad Mir <mirimmad17@gmail.com>,
        Ivan Orlov <ivan.orlov0322@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH] powerpc: fix debugfs_create_dir error checking
Date:   Sat, 13 May 2023 20:41:53 +0530
Message-ID: <CY5PR12MB6455FCF0BD8CF075FA6C8386C67A9@CY5PR12MB6455.namprd12.prod.outlook.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY5PR12MB6455:EE_|CH3PR12MB7593:EE_
X-MS-Office365-Filtering-Correlation-Id: 6a995d73-8bac-493b-3842-08db53c48191
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 28AacB9tP8OfoZFRRvkJEFVSFGZdvwpBdWsrAGyzb/k3cVuRDmlzxFbysr1kHGO4cajjbCOtp+hEXuB+PPaGUEpgo/pgpoQXAQwoDBO6AzWOam5nqpPlUzSNPC5XFtk1AUVbWKTXzdktYCxDm/tGOlealuAcKZ3wKQaY/nX2/N49ljRlIoK6UUC18cLHE8v7zuPl0bsqSXJxjo2YHFUsxD7casdw1PzZt8CLlQxsAlst+xYoUQKTBSX7ka35mTpRWY4aZqZP8zBbkEkVe0KHuFr1kjTbBtrTPbjYARm/VN7Kpax6RUlAf5o2CUQHcPlBt2K7Lml94Bzo/TRE0AKuGI6sKVwjJspWftoNsORCAN+sCnySyP7rwayiinmea0kneK5hlMz2t65RnGgnubwqsJTAEoanTcGhIzWDtoTVUZwBWclnLKayoYsQbXlm9Nm3cb0AAR+k7AV3pO+ESbtd9b66ME/soTOCdZrc3FscbUo5tc+3UjMHyoeGZSZpJn1Pp2CN6lTeUVDwnim/is2FAa0Ib/YrJZYInUyicllLIsxD9ULskTptG3lii2/SDF2p
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZXIoLlEtwJJdoG1FxJoILjFFqQwALnBKQ15QlcPjbWOrfBq0ELhiXFpNAWB0?=
 =?us-ascii?Q?ZFR/G+rFOozAxJYkZFp8Ld+/pNvDdTUYO4f1OLIV+0AMZFYV8nqYvXGfaDSa?=
 =?us-ascii?Q?FZ7pdEvdUyI0egbAblwXDXWKxvy7EZXpEJ4HX1Qo0Km2nSPh1x27CdIG/8ub?=
 =?us-ascii?Q?QgZAqzr0mU+Rwfdf27/WkmfmwRTi6pYQbun1RA2KVeSUBYi3sEgYI5eIMXO8?=
 =?us-ascii?Q?sc38aX8mS3PxCWZDTItpbFKH7LIGb+Udc0S+jtAPuQZJ6i844Xwj1Hg5bx3N?=
 =?us-ascii?Q?uUPW+OBpIE2zLUAmTvxDlW+0mInOjPMjy1WGasDKVVqVjT2Qx6El8s6U4Dl/?=
 =?us-ascii?Q?+l3X9mFNzQXJLK8bnWCpIGVpJpeaxXVPqYX8XTCATnbZnIEKIz7sHYADxj52?=
 =?us-ascii?Q?ov0b9pBlorbD0dNoNeMspP4co6lLCya89nqrgtNyOseuahomNNWEB1fcRksg?=
 =?us-ascii?Q?8z0U1gv4qyKQk7xHRW6p11uoRExSwTcVr6RNLEvjQC5CGcinapa/Iutt7dyu?=
 =?us-ascii?Q?oca532siSPPj9/e8DiBNxW+qRmH2Q9k2kjQP+sLpWjuP14CkwkdRrDXSj3Hr?=
 =?us-ascii?Q?WGpEbXEsZhwMkZcYpTqj38Dy1JPAMe3Bz9oM1Ezz1bOjWHVyqA+3NTGp4wmx?=
 =?us-ascii?Q?UInAANn+BQ9JGgcu/67dU3DvE3+WN13Xq3uRg8NQI0VMLWftVRPyZ54gTZY3?=
 =?us-ascii?Q?a1hGCkKRJ8m8MX0yhdGV28yYVUCqH70HIE7WBRNGi5qKHuXh667L6H/bkoRx?=
 =?us-ascii?Q?XCnKKE3R7VDYIcF6OHoLnwVVjGlQvyeCUrTD6JZ1WVZvtLRGIDf6nhYPdian?=
 =?us-ascii?Q?tl6tdIz6znRSoIzX9Gas4si3SOD/1dOzsBS47fsAOp8ReIaDu9NyvdU+z7gs?=
 =?us-ascii?Q?FUkTA/5iAjvo+GlAkPjA2A82/FB4IlKqXO52bZG0lR2N6h8GV/Iah8GUo10g?=
 =?us-ascii?Q?aIAroTIfbKJE3pU2TIItQNpmWu1+juc4D4/owtkUv1IsUSEdPy1KhPXbCR9W?=
 =?us-ascii?Q?pBX3p7fGSIO3SSp/SXEHOmyobog27mPNAZ7FY11mYmWHzTmrJQBB0j7SdsHu?=
 =?us-ascii?Q?HRo3bKH6RgzOF9YAnrbl2esWV4RIIQDEJDIWkCRe3W/ldvrAKMjv4t6+ZV6t?=
 =?us-ascii?Q?MGB2ja95IdpiBR1OCmi/sunsPIrQKAxhpmre5Px238j8A3hTV93DsXL6BqZe?=
 =?us-ascii?Q?0pg4kI44pfT8Dv7H10+96cRhcd7cDLFSqS8IhZ204B1f23aKljBLJXoVmOz+?=
 =?us-ascii?Q?raQUgBDBehHCBlhFiPpNTaZNgJaY2UAkmrsTPZ6gOA=3D=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6a995d73-8bac-493b-3842-08db53c48191
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6455.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2023 15:12:46.0372
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7593
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
To:     unlisted-recipients:; (no To-header on input)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Immad Mir <mirimmad17@gmail.com>

The debugfs_create_dir returns ERR_PTR incase of an error and the
correct way of checking it by using the IS_ERR inline function, and
not the simple null comparision. This patch fixes this.

Suggested-By: Ivan Orlov <ivan.orlov0322@gmail.com>
Signed-off-by: Immad Mir <mirimmad17@gmail.com>
---
 arch/powerpc/platforms/powernv/opal-xscom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/opal-xscom.c b/arch/powerpc/platforms/powernv/opal-xscom.c
index 6b4eed2ef..262cd6fac 100644
--- a/arch/powerpc/platforms/powernv/opal-xscom.c
+++ b/arch/powerpc/platforms/powernv/opal-xscom.c
@@ -168,7 +168,7 @@ static int scom_debug_init_one(struct dentry *root, struct device_node *dn,
 	ent->path.size = strlen((char *)ent->path.data);

 	dir = debugfs_create_dir(ent->name, root);
-	if (!dir) {
+	if (IS_ERR(dir)) {
 		kfree(ent->path.data);
 		kfree(ent);
 		return -1;
@@ -190,7 +190,7 @@ static int scom_debug_init(void)
 		return 0;

 	root = debugfs_create_dir("scom", arch_debugfs_dir);
-	if (!root)
+	if (IS_ERR(root))
 		return -1;

 	rc = 0;
--
2.40.0