Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 13 May 2023 19:19:12 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Stefan Popa <stefan.popa@analog.com>,
        linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: dac: build ad5758 driver when AD5758 is selected
Message-ID: <20230513191912.41276f94@jic23-huawei>
In-Reply-To: <20230508040208.12033-1-lukas.bulwahn@gmail.com>
References: <20230508040208.12033-1-lukas.bulwahn@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon,  8 May 2023 06:02:08 +0200
Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:

> Commit 28d1a7ac2a0d ("iio: dac: Add AD5758 support") adds the config AD5758
> and the corresponding driver ad5758.c. In the Makefile, the ad5758 driver
> is however included when AD5755 is selected, not when AD5758 is selected.
> 
> Probably, this was simply a mistake that happened by copy-and-paste and
> forgetting to adjust the actual line. Surprisingly, no one has ever noticed
> that this driver is actually only included when AD5755 is selected and that
> the config AD5758 has actually no effect on the build.
> 
> Fixes: 28d1a7ac2a0d ("iio: dac: Add AD5758 support")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

oops. That's been there a while so good spot!

Applied to the fixes-togreg branch of iio.git and marked for stable inclusion

Thanks,

Jonathan


> ---
>  drivers/iio/dac/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/Makefile b/drivers/iio/dac/Makefile
> index 6c74fea21736..addd97a78838 100644
> --- a/drivers/iio/dac/Makefile
> +++ b/drivers/iio/dac/Makefile
> @@ -17,7 +17,7 @@ obj-$(CONFIG_AD5592R_BASE) += ad5592r-base.o
>  obj-$(CONFIG_AD5592R) += ad5592r.o
>  obj-$(CONFIG_AD5593R) += ad5593r.o
>  obj-$(CONFIG_AD5755) += ad5755.o
> -obj-$(CONFIG_AD5755) += ad5758.o
> +obj-$(CONFIG_AD5758) += ad5758.o
>  obj-$(CONFIG_AD5761) += ad5761.o
>  obj-$(CONFIG_AD5764) += ad5764.o
>  obj-$(CONFIG_AD5766) += ad5766.o