Received: by 2002:a05:6358:98a5:b0:11e:80f4:e92 with SMTP id q37csp11228710rwa; Sat, 13 May 2023 11:28:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7zYZdbdTbIUQIn4AJms6I6pnyAnG588QCr5i3oS1y1jUFpLHj/+7Mdf6bcgif0sfGWqGDo X-Received: by 2002:a05:6a20:8f1f:b0:101:b080:e744 with SMTP id b31-20020a056a208f1f00b00101b080e744mr20031929pzk.42.1684002537013; Sat, 13 May 2023 11:28:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684002536; cv=none; d=google.com; s=arc-20160816; b=kLuhnVoLPLrk5vKZstA562uChgE9iQ9ztsp9nFb7mi42YWORBD54/mQ1BkIRKi1uJh qMRsUPIydTDljjldtNLZA818ALs0G9JIxy0OEcZ6Q8OcF1cHTNJtY9X/PXYJxisLlxA2 ouGk8t3gcDjzK/MX4seo700aVZVqgR72Zu9lsZboC1pXk8Nl2baaUS9jcjVEUFOAO2H+ l5CTw7iVkSzz5ciS679K/44p0KqTtLeRDcOxNBFL26tcoHHNsZD+OyrE5Vs6UsmhOqVF ftXIHPx+yJuyE7qezvz+Rr8AcUqxXLaFGBhv/byK/f6Z46L9esDGAGUNS6Lj1vKcxdc2 E9MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=yKcUfCMnaq5XA2syyCcnhi9qmO2wcNbjo1Qr3uKgKLI=; b=Kd6VCXHqg+sam6HtJnNJkpdCvbBb5bHkiga2eY3Jg796LCJcMXiO7SlOA8l6oUlCZ7 5hDkD66cdpZ96brXTaSGSBmel4dyupd0KEruxvm0/p7TclyWrapbQra0UjSgdRnI+Tig TrWJ5pTgsuvcuCshfkczK95PqKczhQoOxZG/lqMP6/1QLKev19TWFRBaBIda4YSRF667 xq9qthr+ov3xGwgKdpsU9zQ3wDmwxXybg4l1D49QDS4efqtsbEnI6tHevq+BpnSCSpgM xVohtZ1Q5h0oGZTHjO1JaLqC85rQCDpsShNyb6lWuvI5rftBoPt/Ze8KqWA/wJPkbSQf Kwcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OhMCDqFH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s20-20020a639254000000b0052857fbb31dsi11900881pgn.200.2023.05.13.11.28.43; Sat, 13 May 2023 11:28:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OhMCDqFH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230337AbjEMST2 (ORCPT + 99 others); Sat, 13 May 2023 14:19:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbjEMST0 (ORCPT ); Sat, 13 May 2023 14:19:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A91D819A1; Sat, 13 May 2023 11:19:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 457FD60F53; Sat, 13 May 2023 18:19:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5C29C433D2; Sat, 13 May 2023 18:19:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684001964; bh=hZODh/ox4glU1Ki7513kJtAmIJxEoe+oI1Y6344lCKI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OhMCDqFHA5WkhjCic4BpYmicmZn4mBltLnRwOE270wd6TpFAZdHcPToDjh5Xxorb4 HMyKb0Ionmgx5Ei9LNU/FOvqPd8jT+PY9QYLu4uWI5jgwutpu3B43ZQF9gERDZt4dw KHFTnKWzZaQd3Th2IUq6ikWIMe22vsuFK3UTYljrXJMtOTj2t5hGwOPNbLLZqhSXoH D+8aATnVX5jkez9dIno/9VPMpBzuA5rOawBbtR+ORiWHz7ebQYkNzZ4HgQssEsvxKf m5DuAAg1v1IkoQcoNBt077X2LodVugf10OGDKUYyTkFjtz6h4HaCnEtr2vLtDSGX7k W4Q7rwam0BSrw== Date: Sat, 13 May 2023 19:35:25 +0100 From: Jonathan Cameron To: Herve Codina Cc: Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Christophe Leroy , Thomas Petazzoni Subject: Re: [PATCH v4 2/3] iio: potentiometer: Add support for the Renesas X9250 potentiometers Message-ID: <20230513193525.43a4475f@jic23-huawei> In-Reply-To: <20230509160852.158101-3-herve.codina@bootlin.com> References: <20230509160852.158101-1-herve.codina@bootlin.com> <20230509160852.158101-3-herve.codina@bootlin.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 May 2023 18:08:51 +0200 Herve Codina wrote: > The Renesas X9250 integrates four digitally controlled potentiometers. > On each potentiometer, the X9250T has a 100 kOhms total resistance and > the X9250U has a 50 kOhms total resistance. > > Signed-off-by: Herve Codina As I only noticed one trivial thing I made the change whilst applying. diff --git a/drivers/iio/potentiometer/x9250.c b/drivers/iio/potentiometer/x9250.c index 3d4ca18d1f14..7e145d7d14f1 100644 --- a/drivers/iio/potentiometer/x9250.c +++ b/drivers/iio/potentiometer/x9250.c @@ -176,10 +176,7 @@ static int x9250_probe(struct spi_device *spi) x9250 = iio_priv(indio_dev); x9250->spi = spi; - x9250->cfg = device_get_match_data(&spi->dev); - if (!x9250->cfg) - x9250->cfg = &x9250_cfg[spi_get_device_id(spi)->driver_data]; - + x9250->cfg = spi_get_device_match_data(spi); x9250->wp_gpio = devm_gpiod_get_optional(&spi->dev, "wp", GPIOD_OUT_LOW); if (IS_ERR(x9250->wp_gpio)) return dev_err_probe(&spi->dev, PTR_ERR(x9250->wp_gpio),