Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6894e9f7-7100-255b-b026-5ccf485a7e31@basealt.ru>
Date:   Sun, 14 May 2023 10:59:44 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH] e1000e: Fix bind network card with ID = 0x0D4F
To:     "Neftin, Sasha" <sasha.neftin@intel.com>, kovalev@altlinux.org,
        nickel@altlinux.org, jesse.brandeburg@intel.com,
        anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org,
        jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        pabeni@redhat.com, edumazet@google.com,
        "Ruinskiy, Dima" <dima.ruinskiy@intel.com>,
        "Fuxbrumer, Devora" <devora.fuxbrumer@intel.com>,
        "naamax.meir" <naamax.meir@linux.intel.com>
References: <20230512231944.100501-1-kovalev@altlinux.org>
 <c9ef1c57-3ec5-5cf8-c025-63527280f2fa@intel.com>
Content-Language: en-US
From:   =?UTF-8?B?0JLQsNGB0LjQu9C40Lkg0JrQvtCy0LDQu9C10LI=?= 
        <kovalevvv@basealt.ru>
In-Reply-To: <c9ef1c57-3ec5-5cf8-c025-63527280f2fa@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

14.05.2023 09:00, Neftin, Sasha пишет:
>> Fixes: 914ee9c436cbe9 ("e1000e: Add support for Comet Lake")
>> Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
>> ---
>>   drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c 
>> b/drivers/net/ethernet/intel/e1000e/netdev.c
>> index db8e06157da29..8b13f19309c39 100644
>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>> @@ -7887,7 +7887,7 @@ static const struct pci_device_id 
>> e1000_pci_tbl[] = {
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_LM9), 
>> board_pch_cnp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V9), 
>> board_pch_cnp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM10), 
>> board_pch_cnp },
>> -    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V10), 
>> board_pch_cnp },
>> +    { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V10), 
>> board_pch_adp },
> This is wrong approach. (we can not process old board similar as new)
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM11), 
>> board_pch_cnp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V11), 
>> board_pch_cnp },
>>       { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM12), 
>> board_pch_spt },
> Looking in commit 639e298f432fb0 (e1000e: Fix packet loss on Tiger 
> Lake and later) I would suggest to replace the mac->type as follow:
> "if (mac->type >= e1000_pch_tgp)" with "if (mac->type >= 
> e1000_pch_cnp)" (more correct) - try it on your side.

I checked this variant first of all - the behavior is correct, network 
packets are not lost. Can I prepare a new patch or will this change be 
made by you?

-- 
Best regards,
Vasiliy Kovalev