Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <51dbd824-7d90-8a69-902b-d643347abdf3@linaro.org>
Date:   Sun, 14 May 2023 11:55:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 3/3] arm64: dts: allwinner: h6: tanix-tx6: Add compatible
 bluetooth
Content-Language: en-US
To:     Rudi Heitbaum <rudi@heitbaum.com>, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, wens@csie.org, jernej.skrabec@gmail.com,
        samuel@sholland.org, marcel@holtmann.org, johan.hedberg@gmail.com,
        luiz.dentz@gmail.com, anarsoul@gmail.com, alistair@alistair23.me
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-sunxi@lists.linux.dev, linux-bluetooth@vger.kernel.org
References: <20230514074731.70614-1-rudi@heitbaum.com>
 <20230514074731.70614-4-rudi@heitbaum.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230514074731.70614-4-rudi@heitbaum.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 14/05/2023 09:47, Rudi Heitbaum wrote:
> Tanix TX6 comes either with RTL8822BS or RTL8822CS wifi+bt combo module.
> Add compatible for RTL8822BS as it uses different firmware.
> 
> Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
> ---

Thank you for your patch. There is something to discuss/improve.

>  arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> index 9a38ff9b3fc7..9460ccbc247d 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> @@ -21,7 +21,7 @@ &uart1 {
>  	status = "okay";
>  
>  	bluetooth {
> -		compatible = "realtek,rtl8822cs-bt";
> +		compatible = "realtek,rtl8822bs-bt", "realtek,rtl8822cs-bt";

This neither matches bindings nor your commit msg. If device has
different chips, then you should not stuff all of compatibles together.
Please analyze the case. Maybe you need different boards for different
revisions?

Best regards,
Krzysztof