Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp677171rwd; Sun, 14 May 2023 04:49:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ZtsxZhp2CtIYSIKRHhtIc4E9kxa0mjbgzsmvoL0BEibPOnMujDA7w6VhTo7xIIu0jajFN X-Received: by 2002:a05:6a00:84a:b0:646:e940:c2c4 with SMTP id q10-20020a056a00084a00b00646e940c2c4mr26876033pfk.14.1684064952124; Sun, 14 May 2023 04:49:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684064952; cv=none; d=google.com; s=arc-20160816; b=uueuhFktdGvEGRGAGr8vPeUfjCcEFKSgV5NkP5Z8fjWv75xPTORegGm4RAWscJ/Dnb 20pKdFoRIZbG9rydU4LZFHw51OWXpmXWROXSJyMSTnOFXpDjz9fTA/t63WBucBpLGQl9 23uKecRHcQEseO+s0y+t+J+xnj9PVpA4jq2TC56LH3IvuYVPO20Cw/3duBD5eUAJvO/Q EfbW+JyDmyGS3/js6bgt5aP0mtdqIHIqEfFyBBXIxS8EIoobzag0k75fN+mybyVW66ts LOs5WAr50C4u9VqjWKcaKSyU+yX1BQ+is7Uq1O37MEDMCSJ7mUev6lCITEa5U8fx1dJ/ 4hSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WpU5u1IYy960T8Ocos3ADdjyflEH2x7R2sDGVedcwRc=; b=ctqjV2tLGVZbEYSW7XdJrEGs/ZsN8KBGMgod5DfM1H7J6g7IUcN+Prp4mETgXnUbw8 V0ZnId5+n6Aj/A9FVsKHOmUEG2y2qSPbZHFtei+67WlPNLZX3bVwMJ/x3g5cd19lCme6 oT4mhyie0nSi7S9BrKBH9eP/c6ykf4STYNBTuxEZd5eKXs4KHOKqPo1ksmSvgNNWmIyv VAYqnt5Hae48gBGtEOR8+MqA2LIf3xQy1vmM1AtiBCuk+EtWPCMVySXaDOhQ3MVVe7Eq snXSYmYu7OrM30CQLPBLCeFNi4pZKvm+a4/3g3gciDvBPhyzLo/HEk0/Q6Zm8NnYYTMa Vaig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mp3GBAf3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w8-20020a63f508000000b005183e6198aasi13803303pgh.794.2023.05.14.04.48.58; Sun, 14 May 2023 04:49:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mp3GBAf3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237123AbjENJqv (ORCPT + 99 others); Sun, 14 May 2023 05:46:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235602AbjENJqp (ORCPT ); Sun, 14 May 2023 05:46:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BD7E2107 for ; Sun, 14 May 2023 02:46:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1746C61161 for ; Sun, 14 May 2023 09:46:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2889C433EF; Sun, 14 May 2023 09:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684057593; bh=wGeoCKdWcLNGSz8WoWm3Y/aAAFpiDlIXI/v9WFuO9SE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mp3GBAf3LzDUamiCidb3P3OlJifz+RcW8MqMVQ51d9JaEDeOIWVYR+xh7/f4e7S+y mEKhgR//b9STacoLXO56B975kgZv1Wr1K26aOpCOUuK20RHnQPkMlPl6wKg09N4s4l N5BbgmyFn2/aLOfArJnewwsr/GR3BnGpRJ7vd3aALF3dGmIEpC5MKz58G384oTJTVr /4EdaN3bCb0ogSPKozZ5h2rm6D9MtNBffpLLc1oi8JDU9nJaJ0DOPW1yCJvHrGtf/L XQ3zpXodU+inOapslWV0Je4cZGTHEiHJo5ogeDnNnobYeYiqTo4xO0hJuSJuQv6Ze+ 25PFIiRN/Go4Q== Date: Sun, 14 May 2023 12:46:22 +0300 From: Mike Rapoport To: Claudio Migliorelli Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix some coding style errors in memblock.c Message-ID: References: <87r0sa7mm8.fsf@mail.polimi.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r0sa7mm8.fsf@mail.polimi.it> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 23, 2023 at 03:29:35PM +0200, Claudio Migliorelli wrote: > This patch removes the initialization of some static variables to 0 and > `false` in the memblock source file, according to the coding style > guidelines. > > Signed-off-by: Claudio Migliorelli Sorry for the delay. Applied, thanks! > mm/memblock.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 25fd0626a9e7..6f0a2eda427c 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -156,10 +156,10 @@ static __refdata struct memblock_type *memblock_memory = &memblock.memory; > } while (0) > > static int memblock_debug __initdata_memblock; > -static bool system_has_some_mirror __initdata_memblock = false; > +static bool system_has_some_mirror __initdata_memblock; > static int memblock_can_resize __initdata_memblock; > -static int memblock_memory_in_slab __initdata_memblock = 0; > -static int memblock_reserved_in_slab __initdata_memblock = 0; > +static int memblock_memory_in_slab __initdata_memblock; > +static int memblock_reserved_in_slab __initdata_memblock; > > static enum memblock_flags __init_memblock choose_memblock_flags(void) > { > -- > 2.38.4 > > -- Sincerely yours, Mike.