Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 14 May 2023 20:32:53 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Adam Ford <aford173@gmail.com>
Cc:     linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Marek Vasut <marex@denx.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] arm64: dts: imx8mn: Fix video clock parents
Message-ID: <20230514123253.GS727834@dragon>
References: <20230423123513.1346323-1-aford173@gmail.com>
 <20230514035806.GR727834@dragon>
 <CAHCN7x+evo1mJaBUdx5pe5rnG2A8dkmf4myXJcK7mas7nZMwxg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHCN7x+evo1mJaBUdx5pe5rnG2A8dkmf4myXJcK7mas7nZMwxg@mail.gmail.com>
Precedence: bulk

On Sat, May 13, 2023 at 11:23:04PM -0500, Adam Ford wrote:
> On Sat, May 13, 2023 at 10:58 PM Shawn Guo <shawnguo@kernel.org> wrote:
> >
> > On Sun, Apr 23, 2023 at 07:35:13AM -0500, Adam Ford wrote:
> > > There are a few clocks whose parents are set in mipi_dsi
> > > and mxsfb nodes, but these clocks are used by the disp_blk_ctrl
> > > power domain which may cause an issue when re-parenting, resuling
> > > in a disp_pixel clock having the wrong parent and wrong rate.
> > >
> > > Fix this by moving the assigned-clock-parents as associate clock
> > > assignments to the power-domain node to setup these clocks before
> > > they are enabled.
> > >
> > > Fixes: d825fb6455d5 ("arm64: dts: imx8mn: Add display pipeline components")
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > Is it a fix for v6.4-rc or material for -next?
> 
> The Samsung DSI driver for Nano is in 6.4, and an attempt was made to
> setup the device tree in 6.4.  While I don't think there are users of
> this yet, if people try to add DT entries in their boards, they might
> struggle getting the video working if this isn't applied since the
> disp1_pix clock may be stuck at 24MHz which likely won't sync much if
> any displays.

Ok, applied for v6.4-rc, thanks!