Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 14 May 2023 17:17:46 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Tom Rix <trix@redhat.com>
Cc:     pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netfilter-devel@vger.kernel.org,
        coreteam@netfilter.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: conntrack: define variables
 exp_nat_nla_policy and any_addr with CONFIG_NF_NAT
Message-ID: <ZGD7mphdxml6qgCx@corigine.com>
References: <20230514140010.3399219-1-trix@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230514140010.3399219-1-trix@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2hZR2J4NXgzaXduSzlxa2xtSi9SS0FPdEdKaGhQQ2huemtOREdNYUpoK0lZ?=
 =?utf-8?B?OEs1SUtSZ0RJRTVNMEJ2R2UvV3pSNHRLdWZjeWdsYnltWG9BWmRkRTF2MzE0?=
 =?utf-8?B?MVArRUc3Z2hveEVrWCtBRUhUYnEvd1BnT25USkgvTE9rZkxibVg5VWZXSlZy?=
 =?utf-8?B?ZnAxSVdWTU9pYnlVUklxbndLZE5kRkJIenltZzRSSXREME8wTjloOTIyK2dy?=
 =?utf-8?B?M0cxa1RiZ1NmQkpGUDZNSG5LQU9WTlpuNHBoQzlxOHpkSURyNkltWmowNFQ2?=
 =?utf-8?B?cWVCNHVDRVI1MEdZTVU5TmIwdDhKU3ZkZ2drNXQrcHZQWms4KzFmcCtIUmtZ?=
 =?utf-8?B?VTZ0ZU9YaktXNTFWcHJwNXZXd09UN3FMZy9ob3J6bHRLb3ZERXdHVmU0VExa?=
 =?utf-8?B?cXI3dnQyb2ZxSm1jWWZUTldsTW8wRWZveFNhNFNVa0tFMzZabUluK1paemk2?=
 =?utf-8?B?b0ljc0s0TkErdDhsWVVVUjRySTFvcHBnNjE1dmQ5VlkwM0M4UFF6ZFAyMll0?=
 =?utf-8?B?eEVQTjN6WFVYTnExZEUxb1lvOHBDeDRoajJyMkEyWXVMbWVTZ0lVQ1ZIcFdr?=
 =?utf-8?B?SlhPZDZ0akZuK2J6YkhzOFU0eEw2aDhJZEwxaVcyV3craVQ0WWFwcmxIVmVt?=
 =?utf-8?B?NGEySzNnV25PaElnQ2hLME03dlpZWUZpOGZ4L3ZicVc3MnBDMFN4a0VVZzla?=
 =?utf-8?B?cEczWXRyY1dYSm5acElHeCs1bUoydFJwS1BTNWlSa0JGWVIrT1FUdUw4V0li?=
 =?utf-8?B?SVRUYjRJT1ZIZnRtWHdGVkxya29xaFFNMVJ5MjdCZjB0UTlBekpFWHJUL1o2?=
 =?utf-8?B?UEJ6NE5XWVJzeFZSNk1PUUlDMWF2OUk1YlNHcWhjUjAwY3VGZEozQ3hqWmc4?=
 =?utf-8?B?cFZHbFBvZ2NtVDNNc2srRFpRVUIyMTlvR3JKNkFTMm5ONnBseld2TWNJSmky?=
 =?utf-8?B?c0twRlg5eTc5bG1tYzNNWTdwY2hScnpSM012WmxkaE5HQk40UWJFVVA3cUJY?=
 =?utf-8?B?VHdMZ28rcXZsQWJsTWJmVnBtdENodmlrbGxXdGM4c0ZyNG9LQXdZZ2M3WjJi?=
 =?utf-8?B?Q0xERWtyc1hxU1JHWU1IL0JLRkRDSVR0VjZXMzBNLzAyQURLb3I0VDNraDBI?=
 =?utf-8?B?VHlkNktFUlI4UDd6UDJHNEFveUpFaGZneHNBTnkrdG04ZTBzdzI1d0VoeTVJ?=
 =?utf-8?B?M0U1Wmh5ckRrVVEwTy9XRmlEd21iTmk3TXZSNWVpU1h5SXdMVityT2QvY2Q0?=
 =?utf-8?B?d0NMb1dsbzFaUksvMjZBL2orWjJwUm4reDN2dUFORnNSbUJLOW5lR0tlQXNN?=
 =?utf-8?B?NG9nMC9KK2hvZXdySGJMYS9JaVppTEFOb09sS29uZzJOS1hrRTRzT3lKWGp0?=
 =?utf-8?B?M0lqazIxOGJIeHNqTUJzUFAzb3Vjb1lqUS9sQkx5dk9BUHFySHRnS1p6bnMv?=
 =?utf-8?B?c3hVVkVXUlduNmZET2wvMUgrK2s0ZWhVR0VmMUl0b2Fkb1FaUEZlZnF2TjdE?=
 =?utf-8?B?VS9rUEVmTnF3SGQxVVpveFc0dW5maEdyQVoxN24rM3I0QmN3NTlpQkg3cEpZ?=
 =?utf-8?B?TjJ1T2pwSStWbFEyUzRXT1dkSTIzOUt0V0FiVW02STNqR01rTE9Rdm8rNHZQ?=
 =?utf-8?B?RGxYN0xhMmFGcldjcHVWREZwaVFsU3gvck13OWRub3MrT1Nqb29VRXp5SU95?=
 =?utf-8?B?WC9PQWVKMXkxd01hWWIyL0p0cWFTR2dQSjZYREpZY1duYnRsOG1RVVhHK3Rp?=
 =?utf-8?B?S3NXbFB4N3h5OEZKcDE1VVA3c0VzVzhSclVrbnh1ODV2bTFlRTZ2TTlFWDdl?=
 =?utf-8?B?aU84WlJyR3dtWE5MT1ZGenB4Ymszdndjbm5TYytBYi9TTEJyRTNDaldKb05a?=
 =?utf-8?B?dzZLZ0N5ZzdnUS9hY1NXQ04zUEUrL2o1aEx1cm9DeGhxYXJ3cUZwVi9yWGRv?=
 =?utf-8?B?NmtQMlJXVFp0Tm5YQy8xWmZibWNYa2tWM2lvNSs4M0tIekhHWlcwLzNKNkVr?=
 =?utf-8?B?Wmt5Wkc5Y1phVW1kQUFlWWgrTXpwS0xuK0pWTlZtUmRZWGtWSGlOUlcrY3Vh?=
 =?utf-8?B?U2JCZ3FxaWhIQ0VPNEFtYlhqdDRQZWcrY0RVZFk5czJuang1cVJnUENXRTJQ?=
 =?utf-8?B?RW5uTUQrdWZQUTV0aWFXMzB2aWFpNk1tVzEwSytoWXJJWG1OOWZ4UjhvOWV4?=
 =?utf-8?B?akdWMU93V3d1SFl3YjB3TWV3bG9ZNnV6dTI0WURHY212WlNxL2Vnam1LLyto?=
 =?utf-8?B?RG1JcHJsanZKSStydU9udmQ4UmJ3PT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62620db4-07ce-4fc0-9147-08db548e63bf
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2023 15:17:54.0594
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bZ0JEAVAOutSgIi8vDBTdprP2op1fxXzBy+elhnTrZQS8hmGQzgE0dHsXA/InNzynOfqL7j8SEjwZY7MQsWiAD9L5naMuS3nUCjSCZAqPHc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3907
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, May 14, 2023 at 10:00:10AM -0400, Tom Rix wrote:
> gcc with W=1 and ! CONFIG_NF_NAT
> net/netfilter/nf_conntrack_netlink.c:3463:32: error:
>   ‘exp_nat_nla_policy’ defined but not used [-Werror=unused-const-variable=]
>  3463 | static const struct nla_policy exp_nat_nla_policy[CTA_EXPECT_NAT_MAX+1] = {
>       |                                ^~~~~~~~~~~~~~~~~~
> net/netfilter/nf_conntrack_netlink.c:2979:33: error:
>   ‘any_addr’ defined but not used [-Werror=unused-const-variable=]
>  2979 | static const union nf_inet_addr any_addr;
>       |                                 ^~~~~~~~
> 
> These variables use is controlled by CONFIG_NF_NAT, so should their definitions.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>