Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230514201909.506090-1-martin.blumenstingl@googlemail.com> <2558ba71-4f51-e186-b51b-554a72f19e19@gmx.net>
In-Reply-To: <2558ba71-4f51-e186-b51b-554a72f19e19@gmx.net>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Sun, 14 May 2023 23:07:38 +0200
Message-ID: <CAFBinCApNjwgJ9vSjYqvZj5xn6vQzynFqB7KAvcT7KgB4fX+ig@mail.gmail.com>
Subject: Re: [PATCH v2] ARM: dts: meson8: correct uart_B and uart_C clock references
To:     Hans-Frieder Vogt <hfdevel@gmx.net>
Cc:     linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, neil.armstrong@linaro.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, May 14, 2023 at 11:01=E2=80=AFPM Hans-Frieder Vogt <hfdevel@gmx.net=
> wrote:
[...]
> >   &uart_B {
> >       compatible =3D "amlogic,meson8-uart";
> > -     clocks =3D <&xtal>, <&clkc CLKID_UART0>, <&clkc CLKID_CLK81>;
> > +     clocks =3D <&xtal>, <&clkc CLKID_UART2>, <&clkc CLKID_CLK81>;
> Shouldn't the second clock reference for uart_B rather be CLKID_UART1,
> similar to meson8b?
> Sorry, didn't spot this earlier.
You're totally right - thank you for spotting this!
I'll send a fixed v3 soon.