Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   andy.shevchenko@gmail.com
Date:   Mon, 15 May 2023 00:10:39 +0300
To:     Lizhe <sensor1010@163.com>
Cc:     linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] drivers/pinconf.c: Remove redundant check for the
 existence of the member
Message-ID: <ZGFOT9cWNTzJDXo7@surfacebook>
References: <20230514165932.251200-1-sensor1010@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230514165932.251200-1-sensor1010@163.com>
Precedence: bulk

Mon, May 15, 2023 at 12:59:32AM +0800, Lizhe kirjoitti:
> "pin_config_set" in pinconf_ops.
> 
> In the function of registering pinctrl_dev, pinctrl_init_controller(),
> a non-null check has already been performed on the members
> pin_config_set and pin_config_group_set in the ops structure.

NAK.

Try to analyse what `if (!foo && !bar)` means from the logic perspective and
deduce from that the problem in your proposal.

P.S. It's not the first wrong proposed change from you. Dunno if you even
trying to read the code...

-- 
With Best Regards,
Andy Shevchenko