Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b26499be-e8e1-5812-a134-dbeb58118124@kernel.org>
Date:   Mon, 15 May 2023 07:53:20 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2] ata: libata-core: Simplies if condition
Content-Language: en-US
To:     Yahu Gao <yahu.gao@outlook.com>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        Yahu Gao <gaoyh12@lenovo.com>, Jiwei Sun <sunjw10@lenovo.com>
References: <20230422121415.6276-1-yahu.gao@outlook.com>
 <OS3P286MB0632739A614E451725FF697D9E619@OS3P286MB0632.JPNP286.PROD.OUTLOOK.COM>
 <OS0P286MB06283D2E74F02D7C541E46D79E6B9@OS0P286MB0628.JPNP286.PROD.OUTLOOK.COM>
From:   Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <OS0P286MB06283D2E74F02D7C541E46D79E6B9@OS0P286MB0628.JPNP286.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 4/28/23 10:53, Yahu Gao wrote:
> ping ...
> 
> 在 2023/4/22 20:14, Yahu Gao 写道:
>> From: Yahu Gao <gaoyh12@lenovo.com>
>>
>> Replace conditions of avoid issuing [P]IDENTIFY to PMP.

Please be a little more descriptive. Something like:

Simplify the condition used in ata_dev_revalidate() to not issue identify
commands to port multiplier devices.

would be better.

>>
>> Reviewed-by: Jiwei Sun <sunjw10@lenovo.com>

Where does this review come from ? I have never seen an email for it. I cannot
accept this tag without seeing the email for it.

>> Signed-off-by: Yahu Gao <gaoyh12@lenovo.com>
>>
>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>> index 14c17c3bda4e..53f65d751189 100644
>> --- a/drivers/ata/libata-core.c
>> +++ b/drivers/ata/libata-core.c
>> @@ -3802,11 +3802,7 @@ int ata_dev_revalidate(struct ata_device *dev, unsigned int new_class,
>>   		return -ENODEV;
>>   
>>   	/* fail early if !ATA && !ATAPI to avoid issuing [P]IDENTIFY to PMP */
>> -	if (ata_class_enabled(new_class) &&

Please keep the above "ata_class_enabled(new_class) &&" condition:

	if (ata_class_enabled(new_class) && new_class == ATA_DEV_PMP) {

While keeping this condition is logically not necessary, having it makes the
code easier to understand.

>> -	    new_class != ATA_DEV_ATA &&
>> -	    new_class != ATA_DEV_ATAPI &&
>> -	    new_class != ATA_DEV_ZAC &&
>> -	    new_class != ATA_DEV_SEMB) {
>> +	if (new_class == ATA_DEV_PMP) {
>>   		ata_dev_info(dev, "class mismatch %u != %u\n",
>>   			     dev->class, new_class);
>>   		rc = -ENODEV;