Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 14 May 2023 19:43:25 -0400
From:   Kent Overstreet <kent.overstreet@linux.dev>
To:     Christophe Leroy <christophe.leroy@csgroup.eu>
Cc:     Lorenzo Stoakes <lstoakes@gmail.com>,
        Christoph Hellwig <hch@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-bcachefs@vger.kernel.org" <linux-bcachefs@vger.kernel.org>,
        Kent Overstreet <kent.overstreet@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Uladzislau Rezki <urezki@gmail.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec
Message-ID: <ZGFyHY6pH9CU4fzf@moria.home.lan>
References: <20230509165657.1735798-1-kent.overstreet@linux.dev>
 <20230509165657.1735798-8-kent.overstreet@linux.dev>
 <ZFqxEWqD19eHe353@infradead.org>
 <ZFq3SdSBJ_LWsOgd@murray>
 <8f76b8c2-f59d-43fc-9613-bb094e53fb16@lucifer.local>
 <ce5125be-464e-44ad-8d9e-7c818f794db1@csgroup.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ce5125be-464e-44ad-8d9e-7c818f794db1@csgroup.eu>
Precedence: bulk

On Sun, May 14, 2023 at 06:39:00PM +0000, Christophe Leroy wrote:
> I addition to that, I still don't understand why you bring back 
> vmalloc_exec() instead of using module_alloc().
> 
> As reminded in a previous response, some architectures like powerpc/32s 
> cannot allocate exec memory in vmalloc space. On powerpc this is because 
> exec protection is performed on 256Mbytes segments and vmalloc space is 
> flagged non-exec. Some other architectures have a constraint on distance 
> between kernel core text and other text.
> 
> Today you have for instance kprobes in the kernel that need dynamic exec 
> memory. It uses module_alloc() to get it. On some architectures you also 
> have ftrace that gets some exec memory with module_alloc().
> 
> So, I still don't understand why you cannot use module_alloc() and need 
> vmalloc_exec() instead.

Because I didn't know about it :)

Looks like that is indeed the appropriate interface (if a bit poorly
named), I'll switch to using that, thanks.

It'll still need to be exported, but it looks like the W|X attribute
discussion is not really germane here since it's what other in kernel
users are using, and there's nothing particularly special about how
bcachefs is using it compared to them.