Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 May 2023 09:34:26 +0900
From:   Mark Brown <broonie@kernel.org>
To:     =?iso-8859-1?Q?B=F6rge_Str=FCmpfel?= <boerge.struempfel@gmail.com>
Cc:     bstruempfel@ultratronik.de, andy.shevchenko@gmail.com,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] spi: dt-bindings: Introduce spi-mosi-idle-low flag
Message-ID: <ZGF+Ei5sn4ci41LU@finisterre.sirena.org.uk>
References: <20230511135632.78344-1-bstruempfel@ultratronik.de>
 <20230511231317.158214-1-bstruempfel@ultratronik.de>
 <20230511231317.158214-2-bstruempfel@ultratronik.de>
 <ZF2y1YNkSbXzRm4V@finisterre.sirena.org.uk>
 <CAEktqcthEG=AWTk9VcVkwexH6xV_xHw1hqxkkPkD=d1NqPKqSg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jG3+yPPt0iwCjHtr"
Content-Disposition: inline
In-Reply-To: <CAEktqcthEG=AWTk9VcVkwexH6xV_xHw1hqxkkPkD=d1NqPKqSg@mail.gmail.com>
Precedence: bulk


--jG3+yPPt0iwCjHtr
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 12, 2023 at 08:54:19AM +0200, B=F6rge Str=FCmpfel wrote:
> Am Fr., 12. Mai 2023 um 05:30 Uhr schrieb Mark Brown <broonie@kernel.org>:

> > If this is always required for a given device (which I'd expect to be
> > the case) why configure it through DT?  I know we've got some legacy
> > stuff like that but not all legacy DT choices were good and no need to
> > continue the pattern.

> Yes this will always be the case for specific spi-device, spi-controller
> combinations. Just to make sure, that I understand your suggestion
> correctly: You propose to check from the specific spi-device-driver, if
> the spi-controller supports this particular mode-bit, and then set it if
> it does and thereby loose the need for the DT entry completely?

Yes, we shouldn't need DT here.  Though the device should just be
setting this unconditionally if it's always required.

--jG3+yPPt0iwCjHtr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRhfhEACgkQJNaLcl1U
h9CUQwf9GOgkGMy4AAK5Y1LcKpaX1j7DIItEjuPWsM9sjmduKp921EvFyALp/hqU
UdQ3emjnx3i2kaV+9GxNuIB3auUEu2xE2guAzd2tRbLbDOaK/4k8G3blLSghOBYu
CQy7EGP8JKKM658ru88SQMTC2A7IXS5HNh0s1WwakmaynDYkIk0bO0dqz8zwR23P
BoYJQgr9Z6TQwoivQ9/M5pO3cH/FIEw1gY8ajxdbsUXwRd75qJCL+rLjNbC654cb
kryggjSO7KUNPUpUdQM/H9p2W7v1zl4iJcvr8P3/b9k7qwwluFSFJHyUnOZ3Ecd8
gOIvDmrDs66z0vPIcd8Mb5X73Dr0mg==
=QIKm
-----END PGP SIGNATURE-----

--jG3+yPPt0iwCjHtr--